Re: [OSPF] Genart last call review of draft-ietf-ospf-encapsulation-cap-06

"Acee Lindem (acee)" <acee@cisco.com> Mon, 21 August 2017 15:58 UTC

Return-Path: <acee@cisco.com>
X-Original-To: ospf@ietfa.amsl.com
Delivered-To: ospf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 060B3132A67; Mon, 21 Aug 2017 08:58:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.521
X-Spam-Level:
X-Spam-Status: No, score=-14.521 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cgDIHrLfHOm5; Mon, 21 Aug 2017 08:58:04 -0700 (PDT)
Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9D8AD132026; Mon, 21 Aug 2017 08:58:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3064; q=dns/txt; s=iport; t=1503331083; x=1504540683; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=No6ajkc5S4oiXBoZQKX/Rso2HVW9HUEaFM05JmBKDOA=; b=RANbbanpKpC47TI6OWgVrihdHsEJuk4F15WXBJj0RiVY5Czv6oL6Lv7j BS+jidPgOSsdE9mysL7j1qskA9j7ZDliQ3ZYDFKwZ1DA5vkkhuprzAK8R 1Njr7HpvvU5EJaCEnVqeZyK/cqp3AAnrkDjSLe5xnw/eBPriYOrGYhDHf Y=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0DQAADeAZtZ/4MNJK1eGQEBAQEBAQEBAQEBBwEBAQEBg1pkgRUHg3CKG5AWgW6WHoISLIUbAhqDdT8YAQIBAQEBAQEBayiFGQEEASMRRQULAgEIDgYGAiYCAgIwFRACBAENBYopCBCvN4Imi10BAQEBAQEBAQEBAQEBAQEBAQEBAQEYBYELgh2CAoMvgyeEc4MTgmEFmB2IMgKHUoxughCFYYptlh8BHziBCncVh2N2iVKBDwEBAQ
X-IronPort-AV: E=Sophos;i="5.41,409,1498521600"; d="scan'208";a="283321334"
Received: from alln-core-1.cisco.com ([173.36.13.131]) by rcdn-iport-9.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 21 Aug 2017 15:58:02 +0000
Received: from XCH-RTP-015.cisco.com (xch-rtp-015.cisco.com [64.101.220.155]) by alln-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id v7LFw2Gs028335 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 21 Aug 2017 15:58:02 GMT
Received: from xch-rtp-015.cisco.com (64.101.220.155) by XCH-RTP-015.cisco.com (64.101.220.155) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 21 Aug 2017 11:58:01 -0400
Received: from xch-rtp-015.cisco.com ([64.101.220.155]) by XCH-RTP-015.cisco.com ([64.101.220.155]) with mapi id 15.00.1210.000; Mon, 21 Aug 2017 11:58:01 -0400
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Pete Resnick <presnick@qti.qualcomm.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "ospf@ietf.org" <ospf@ietf.org>, "draft-ietf-ospf-encapsulation-cap.all@ietf.org" <draft-ietf-ospf-encapsulation-cap.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-ospf-encapsulation-cap-06
Thread-Index: AQHTGpPf4Ro7Zv5kzUulT2W0ZGd6S6KO90qA
Date: Mon, 21 Aug 2017 15:58:01 +0000
Message-ID: <D5C07A8A.C26DE%acee@cisco.com>
References: <150333004648.6756.16820249680656378919@ietfa.amsl.com>
In-Reply-To: <150333004648.6756.16820249680656378919@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.116.152.201]
Content-Type: text/plain; charset="utf-8"
Content-ID: <CB6E2D895E7B23498A34CEACF9E45ED6@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/ospf/hA7OYHQf6V4AaIRpP_cdemGxsZk>
Subject: Re: [OSPF] Genart last call review of draft-ietf-ospf-encapsulation-cap-06
X-BeenThere: ospf@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: The Official IETF OSPG WG Mailing List <ospf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ospf>, <mailto:ospf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ospf/>
List-Post: <mailto:ospf@ietf.org>
List-Help: <mailto:ospf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Aug 2017 15:58:06 -0000

Hi Pete,

On 8/21/17, 11:40 AM, "Pete Resnick" <presnick@qti.qualcomm.com> wrote:

>Reviewer: Pete Resnick
>Review result: Almost Ready
>
>I am the assigned Gen-ART reviewer for this draft. The General Area
>Review Team (Gen-ART) reviews all IETF documents being processed
>by the IESG for the IETF Chair.  Please treat these comments just
>like any other last call comments.
>
>For more information, please see the FAQ at
>
><https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>
>Document: draft-ietf-ospf-encapsulation-cap-06
>Reviewer: Pete Resnick
>Review Date: 2017-08-21
>IETF LC End Date: 2017-08-28
>IESG Telechat date: 2017-08-31
>
>Summary: Almost Ready
>
>The content of this document is fine. However, I think the IANA registry
>stuff
>is not ready.
>
>Major issues:
>
>I think the registrations other than for Endpoint and Color are incorrect
>and
>should not be in this document. Certainly the "Reference" field for 1, 2,
>5, 6,
>and 7 should not be "This document", given that the syntax and semantics
>for
>these values are defined in other documents.

The authors can fix these.

> I also think that having things in
>this registry which are also used by the BGP registry is asking for
>trouble:
>You wouldn't want the references for the two registries to get out of
>sync.
>This seems like a mess to me. Would it be possible for IANA to simply
>rename
>the "BGP Tunnel Encapsulation Attribute Sub-TLVs" registry to "BGP and
>OSPF
>Tunnel Encapsulation Attribute Sub-TLVs", and share the registry between
>the
>two protocols? Then have this (and other) document(s) add values to that
>registry. That way, the documents that actually define the codepoints can
>be
>put into the registry.

We’ve already had a protracted discussion on the IANA registries. It is
not possible as BGP advertises some of the attributes in BGP communities
rather than tunnel attributes (e.g., color).

Thanks,
Acee 

>
>Minor issues:
>
>None.
>
>Nits/editorial comments:
>
>In section 7.1, please add:
>
>   [RFC Editor: Please replace "TBD1" in section 3 with the registry value
>   allocated by IANA, and remove this note].
>
>That will save them from hunting.
>