Re: [Pce] Shepherd review of draft-ietf-pce-stateful-pce-lsp-scheduling

Huaimo Chen <huaimo.chen@futurewei.com> Mon, 06 January 2020 03:37 UTC

Return-Path: <huaimo.chen@futurewei.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8B8EF12008D; Sun, 5 Jan 2020 19:37:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=futurewei.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C6c8_vpZ-Xk5; Sun, 5 Jan 2020 19:37:25 -0800 (PST)
Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2095.outbound.protection.outlook.com [40.107.237.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DB69812001B; Sun, 5 Jan 2020 19:37:24 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EJM5ZYwkKn8D4jF1Esvjj1nxanBMb6YtYt8pj5Sg1h8Ph3NQ90rmF/ZN/Mu9DrEOzZe5/ScuxJEGhH5aWa2MkqUshRmRYxLpwqYmwGteMiFgMP1ufYIveM4uMS6+nLCWu6GQGd7A4yGd0JUs4Jb63znMI6PsCEzSaWTXOr0QLBAQOqMwJWsfbfDObw3maGBevZtcS9FQf/RLqZVZaAyHUcbMX9xfz2xgRJm9yzN2EKQZRctZFjPlMepW1v9X4kFNWXJwcqDhSmnf0Yw5yQDblV+3D/yIBS62XS6AYGZT/25y7VtGHFcjOcu0oxrE0Vu13m3CteAE2Rc+mLKXstVZXQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KXRUBxk5eCkAGwP1dGYAggOJnIufIe2klDu3w+tAHfU=; b=HSWWmLLVHcIBbrwaD5Wr+wGfRNLGCvI9nVkAKt7zKNzCNnSGMsqkJjG2bN+/vh6/5qkyj64cC2oDWWDpHc0kaedM/DwK4vsdJYVM5HJdgaOXbpOwR0ByXHGn8qJABMwWSQMN0t8YRHvgsEnuq09b+AvqUrUPSNDtTs2nqVddbWyJzzT2JffkhGHCcggyDcMnDil7pXZaulcpms3vfaPgOjdFbdS807i01JkTylDuMks6GNz0qlsWiQkVXktidhxfvxKHY3xFqdlWPRUDq7DQp14llPActIEOTUFteTk7i4Rjf3R93so5hTsy0Gk9doypllPD1q1Txt7Ov4QCoFfC/w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=futurewei.com; dmarc=pass action=none header.from=futurewei.com; dkim=pass header.d=futurewei.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Futurewei.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KXRUBxk5eCkAGwP1dGYAggOJnIufIe2klDu3w+tAHfU=; b=pDZ4pBbWXVWrTFinxYxn4LYFe7IrqrQ9Z+4P+eijPkvN6A75iYq1HwMxfJ8n8ggf612y1cyDlCsBjSDLz6Vu3m+M3EDqV3EQt4fP8xJUZmOdV5IqdL2Eq6Lvgv4ktowwLYK1Xd59xhMJjiiBw4MY+8+OWylhZEfgKRhmfnS2tV0=
Received: from SN6PR13MB2271.namprd13.prod.outlook.com (52.135.93.160) by SN6PR13MB2541.namprd13.prod.outlook.com (52.135.89.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.4; Mon, 6 Jan 2020 03:37:21 +0000
Received: from SN6PR13MB2271.namprd13.prod.outlook.com ([fe80::70b0:78f1:a9bf:4b64]) by SN6PR13MB2271.namprd13.prod.outlook.com ([fe80::70b0:78f1:a9bf:4b64%7]) with mapi id 15.20.2602.015; Mon, 6 Jan 2020 03:37:21 +0000
From: Huaimo Chen <huaimo.chen@futurewei.com>
To: "draft-ietf-pce-stateful-pce-lsp-scheduling@ietf.org" <draft-ietf-pce-stateful-pce-lsp-scheduling@ietf.org>, "adrian@olddog.co.uk" <adrian@olddog.co.uk>
CC: "pce@ietf.org" <pce@ietf.org>
Thread-Topic: Shepherd review of draft-ietf-pce-stateful-pce-lsp-scheduling
Thread-Index: AdXDTJ6UVH4sFIesQzmG4RqAc3dffgA9R4V5
Date: Mon, 06 Jan 2020 03:37:21 +0000
Message-ID: <SN6PR13MB22717E695E754D7B4A547B42F23C0@SN6PR13MB2271.namprd13.prod.outlook.com>
References: <02e401d5c34e$92b6da20$b8248e60$@olddog.co.uk>
In-Reply-To: <02e401d5c34e$92b6da20$b8248e60$@olddog.co.uk>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=huaimo.chen@futurewei.com;
x-originating-ip: [73.114.233.24]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c32f29e0-678d-43ef-bfaf-08d79259bcba
x-ms-traffictypediagnostic: SN6PR13MB2541:
x-microsoft-antispam-prvs: <SN6PR13MB2541E880D42A2EFF75451D4DF23C0@SN6PR13MB2541.namprd13.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 0274272F87
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(4636009)(376002)(136003)(346002)(366004)(39830400003)(396003)(189003)(199004)(26005)(19627405001)(478600001)(2906002)(4326008)(33656002)(52536014)(7696005)(45080400002)(5660300002)(6506007)(53546011)(110136005)(55016002)(9686003)(44832011)(316002)(86362001)(966005)(8936002)(66476007)(76116006)(71200400001)(186003)(81166006)(81156014)(66946007)(66556008)(8676002)(66446008)(64756008); DIR:OUT; SFP:1102; SCL:1; SRVR:SN6PR13MB2541; H:SN6PR13MB2271.namprd13.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: futurewei.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: HWYlg0Fa1gwTpKg3MKGQsKGVlvlYC/FZ65Ww2idle6TgkGiv5FQaNYiZM+wMHQwc8JPIF9LyzWAYDXKXS5MHlIKF01yv9TqBBeywR0GekMeAasvr+Su6Uz0dvIRukX9UiD57SZRXAOBIK1Po9KR5tQjCcOqhb/aWskjji/womLQWHy1MFG2gyOuS8EMkBQgoMUCoOtA0dPqmP3r2HnfOHE6WxTkToi+lZD/78qq9X/Wg+phjbm0rOfgqGOonw+EzGtC/yvZPFYMNF7lv+m2C2UxyTjrSey6GBwHL3SJDOanDN7rqIE666TExLfL+UPb5k6jOMFqa7lGqquSWhWXkTXVv8HGVfr96O3whj6yI5mSeVmn2WqpskUWKbeC7eR2fp0Hi4uX/GjgixiwcrEFvbWSnq9HNRVPFWH8NMjhtp63RSvzneUbbnFvRY0s3zd8zVwzj7qWCRUrfbj8JOJr/l150ItJOGn5T5QCiZqXgZww5QA3xjAEWTEaEvS6HROL6VOCNvCB+TuSgLQzetuy5Cg==
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_SN6PR13MB22717E695E754D7B4A547B42F23C0SN6PR13MB2271namp_"
MIME-Version: 1.0
X-OriginatorOrg: Futurewei.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c32f29e0-678d-43ef-bfaf-08d79259bcba
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2020 03:37:21.0075 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0fee8ff2-a3b2-4018-9c75-3a1d5591fedc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BIcGRC1CX/Gy3dKVA0u3eBiN2LzDVfldVlL+udmqtfUO/2u9x6lbrj8L53bO2DkeA80JNqoZRPNgdejHQTiHpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR13MB2541
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/D2L8SyBc2nxXi6T9XhBXdiWk_K0>
Subject: Re: [Pce] Shepherd review of draft-ietf-pce-stateful-pce-lsp-scheduling
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Jan 2020 03:37:28 -0000

Hi Adrian,

    Thank you very much for your comments and suggestions.
    The document has been updated accordingly.

Best Regards,
Huaimo
________________________________
From: Adrian Farrel <adrian@olddog.co.uk>
Sent: Saturday, January 4, 2020 5:30 PM
To: draft-ietf-pce-stateful-pce-lsp-scheduling@ietf.org <draft-ietf-pce-stateful-pce-lsp-scheduling@ietf.org>
Cc: pce@ietf.org <pce@ietf.org>
Subject: Shepherd review of draft-ietf-pce-stateful-pce-lsp-scheduling

Hi authors,

Just doing the shepherd write-up after working group last call and I have a
nit in section 10.3

You ask for a new registry of bits, but you don't tell IANA the size of the
registry.

I think, to be consistent with (e.g.)
https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.iana.org%2Fassignments%2Fpcep%2Fpcep.xhtml%23stateful-pce-capability-tlv&amp;data=02%7C01%7Chuaimo.chen%40futurewei.com%7C233c0ebb38fb4f382d8108d79165bac7%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637137738448839025&amp;sdata=06D3YsdOtXIuB2dEhU3Yvn0y8h3bz1TvQITOxArDvig%3D&amp;reserved=0
-flag-field you should have:

OLD
   The following values are defined in this document:

   Bit    Description                                    Reference
   0      R-bit                                          This document
   1      C-bit                                          This document
   2      A-bit                                          This document
NEW
   IANA is requested to populate this registry as follows:

   Bit    Description                                    Reference
   0      R-bit                                          This document
   1      C-bit                                          This document
   2      A-bit                                          This document
   3-7  Unassigned
END

HC: Updated the document to contain the unassigned bits.

However, please also consider that other TLV bit registries have started
assigning bits from the largest number (sometimes 31, sometimes 15) counting
downwards. This is not important, just "interesting".

HC: Revised the document to start assigning bits from the largest one.

Afraid we need a new revision before we can advance the document. While
you're at it, can you fix the references noted by idnits.

Thanks,
Adrian