Re: [Pce] Genart last call review of draft-ietf-pce-rfc6006bis-03

Roni Even <roni.even@huawei.com> Sat, 19 August 2017 14:21 UTC

Return-Path: <roni.even@huawei.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8405E13282D; Sat, 19 Aug 2017 07:21:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.22
X-Spam-Level:
X-Spam-Status: No, score=-4.22 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nH-hJkiKAHNW; Sat, 19 Aug 2017 07:21:12 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 856E7132825; Sat, 19 Aug 2017 07:21:11 -0700 (PDT)
Received: from 172.18.7.190 (EHLO LHREML713-CAH.china.huawei.com) ([172.18.7.190]) by lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DMX99228; Sat, 19 Aug 2017 14:21:09 +0000 (GMT)
Received: from DGGEMM404-HUB.china.huawei.com (10.3.20.212) by LHREML713-CAH.china.huawei.com (10.201.108.36) with Microsoft SMTP Server (TLS) id 14.3.301.0; Sat, 19 Aug 2017 15:21:08 +0100
Received: from DGGEMM506-MBX.china.huawei.com ([169.254.3.138]) by DGGEMM404-HUB.china.huawei.com ([10.3.20.212]) with mapi id 14.03.0301.000; Sat, 19 Aug 2017 22:20:56 +0800
From: Roni Even <roni.even@huawei.com>
To: Dhruv Dhody <dhruv.dhody@huawei.com>, Roni Even <ron.even.tlv@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-pce-rfc6006bis.all@ietf.org" <draft-ietf-pce-rfc6006bis.all@ietf.org>, "pce@ietf.org" <pce@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
Thread-Topic: [Pce] Genart last call review of draft-ietf-pce-rfc6006bis-03
Thread-Index: AQHTFDrKXuNsUXmJ/0aASYriy6cC9KKIDkRAgAO04uA=
Date: Sat, 19 Aug 2017 14:20:56 +0000
Message-ID: <6E58094ECC8D8344914996DAD28F1CCD7FED7B@DGGEMM506-MBX.china.huawei.com>
References: <150263205807.26527.8869013927407425945@ietfa.amsl.com> <23CE718903A838468A8B325B80962F9B8CBB37A0@blreml501-mbx>
In-Reply-To: <23CE718903A838468A8B325B80962F9B8CBB37A0@blreml501-mbx>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.210.165.147]
Content-Type: text/plain; charset="windows-1255"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A010203.59984955.0048, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=169.254.3.138, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: af1ef5618c163fe384c012dbf9167f12
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/SQ1cqmG2wQs3MQdIMXOcR4_GEbo>
Subject: Re: [Pce] Genart last call review of draft-ietf-pce-rfc6006bis-03
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Aug 2017 14:21:15 -0000

Hi,
I did not see the text in RFC6006bis but this current text does not say much. If there is some work to reference in PCE  like pce-pcep-yang then add it otherwise I suggest to delete this sentence
Roni

> -----Original Message-----
> From: Gen-art [mailto:gen-art-bounces@ietf.org] On Behalf Of Dhruv Dhody
> Sent: יום ה 17 אוגוסט 2017 12:06
> To: Roni Even; gen-art@ietf.org
> Cc: draft-ietf-pce-rfc6006bis.all@ietf.org; pce@ietf.org; ietf@ietf.org
> Subject: Re: [Gen-art] [Pce] Genart last call review of draft-ietf-pce-
> rfc6006bis-03
> 
> Hi Roni,
> 
> Thanks for your comments. See inline...
> 
> > -----Original Message-----
> > From: Pce [mailto:pce-bounces@ietf.org] On Behalf Of Roni Even
> > Sent: 13 August 2017 19:18
> > To: gen-art@ietf.org
> > Cc: draft-ietf-pce-rfc6006bis.all@ietf.org; pce@ietf.org;
> > ietf@ietf.org
> > Subject: [Pce] Genart last call review of draft-ietf-pce-rfc6006bis-03
> >
> > Reviewer: Roni Even
> > Review result: Ready with Nits
> >
> > I am the assigned Gen-ART reviewer for this draft. The General Area
> > Review Team (Gen-ART) reviews all IETF documents being processed by
> > the IESG for the IETF Chair.  Please treat these comments just like
> > any other last call comments.
> >
> > For more information, please see the FAQ at
> >
> > <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> >
> > Document: draft-ietf-pce-rfc6006bis-??
> > Reviewer: Roni Even
> > Review Date: 2017-08-13
> > IETF LC End Date: 2017-08-24
> > IESG Telechat date: 2017-08-31
> >
> > Summary: The document is ready for publication as standard track RFC
> >
> > I read all the document and also did a compare with RFC6006 to look at
> > the changes.
> >
> > Major issues:
> >
> > Minor issues:
> >
> > Nits/editorial comments:
> >
> > 1. In section 4.2 I am not sure why is this sentence there, is it for
> > the current yang document or for a future one. Why have it at
> > all?-"The PCEP YANG module [I-D.ietf-pce-pcep-yang] can be extended to
> > also include the P2MP related parameters."
> >
> [[Dhruv Dhody]] The text around MIB existed from RFC6006. Since then the
> focus has shifted to Yang.
> We wanted to keep this text about Yang to reflect that.
> 
> How about we reword to -
> 
>    The PCEP YANG model is specified in [I-D.ietf-pce-pcep-yang]. The
>    YANG models can be augmented to also include the P2MP related
>    parameters.
> 
> Thanks again for your review.
> 
> Regards,
> Dhruv
> 
> Working Copy - https://github.com/dhruvdhody-
> huawei/ietf/blob/master/draft-ietf-pce-rfc6006bis-04.txt
> 
> 
> 
> >
> > _______________________________________________
> > Pce mailing list
> > Pce@ietf.org
> > https://www.ietf.org/mailman/listinfo/pce
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art