[Pce] Rtgdir last call review of draft-farrel-pce-stateful-flags-02

Mike McBride via Datatracker <noreply@ietf.org> Thu, 31 October 2019 00:09 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: pce@ietf.org
Delivered-To: pce@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 0B7D8120289; Wed, 30 Oct 2019 17:09:54 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Mike McBride via Datatracker <noreply@ietf.org>
To: <rtg-dir@ietf.org>
Cc: last-call@ietf.org, pce@ietf.org, draft-farrel-pce-stateful-flags.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.108.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Mike McBride <mmcbride7@gmail.com>
Message-ID: <157248059396.32502.7485483203706927333@ietfa.amsl.com>
Date: Wed, 30 Oct 2019 17:09:54 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/xAwPR3nelTglyMippmTbC6z--fU>
Subject: [Pce] Rtgdir last call review of draft-farrel-pce-stateful-flags-02
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Oct 2019 00:09:54 -0000

Reviewer: Mike McBride
Review result: Has Nits

I have been selected as the Routing Directorate reviewer for this draft. The
Routing Directorate seeks to review all routing or routing-related drafts as
they pass through IETF last call and IESG review, and sometimes on special
request. The purpose of the review is to provide assistance to the Routing ADs.
For more information about the Routing Directorate, please see
http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would
be helpful if you could consider them along with any other IETF Last Call
comments that you receive, and strive to resolve them through discussion or by
updating the draft.

Document: draft-farrel-pce-stateful-flags
Reviewer: Mike McBride
Review Date: Oct. 30 2019
IETF LC End Date: N/A (in preparation for IETF LC)
Intended Status: Standards Track

Summary:

This document is near ready for publication. It has nits that should be at
least considered prior to publication.

Comments:

Great job on the easy to understand draft. I probably don't want to know the
history of why this is an individual draft but I am curious. I'll ask Adrian
over a drink sometime.

Major issues:

No major issues found.

Minor Issues:

No minor issues found.

Nits for your consideration:

Abstract:
"Extensions to the Path Computation Element communications Protocol"
-capitalize "communications" as you do in the Introduction.

4. Compatibility Considerations
..
"It should be noted that common behavior for flags fields is as described by
the updated text presented in Section 3 so many implementations, lacking
guidance from RFC 8231, will still have implemented a consistent and
future-proof approach."

For better readability change to:
"It should be noted that common behavior for flags fields is as described by
the updated text presented in Section 3. Therefore, many implementations,
lacking guidance from RFC 8231, will still have implemented a consistent and
future-proof approach." Or something similar.

Consider removing all instances of the word "so".

thanks,
mike