Re: [quicwg/base-drafts] Fix persistent congestion period calculation (#3289)

Nick Banks <notifications@github.com> Fri, 06 December 2019 17:26 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D122A120086 for <quic-issues@ietfa.amsl.com>; Fri, 6 Dec 2019 09:26:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Drbb2VyG2Vnv for <quic-issues@ietfa.amsl.com>; Fri, 6 Dec 2019 09:26:58 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8A16D12006D for <quic-issues@ietf.org>; Fri, 6 Dec 2019 09:26:58 -0800 (PST)
Date: Fri, 06 Dec 2019 09:26:57 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1575653217; bh=bXbHxf3cKUPr3W5eonpJo46/ChdPfnisiQzeyJrqX4w=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=vJwQNbRD1EwACqO4/ElKeS/L9DRZ2fDYZ6PWYDtx2Zr1eZtkV5UZJ0VIMEzC/mQOp 8nrEaUuNaFXxgiI9MKkCCJyWuX/pJCG+TIhzoAnem3hi3+O/9oWdam0TWi22S9JwMT xN3l6VVGczStEp+rJ6KbFwH+hv34f9kxKBBAUAPM=
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYP3CYGYCZARVTLIVN367A6DEVBNHHB7VUXZ4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3289/review/328347965@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3289@github.com>
References: <quicwg/base-drafts/pull/3289@github.com>
Subject: Re: [quicwg/base-drafts] Fix persistent congestion period calculation (#3289)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dea8f61d4af4_45de3fbd328cd9601269e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Egzdqg0xK9PVWuCaMUr1rFoJA38>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Dec 2019 17:27:00 -0000

nibanks commented on this pull request.



> @@ -735,7 +737,7 @@ illustrate persistent congestion:
 
 The first three packets are determined to be lost when the acknowlegement of
 packet 4 is received at t=8.  The congestion period is calculated as the time
-between the oldest and newest lost packets: (3 - 0) = 3.  The duration for
+between the oldest and newest lost packets: (7 - 0) = 7.  The duration for

Ok, the rich diff in the browser confused me once more. I go back to my original statement. I think the original text is correct.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3289#discussion_r354945957