Re: Transport Draft Comments, mostly about error handling

Martin Thomson <martin.thomson@gmail.com> Mon, 21 August 2017 06:27 UTC

Return-Path: <martin.thomson@gmail.com>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B427E1320BE for <quic@ietfa.amsl.com>; Sun, 20 Aug 2017 23:27:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZpkNjBXA-MDT for <quic@ietfa.amsl.com>; Sun, 20 Aug 2017 23:27:32 -0700 (PDT)
Received: from mail-it0-x22a.google.com (mail-it0-x22a.google.com [IPv6:2607:f8b0:4001:c0b::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6EFC5126B71 for <quic@ietf.org>; Sun, 20 Aug 2017 23:27:32 -0700 (PDT)
Received: by mail-it0-x22a.google.com with SMTP id 76so28060458ith.0 for <quic@ietf.org>; Sun, 20 Aug 2017 23:27:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=YiN8fpSoyqPatYlBzOYhMISk93Ae/y2z4tfrx/C9wcA=; b=LOtWMboyQ9nY1fd1D9Jgtw5zbwrtHeGUzVc/OyfkIRs+NVdJK/JMz98ZyneaU7zoYf ZIJjhIaUZj8sdHQsGlSNxduz1fs8WeZdNGlq/Bc3Qtdk6SWu5JQ2fMEhYi0sYBgOrnhN RAEwvhlN1bTnfkI+yao8oy9IkBD7/TL6ULRHhHymjhA1nZ71o3CpA5eBZqt4ZPrh1v4b oD2TWbLaP0sH/qVx6EG72A19aTC+J08miTflk96UH2RlhY/J63HV/FN6XfG1iRMw7NFA O+6L3shLbaV/bdul3HWCkQ4PWEIVk0QFYjlE6H1gvZXjb96i2Fe06fX2WFXqnVdIFnim 56RA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YiN8fpSoyqPatYlBzOYhMISk93Ae/y2z4tfrx/C9wcA=; b=tmVCn/36CvUdl5tlHYqv6/2F5VH/QVRNS+TTtp26A0GFnFP1wgVnTO7OIVBpfO8uev f3chvhPQ1tdb8Ms3OSFsO/Kd7mA9zERx+z+DI8ZPidqjf05J7zR37V8zK+7ZtnXMxbsN ufKACdzn+pdbpd+ZQ2U/g5g2MBOGp2YfEvQvwG+0v0ESM6uY3ZeXgTdwgfYoEkdUxvgb 8zjeKdnUR5n+fyxxgUgzJq+UYChXuJLNnM+y/B7JRSx7iuzDCiV0fBg0IYWVEhsHKeIN iEv4s+V+iOo+5lFPng6/5Uh92c5zk93FeaKNRBxoIqbQsaEJVLATv8FYg1UYh4gS5f6R cCpQ==
X-Gm-Message-State: AHYfb5j5Y6I+aH6DYacjTt8Q51DYwggiyjXw6+GmrqopjIy0lsrL6z+R idrKuBXk+tI0mobGp0TMXWZTVDsTYQ==
X-Received: by 10.36.253.198 with SMTP id m189mr3539068ith.165.1503296851813; Sun, 20 Aug 2017 23:27:31 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.107.133.37 with HTTP; Sun, 20 Aug 2017 23:27:31 -0700 (PDT)
In-Reply-To: <CAM4esxSRoeXRcKwS5CCWpUC-MrrSWrDM6VXJ0584Meon_ZfDrg@mail.gmail.com>
References: <CAM4esxSRoeXRcKwS5CCWpUC-MrrSWrDM6VXJ0584Meon_ZfDrg@mail.gmail.com>
From: Martin Thomson <martin.thomson@gmail.com>
Date: Mon, 21 Aug 2017 16:27:31 +1000
Message-ID: <CABkgnnUfLvKdnhUcutDxBruSe1F8oXWm9GUrmvoguVYQ8j726w@mail.gmail.com>
Subject: Re: Transport Draft Comments, mostly about error handling
To: Martin Duke <martin.h.duke@gmail.com>
Cc: IETF QUIC WG <quic@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/nWXQg4F81EHg3XxIsPaIJnN2BLo>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Aug 2017 06:27:35 -0000

On 19 August 2017 at 04:37, Martin Duke <martin.h.duke@gmail.com> wrote:
> (1) Section 8.14. Stream Frames for Stream 1 and above MUST NOT be in
> Cleartext packets of any kind.

That should be in the -tls draft (though it will eventually move to -transport).

> (4) Section 12. Error Handling: If a peer initiates an odd stream when it's
> supposed to be even, or vice versa, what kind of error is that? Is it a
> stream error or connection error?

Since all stream opening uses authenticated packets, I think that
connection error is appropriate.  Also, I don't know how to recover
from this situation gracefully, particularly if the numbers collide.
That said, it makes the h2 settings situation bad.

> (5) Section 12.3 Error Codes: For a Frame Error on a STREAM or ACK frame, is
> the last two bytes of the error code the whole flags byte of the packet, or
> just the mask (0xa0, 0xb0) of the frame type?

The entire byte.  Thus, there are many error codes that represent
STREAM frame errors.  (I agree that that could be difficult, and it's
something I'd be happy to see someone open an issue on to track.)