[rtcweb] AD Review: draft-ietf-rtcweb-fec-07

Adam Roach <adam@nostrum.com> Thu, 01 March 2018 23:40 UTC

Return-Path: <adam@nostrum.com>
X-Original-To: rtcweb@ietfa.amsl.com
Delivered-To: rtcweb@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 020CD12704A for <rtcweb@ietfa.amsl.com>; Thu, 1 Mar 2018 15:40:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.89
X-Spam-Level:
X-Spam-Status: No, score=-1.89 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KMmo6YsXd4jw for <rtcweb@ietfa.amsl.com>; Thu, 1 Mar 2018 15:40:44 -0800 (PST)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8FE34126B6D for <rtcweb@ietf.org>; Thu, 1 Mar 2018 15:40:44 -0800 (PST)
Received: from Svantevit.roach.at (cpe-70-122-154-80.tx.res.rr.com [70.122.154.80]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id w21NegOb015691 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 1 Mar 2018 17:40:44 -0600 (CST) (envelope-from adam@nostrum.com)
X-Authentication-Warning: raven.nostrum.com: Host cpe-70-122-154-80.tx.res.rr.com [70.122.154.80] claimed to be Svantevit.roach.at
To: "rtcweb@ietf.org" <rtcweb@ietf.org>, draft-ietf-rtcweb-fec.all@tools.ietf.org
From: Adam Roach <adam@nostrum.com>
Message-ID: <b00a2399-699a-5633-ec61-1c819bae8093@nostrum.com>
Date: Thu, 01 Mar 2018 17:40:42 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtcweb/-eq1zTdzuSfboBKT5fKWy6w_OuE>
Subject: [rtcweb] AD Review: draft-ietf-rtcweb-fec-07
X-BeenThere: rtcweb@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Real-Time Communication in WEB-browsers working group list <rtcweb.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtcweb/>
List-Post: <mailto:rtcweb@ietf.org>
List-Help: <mailto:rtcweb-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Mar 2018 23:40:46 -0000

I have completed my AD review of draft-ietf-rtcweb-fec-07, and found 
only very minor editorial nits, which should be treated as normal last 
call comments.

Due to this document's close relationship with 
draft-ietf-payload-flexible-fec-scheme, I plan to wait until both 
documents are ready to progress before placing draft-ietf-rtcweb-fec 
into IETF Last Call.

Thanks to everyone who contributed to this document over its lifetime.

Nits follow.

---------------------------------------------------------------------------
§2

Since this document uses "should" in non-normative sentences, please use the
RFC 8174 boilerplate.

---------------------------------------------------------------------------
§3.3

    Some audio codecs, notably Opus [RFC6716] and AMR [RFC4867] support

Insert comma before "support"

---------------------------------------------------------------------------
§4.1

    against individual losses, with minimal overhead.  Note that as
    indicated above the built-in Opus FEC only provides single-frame

Insert commas before and after the phrase "as indicated above"

---------------------------------------------------------------------------
§7

    Implementations MAY support additional FEC mechanisms if desired,
    e.g.  [RFC5109].

- Change the comma after "desired" to a semicolon.
- Insert a comma after "e.g."

---------------------------------------------------------------------------


/a