[rtcweb] WGLC Review of draft-ietf-ice-rfc5245bis-12

Harald Alvestrand <harald@alvestrand.no> Mon, 09 October 2017 16:20 UTC

Return-Path: <harald@alvestrand.no>
X-Original-To: rtcweb@ietfa.amsl.com
Delivered-To: rtcweb@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 187DD134682; Mon, 9 Oct 2017 09:20:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.8
X-Spam-Level:
X-Spam-Status: No, score=0.8 tagged_above=-999 required=5 tests=[BAYES_50=0.8] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AyL24gRmfi2Y; Mon, 9 Oct 2017 09:20:26 -0700 (PDT)
Received: from mork.alvestrand.no (mork.alvestrand.no [IPv6:2001:700:1:2::117]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CF6F2134760; Mon, 9 Oct 2017 09:19:59 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mork.alvestrand.no (Postfix) with ESMTP id 5A85B7C0E4B; Mon, 9 Oct 2017 18:19:58 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at alvestrand.no
Received: from mork.alvestrand.no ([127.0.0.1]) by localhost (mork.alvestrand.no [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SMhuUexCNjIM; Mon, 9 Oct 2017 18:19:57 +0200 (CEST)
Received: from [IPv6:2001:470:de0a:1::5ea] (unknown [IPv6:2001:470:de0a:1::5ea]) by mork.alvestrand.no (Postfix) with ESMTPSA id 0A6F37C0D41; Mon, 9 Oct 2017 18:19:57 +0200 (CEST)
To: "ice@ietf.org" <ice@ietf.org>
Cc: "rtcweb@ietf.org" <rtcweb@ietf.org>
From: Harald Alvestrand <harald@alvestrand.no>
Message-ID: <66220024-e08b-aa61-ffe2-3c279c377a34@alvestrand.no>
Date: Mon, 9 Oct 2017 18:19:56 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------18C28708872D5CF21DF03049"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtcweb/z01VGl5pDkXTHboYjwSTGAebqZs>
Subject: [rtcweb] WGLC Review of draft-ietf-ice-rfc5245bis-12
X-BeenThere: rtcweb@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Real-Time Communication in WEB-browsers working group list <rtcweb.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtcweb/>
List-Post: <mailto:rtcweb@ietf.org>
List-Help: <mailto:rtcweb-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Oct 2017 16:20:29 -0000

I have read through draft-ietf-ice-rfc5245bis-12 - both as a generic
reviewer and with the perspective of "does this do what RTCWEB requires".

I believe this document is good enough to publish, but could be improved
somewhat (usually, all documents can).

Most important points:

* The protocol has been designed and revised to be usable with non-media
data, but the introduction and abstract do not reflect this. Expunging
the media bias from the body of the document is probably not worth it,
but the intro and abstract should mention it.
* Security considerations should mention the problem that ICE reveals
addresses that might otherwise remain hidden, and that this is a privacy
concern.
* The document has removed all the SDP specific parts (good), but the
requirements it places on the negotiation mechanism aren’t collectively
documented anywhere. A section describing this would help comprehension
for people developing signalling protocols for use with ICE.
* The definition of “component” talks about a component having one
address. I believe that in current usage, it should be defined to have
an address pair. (non-symmetric RTP is dead).

The rest of my suggested changes are nits, I think.

I enclose the full text of my review as PDF; apart from the stuff above,
I don't think those comments needs much WG discussion. Editor: Please
raise issues if you think some do need it!

Hope this is helpful.

Harald