Re: Last Call: <draft-ietf-rtgwg-yang-rip-06.txt> (A YANG Data Model for Routing Information Protocol (RIP)) to Proposed Standard

"Reshad Rahman (rrahman)" <rrahman@cisco.com> Tue, 05 December 2017 18:51 UTC

Return-Path: <rrahman@cisco.com>
X-Original-To: rtg-bfd@ietfa.amsl.com
Delivered-To: rtg-bfd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 67C1C127868; Tue, 5 Dec 2017 10:51:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.52
X-Spam-Level:
X-Spam-Status: No, score=-14.52 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 52LjVLiBAHBl; Tue, 5 Dec 2017 10:51:34 -0800 (PST)
Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0F93C1243FE; Tue, 5 Dec 2017 10:51:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=8063; q=dns/txt; s=iport; t=1512499894; x=1513709494; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=1j7S4CLrg3F3VBS1fZy6hYj2h0Ydv+v4vrHH0abylyE=; b=KFEP1eD2I/LPFdb0fuZZqlqvkNPJkux6qG3xMV1XgVm2Y+ogzD1LYrUN V7/2buqqroakRxVuWn5suXUeM3EpzLPWxDy/IFeKVR2tp75YClf4681G7 YyRf0gW9b0Rw7hWZ3GbQgvuf62qQywpIz7PYkbVlpqlsh6a9dz4MVC0Dq E=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CQCQCx6SZa/5RdJa1cGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYM9Zm4nB4ZFh1SOXQEdgX2BWoJnAQKSPhSCAQoYDYUWAoVIPxg?= =?us-ascii?q?BAQEBAQEBAQFrKIUiAQEBAQIBAQFsCwwEAgEIEQEDAQEKGgQHDxgLFAMGCAIEA?= =?us-ascii?q?Q0FihsIEAOrd4pbAQEBAQEBAQEBAQEBAQEBAQEBAQEBGAWDSoFgASmBVoFpgyu?= =?us-ascii?q?DM4E7ARIBHwcxhUAFklOQIwKHdI0dghaGEYlfgVKNAYkjAhEZAYE5AR85YWxvF?= =?us-ascii?q?TqCGQEPgweBTniHa4EkAYETAQEB?=
X-IronPort-AV: E=Sophos;i="5.45,364,1508803200"; d="scan'208";a="326986142"
Received: from rcdn-core-12.cisco.com ([173.37.93.148]) by rcdn-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2017 18:51:32 +0000
Received: from XCH-ALN-004.cisco.com (xch-aln-004.cisco.com [173.36.7.14]) by rcdn-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id vB5IpWXW010328 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 5 Dec 2017 18:51:32 GMT
Received: from xch-rcd-005.cisco.com (173.37.102.15) by XCH-ALN-004.cisco.com (173.36.7.14) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 5 Dec 2017 12:51:31 -0600
Received: from xch-rcd-005.cisco.com ([173.37.102.15]) by XCH-RCD-005.cisco.com ([173.37.102.15]) with mapi id 15.00.1320.000; Tue, 5 Dec 2017 12:51:31 -0600
From: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
To: Xufeng Liu <Xufeng_Liu@jabil.com>, "ietf@ietf.org" <ietf@ietf.org>
CC: "draft-ietf-rtgwg-yang-rip@ietf.org" <draft-ietf-rtgwg-yang-rip@ietf.org>, "rtgwg@ietf.org" <rtgwg@ietf.org>, "rtgwg-chairs@ietf.org" <rtgwg-chairs@ietf.org>, "rtg-bfd@ietf.org" <rtg-bfd@ietf.org>, "draft-ietf-bfd-yang@ietf.org" <draft-ietf-bfd-yang@ietf.org>
Subject: Re: Last Call: <draft-ietf-rtgwg-yang-rip-06.txt> (A YANG Data Model for Routing Information Protocol (RIP)) to Proposed Standard
Thread-Topic: Last Call: <draft-ietf-rtgwg-yang-rip-06.txt> (A YANG Data Model for Routing Information Protocol (RIP)) to Proposed Standard
Thread-Index: AQHTbflV2thM+O7rZUyICFCDdM1sVQ==
Date: Tue, 5 Dec 2017 18:51:31 +0000
Message-ID: <1512499882186.96812@cisco.com>
References: <151188659372.12435.1451903543359435950.idtracker@ietfa.amsl.com> <1511974182521.58987@cisco.com>, <CY1PR0201MB08759E21D67482E9851E0F58F1390@CY1PR0201MB0875.namprd02.prod.outlook.com> <1512165964785.84477@cisco.com>, <BN3PR0201MB0867E8226DEE9C74C4C508F4F13D0@BN3PR0201MB0867.namprd02.prod.outlook.com>
In-Reply-To: <BN3PR0201MB0867E8226DEE9C74C4C508F4F13D0@BN3PR0201MB0867.namprd02.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [161.44.212.109]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-bfd/AZs4M9WtseYQx3hhcajppRHRup8>
X-BeenThere: rtg-bfd@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "RTG Area: Bidirectional Forwarding Detection DT" <rtg-bfd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-bfd/>
List-Post: <mailto:rtg-bfd@ietf.org>
List-Help: <mailto:rtg-bfd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Dec 2017 18:51:36 -0000

Hi Xufeng,

Changes below look good. 

As for changing 'enable' to 'enabled', I had checked what OSPF and ISIS were using and in both cases it is 'enable'. But yes I agree it should be consistent.

Regards,
Reshad.  
________________________________________
From: Xufeng Liu <Xufeng_Liu@jabil.com>;
Sent: Tuesday, December 5, 2017 11:31 AM
To: Reshad Rahman (rrahman); ietf@ietf.org
Cc: draft-ietf-rtgwg-yang-rip@ietf.org; rtgwg@ietf.org; rtgwg-chairs@ietf.org; rtg-bfd@ietf.org
Subject: RE: Last Call: <draft-ietf-rtgwg-yang-rip-06.txt> (A YANG Data Model for Routing Information Protocol (RIP)) to Proposed Standard

Hi Reshad,

Thanks for the review comment. Can you please check the following?
Regards,
- Xufeng

> -----Original Message-----
> From: Reshad Rahman (rrahman) [mailto:rrahman@cisco.com]
> Sent: Friday, December 1, 2017 5:05 PM
> To: Xufeng Liu <Xufeng_Liu@jabil.com>;; ietf@ietf.org
> Cc: draft-ietf-rtgwg-yang-rip@ietf.org; rtgwg@ietf.org; rtgwg-chairs@ietf.org;
> rtg-bfd@ietf.org
> Subject: Re: Last Call: <draft-ietf-rtgwg-yang-rip-06.txt> (A YANG Data Model
> for Routing Information Protocol (RIP)) to Proposed Standard
>
> Hi Xufeng,
>
> You are correct, I looked at the wrong version.
>
> If explicit-neighbors feature is not supported, would you want to have the BFD
> client parameters (client-cfg-parms) configured in RIP? Otherwise operator
> needs to look at neighbors discovered and configure parameters under BFD for
> that neighbor. And when a new neighbor shows up, the same thing has to be
> done again.

[Xufeng] Yes. It would be better to have such a capability. Now that a newer version of the BFD model (draft-ietf-bfd-yang-07) have been posted, it would be better to use the  new grouping "client-cfg-parms" and be consistent with other IGPs. Please review if the followings are the proper changes:

  module ietf-rip {
+     import ietf-bfd-types {
+      prefix "bfd-types";
+    }

          container bfd {
            if-feature bfd;
            description "BFD configuration.";
-           leaf enabled {
-             type boolean;
-             default false;
-             description
-               "'true' if BFD is enabled for the interface.";
-           }
+           uses bfd-types:client-cfg-parms;
          }

  }

       +--rw interfaces
       |  +--rw interface* [interface]
       |     +--rw interface                  if:interface-ref
       |     +--rw bfd {bfd}?
-       |     |  +--rw enabled?   boolean
+      |     |  +--rw enable?                     boolean                         <== From grouping client-cfg-parms
+      |     |  +--rw local-multiplier?           multiplier
+      |     |  +--rw (interval-config-type)?
+      |     |     +--:(tx-rx-intervals)
+      |     |     |  +--rw desired-min-tx-interval     uint32
+      |     |     |  +--rw required-min-rx-interval    uint32
+      |     |     +--:(single-interval)
+      |     |        +--rw min-interval                uint32

[Xufeng] BTW. A comment about the leaf "enable" above: in most published models, "enabled" is used instead of "enable". Do you want to make it consistent?

>
> Please see email discussion with OSPF/ISIS YANG authors.
> https://mailarchive.ietf.org/arch/msg/rtg-bfd/KNipAESw8fGKuUKrCxFlhdkRA0Y
>
> Regards,
> Reshad.
>
> ________________________________________
> From: Xufeng Liu <Xufeng_Liu@jabil.com>;
> Sent: Friday, December 1, 2017 4:50 PM
> To: Reshad Rahman (rrahman); ietf@ietf.org
> Cc: draft-ietf-rtgwg-yang-rip@ietf.org; rtgwg@ietf.org; rtgwg-chairs@ietf.org;
> rtg-bfd@ietf.org
> Subject: RE: Last Call: <draft-ietf-rtgwg-yang-rip-06.txt> (A YANG Data Model
> for Routing Information Protocol (RIP)) to Proposed Standard
>
> Hi Reshad,
>
> Can you please double-check the revision 06 of the document? draft-ietf-rtgwg-
> yang-rip-04 used bfd-grouping-base-cfg-parms, and was taken out by draft-ietf-
> rtgwg-yang-rip-05. Please let us know if this is not the case, or we need to do
> something differently.
>
> Thanks,
> - Xufeng
>
> > -----Original Message-----
> > From: Reshad Rahman (rrahman) [mailto:rrahman@cisco.com]
> > Sent: Wednesday, November 29, 2017 11:49 AM
> > To: ietf@ietf.org
> > Cc: draft-ietf-rtgwg-yang-rip@ietf.org; rtgwg@ietf.org;
> > rtgwg-chairs@ietf.org; rtg-bfd@ietf.org
> > Subject: Re: Last Call: <draft-ietf-rtgwg-yang-rip-06.txt> (A YANG
> > Data Model for Routing Information Protocol (RIP)) to Proposed
> > Standard
> >
> > Hi,
> >
> > The RIP YANG model uses bfd-grouping-base-cfg-parms from BFD YANG.
> > That grouping does not exist in latest revision (it has been renamed).
> > Also, as per discussions we had with OSPF/ISIS YANG authors, the
> > grouping which should be used from BFD is client-cfg-parms.
> >
> > Regards,
> > Reshad.
> > ________________________________________
> > From: rtgwg <rtgwg-bounces@ietf.org>; on behalf of The IESG <iesg-
> > secretary@ietf.org>;
> > Sent: Tuesday, November 28, 2017 11:29 AM
> > To: IETF-Announce
> > Cc: draft-ietf-rtgwg-yang-rip@ietf.org; rtgwg@ietf.org;
> > rtgwg-chairs@ietf.org
> > Subject: Last Call: <draft-ietf-rtgwg-yang-rip-06.txt> (A YANG Data
> > Model for Routing Information Protocol (RIP)) to Proposed Standard
> >
> > The IESG has received a request from the Routing Area Working Group WG
> > (rtgwg) to consider the following document: - 'A YANG Data Model for
> > Routing Information Protocol (RIP)'
> >   <draft-ietf-rtgwg-yang-rip-06.txt> as Proposed Standard
> >
> > The IESG plans to make a decision in the next few weeks, and solicits
> > final comments on this action. Please send substantive comments to the
> > ietf@ietf.org mailing lists by 2017-12-12. Exceptionally, comments may
> > be sent to iesg@ietf.org instead. In either case, please retain the
> > beginning of the Subject line to allow automated sorting.
> >
> > Abstract
> >
> >
> >    This document describes a data model for the Routing Information
> >    Protocol (RIP).  Both RIP version 2 and RIPng are covered.
> >
> >
> >
> >
> > The file can be obtained via
> > https://datatracker.ietf.org/doc/draft-ietf-rtgwg-yang-rip/
> >
> > IESG discussion can be tracked via
> > https://datatracker.ietf.org/doc/draft-ietf-rtgwg-yang-rip/ballot/
> >
> >
> > No IPR declarations have been submitted directly on this I-D.
> >
> >
> > The document contains these normative downward references.
> > See RFC 3967 for additional information:
> >     draft-bjorklund-netmod-rfc7223bis: A YANG Data Model for Interface
> > Management (None - IETF stream)
> >     draft-ietf-netmod-revised-datastores: Network Management Datastore
> > Architecture (None - IETF stream)
> >     draft-acee-netmod-rfc8022bis: A YANG Data Model for Routing
> > Management (NDMA Version) (None - )
> >     draft-bjorklund-netmod-rfc7277bis: A YANG Data Model for IP
> > Management (None - IETF stream)
> >     draft-ietf-ospf-yang: Yang Data Model for OSPF Protocol (None -
> > IETF stream)
> >
> >
> >
> > _______________________________________________
> > rtgwg mailing list
> > rtgwg@ietf.org
> > https://www.ietf.org/mailman/listinfo/rtgwg