Re: Yangdoctors early review of draft-ietf-bfd-unsolicited-01

Mahesh Jethanandani <mjethanandani@gmail.com> Mon, 19 August 2019 18:45 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: rtg-bfd@ietfa.amsl.com
Delivered-To: rtg-bfd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A380F120091; Mon, 19 Aug 2019 11:45:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NUBXZnOo4S8H; Mon, 19 Aug 2019 11:45:12 -0700 (PDT)
Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2C373120059; Mon, 19 Aug 2019 11:45:09 -0700 (PDT)
Received: by mail-pl1-x62b.google.com with SMTP id y8so1378903plr.12; Mon, 19 Aug 2019 11:45:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=AJkzZsT8qMgSY32ECD81JPe/2JRwxa63i4fzZlQ3Fkk=; b=gD9S/xV5cVbzao3kyDVK3+jTB2SjS+Zr7Sw1Uw4PgkhnOyfC6Q0C62jF2/pnK5N3ga cNDn4OCiFz9JHfOeD6OpkmjqsMIUG3A4oB5ysHsQz4VC+xrzX4pUx5TS7o9XrstpZKrL jFBxfVuX4blywe7Rz2Du7Nz97y7ti4oe68n4qxNtTZjmrsMSm1GA+yL4xg/RbB9PSwyk 4dKbpU9SRgUWwGx4KmIj2O0CxtQHT2nWnJSCtBl8wz1g7GUGCXwUNsv8GIZ91BZQpHjM O1rnw8Q1A8L4AQMBewFAQdkuS966eDRaVkB8m8clfUZ0bgiBQjkFvDcPEHZyRhBh3Rr0 hwQg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=AJkzZsT8qMgSY32ECD81JPe/2JRwxa63i4fzZlQ3Fkk=; b=iSw5qY+OCNQrVGvq7gPkA4087S3+4IU912OkHAYM7OefVVDESl54xes2ocmwikQG74 G3RmHusBubkCgXun1jVpWn2JAA7RBl0yYS+5ghQ3fiG6jtXZT/m27v8g69xxVq/N6MnX uTmY+URjQuUSLNmR5WqPsYpVi7MB1HhQ5evN7Cl+DweEoCfHzHJw3D8YM64jyrRvkm0M qf5ohnon1c0x8YaYuJZYgVyzp1DXUn33mDiIr1luzgA1Jw/rEysRMjsgiBkODiamIpuH hk5Va4MHyyQPQyXnXr9IUZ6AXfsa2h3F+WLAi1IFITHyFczUSElTk4H/0v8rfAzhHoYx nn0g==
X-Gm-Message-State: APjAAAU7E1Iro7hG8YwS1AKz2QHAAWQsMJNL5BDp2OzyKt8WTss6dmUk 02X/+dsGualzBIn2CCd8X/KZk5Jl5iE=
X-Google-Smtp-Source: APXvYqzOfC5xfbaOEToKwJRvIWn8A2Ryj0lWAVcpBT0G1OldfRen12nfEp2kxLpjqJPA3DU1nRKgDQ==
X-Received: by 2002:a17:902:988d:: with SMTP id s13mr15633237plp.139.1566240308299; Mon, 19 Aug 2019 11:45:08 -0700 (PDT)
Received: from [10.33.122.240] ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id 65sm24039566pff.148.2019.08.19.11.45.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Aug 2019 11:45:06 -0700 (PDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Subject: Re: Yangdoctors early review of draft-ietf-bfd-unsolicited-01
From: Mahesh Jethanandani <mjethanandani@gmail.com>
In-Reply-To: <156621414936.19813.853283734958376284@ietfa.amsl.com>
Date: Mon, 19 Aug 2019 11:45:05 -0700
Cc: YANG Doctors <yang-doctors@ietf.org>, "rtg-bfd@ietf. org" <rtg-bfd@ietf.org>, draft-ietf-bfd-unsolicited.all@ietf.org, ietf@ietf.org, draft-ietf-bfd-yang@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <0CD4CB48-9382-4724-A5A6-A7B0DE7D7D57@gmail.com>
References: <156621414936.19813.853283734958376284@ietfa.amsl.com>
To: =?utf-8?Q?Martin_Bj=C3=B6rklund?= <mbj@tail-f.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-bfd/yHdWRMES8FRf9dnHpVOAARpD1BA>
X-BeenThere: rtg-bfd@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "RTG Area: Bidirectional Forwarding Detection DT" <rtg-bfd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-bfd/>
List-Post: <mailto:rtg-bfd@ietf.org>
List-Help: <mailto:rtg-bfd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Aug 2019 18:45:14 -0000

[Adding the authors of BFD YANG module]

Martin brings up a good point. But since the document that contains ietf-bfd-types is sitting in RFC Ed Queue, this will have to go into a bis document.

Chairs, could you create a bfd-wg in GitHub for us to track this as an issue to be fixed as part of a bis document?

> On Aug 19, 2019, at 4:29 AM, Martin Björklund via Datatracker <noreply@ietf.org>; wrote:
> 
> Reviewer: Martin Björklund
> Review result: Ready with Nits
> 
> I have reviewed this document from a YANG model perspective only.
> 
> My only comment is actually for a grouping defined in ietf-bfd-type, but used
> in this module.  There is a choice "interval-config-type":
> 
>  +--rw unsolicited {bfd-unsol:unsolicited-params-global}?
>       +--rw enable?                           boolean
>       +--rw local-multiplier?                 multiplier
>       +--rw (interval-config-type)?
>          +--:(tx-rx-intervals)
>          |  +--rw desired-min-tx-interval?    uint32
>          |  +--rw required-min-rx-interval?   uint32
>          +--:(single-interval) {single-minimum-interval}?
>             +--rw min-interval?               uint32
> 
> This choice is not mandatory and doesn't have a default case, so the question
> is what happens if no nodes from the choice has been configured?   I would
> expect the choice to have a default case (but this then would apply to
> ietf-bfd-types, not this document.)
> 
> 

Mahesh Jethanandani
mjethanandani@gmail.com