[RTG-DIR] FW: Rtgdir review: draft-ietf-pce-wson-rwa-ext-08

Ravi Singh <ravis@juniper.net> Tue, 23 October 2018 01:46 UTC

Return-Path: <ravis@juniper.net>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 79987130DEB for <rtg-dir@ietfa.amsl.com>; Mon, 22 Oct 2018 18:46:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.17
X-Spam-Level:
X-Spam-Status: No, score=-1.17 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, KHOP_DYNAMIC=1.999, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SvenWiNsKa4w for <rtg-dir@ietfa.amsl.com>; Mon, 22 Oct 2018 18:46:56 -0700 (PDT)
Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1532B130DEA for <rtg-dir@ietf.org>; Mon, 22 Oct 2018 18:46:56 -0700 (PDT)
Received: from pps.filterd (m0108160.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w9N1ik6C031306 for <rtg-dir@ietf.org>; Mon, 22 Oct 2018 18:46:55 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=from : to : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=PPS1017; bh=vrD7EeXOB0ESZcknGv08pFQ6pkwNRuKXCJejfD47Uhk=; b=VmL0FBzPn2fZ6PJvG7Q1dqGhtvS4+QjcujPeEPmznaAzlraev/3NWX/lWxHdFLh0Pg7D DfNwliwhgmHln9yCcreroWHb55QDfgln++yLexsvGe7x+YCMXFkPHy17HM0PTf/6onoZ pfKZl1syIP93jh0obg2DV5HLYf7T6YzhO1U3yrqQgrflFy6apBV6O+l7ntjE30hXHQw3 HEW8+csuUjP6VJsfxSW6TidfR23NejnxE8WRPTnM6YFrjzX76BOKjxBe11EGOoom92Qz g1+fr865aOiMJQGsn/B5a5T77SpSasoFDH/Q0Awd1W2GpwrqIwEZ5U8Cg/eLHp35WCgv ag==
Received: from nam01-sn1-obe.outbound.protection.outlook.com (mail-sn1nam01lp0117.outbound.protection.outlook.com [207.46.163.117]) by mx0b-00273201.pphosted.com with ESMTP id 2n9hxqh9ak-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for <rtg-dir@ietf.org>; Mon, 22 Oct 2018 18:46:55 -0700
Received: from BN7PR05MB4242.namprd05.prod.outlook.com (52.133.222.151) by BN7PR05MB4225.namprd05.prod.outlook.com (52.132.220.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.14; Tue, 23 Oct 2018 01:46:52 +0000
Received: from BN7PR05MB4242.namprd05.prod.outlook.com ([fe80::c88f:e94d:72ea:66cc]) by BN7PR05MB4242.namprd05.prod.outlook.com ([fe80::c88f:e94d:72ea:66cc%2]) with mapi id 15.20.1273.014; Tue, 23 Oct 2018 01:46:52 +0000
From: Ravi Singh <ravis@juniper.net>
To: "rtg-dir@ietf.org" <rtg-dir@ietf.org>
Thread-Topic: Rtgdir review: draft-ietf-pce-wson-rwa-ext-08
Thread-Index: AdRqXsyBoMliR653TGOUZVNa41ss7QAE23Jw
Date: Tue, 23 Oct 2018 01:46:52 +0000
Message-ID: <BN7PR05MB42423B365F4B09B219AFABAEABF50@BN7PR05MB4242.namprd05.prod.outlook.com>
References: <BN7PR05MB42422FAD800FFB5ABCD48A15ABF40@BN7PR05MB4242.namprd05.prod.outlook.com>
In-Reply-To: <BN7PR05MB42422FAD800FFB5ABCD48A15ABF40@BN7PR05MB4242.namprd05.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [66.129.239.13]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; BN7PR05MB4225; 6:hafj55AnWpA/A37ND6f4pboy29R5wLgoL9PImVEH+4ZanbUGh4U31StxwaN7zEqX7qlvzk1O/cCexHPdju0cO0T/qpXhNiqvdFb5Pqzhn7v3uQ82wH72pYddDcbcc30n/hg1HFB3huhcvCWAfsQievIjBFH5YGQzN0aRl6i5hWiYZiv9PsOJfa1WIJVb7+rIM6jSdZsWgv5PM7cnJqIaXMbgWe0I7Xw9ZP41VWniiwH7iu9EBuHq6PIvNbWH0bb4urHWZvXyTE4ukXhgS39uO8w6Lz6UoXAfHxAMzYOjf2prpMkCY8WcpWaLMAX1ZgAor1w2kQT5k0yWwi9gO5h7rrM7/1X4KLZv8tIOkDMdctQ6is2omBPQRZenbiYlnXpo00tixlnAm2mlw/i/6+ofsPsFbma2TdbAkv+chlWczJXfwR67GVqxhSqTXLphfhpqbupr5oXsFjt+aY2OMUjOGg==; 5:snRtM3cPylgLX5qiNLyx9h1hlS+Kl7i0LH6Cxdj00sReW4qWHCLUNbvfydIhXR51Vk2w/JIz9UOWFOrw8I6qXQqLtnqLSfBaaStMg9okxn8ImqNbmtog8gNJDa/Qrva8nkd/Ba232K7sN1a3ZDJ4HAGHpsReT/P3VsibiInSIsE=; 7:An9pBfL/EmaB0ucEaqydgzjRSiquwvqyZdFfNdtzrPK4K2DpqcSS4X6ezs1ceJ4JuVDk+RT5Xm3SG8Vm+6q9Y9Hsv7YPL9VTVAvXN+ngtxfpGBHlV8ZeFdMc1ISYcX0bLn9XDDC188UTPs25QH3otg==
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: 76045f0c-c863-45ec-d42d-08d6388967ed
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:BN7PR05MB4225;
x-ms-traffictypediagnostic: BN7PR05MB4225:
x-microsoft-antispam-prvs: <BN7PR05MB4225DBAF72061C3CEF611365ABF50@BN7PR05MB4225.namprd05.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(21748063052155)(28532068793085)(190501279198761)(227612066756510);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:BN7PR05MB4225; BCL:0; PCL:0; RULEID:; SRVR:BN7PR05MB4225;
x-forefront-prvs: 0834BAF534
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(346002)(376002)(39860400002)(136003)(366004)(189003)(199004)(606006)(2900100001)(76176011)(5660300001)(7696005)(33656002)(6916009)(8676002)(81166006)(71190400001)(81156014)(102836004)(5630700001)(8936002)(71200400001)(53546011)(6506007)(316002)(99286004)(6436002)(236005)(66066001)(5640700003)(2473003)(54896002)(6306002)(478600001)(9686003)(6116002)(3846002)(55016002)(790700001)(53936002)(14454004)(229853002)(2351001)(2906002)(74316002)(486006)(97736004)(7736002)(86362001)(476003)(11346002)(26005)(2501003)(6346003)(5250100002)(106356001)(256004)(14444005)(25786009)(186003)(105586002)(446003)(68736007); DIR:OUT; SFP:1102; SCL:1; SRVR:BN7PR05MB4225; H:BN7PR05MB4242.namprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: juniper.net does not designate permitted sender hosts)
x-microsoft-antispam-message-info: qaW4vg39PJUulpU1Hi21ZrQlG53hzrTvUw4XjiWP+LkrlphfsHdqpSu1kQS7oQf5icgNLLNEPnS/873Cs6by1sFyHdHhY6DHYgeuch8FtpG6ylTSxhqMRU7T1PpxwpwLu+7cBP5Y6bzuOZOD4aAZj/GLbVjx2GqmIxxwiM4iB5ErwjaKM36yMCss8whXoC5wRXzfDXVjcQ5iQnRbqZPskAoQn8L9IrcibHe4HkEbzYhBR7pD6y454NDUdg9HuA6yz+KlOVShRX+5IAli4t0fEHZXo7K0t3d/o5wbShDy1e2FPAgr1GAUM7Z+QxGgFLrJQJxPySa0sFBVjkURPAiXrZL+ylIojpUKMKjc1CL6qAY=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_BN7PR05MB42423B365F4B09B219AFABAEABF50BN7PR05MB4242namp_"
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 76045f0c-c863-45ec-d42d-08d6388967ed
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2018 01:46:52.2296 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR05MB4225
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-10-22_15:, , signatures=0
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810230014
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/yvg2fz7MW8GZAz7QuKfpSKdY1kA>
Subject: [RTG-DIR] FW: Rtgdir review: draft-ietf-pce-wson-rwa-ext-08
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Oct 2018 01:47:00 -0000

Meant to copy rtg-dir as well.
Regards


From: Ravi Singh
Sent: Monday, October 22, 2018 4:45 PM
To: rtg-ads@ietf.org
Cc: pce@ietf.org; draft-ietf-pce-wson-rwa-ext@ietf.org
Subject: Rtgdir review: draft-ietf-pce-wson-rwa-ext-08

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document: draft-ietf-pce-wson-rwa-ext-08
Reviewer: Ravi Singh
Review Date: 10/22/2018
Intended Status: Standard Track

Summary:
This document is basically ready for publication, but has nits that should be considered prior to publication.

Comments/Nits:
The draft is overall easy to understand.
However, there is a need to address some nits and make minor changes for better readability.

Specific details below:
1.       Section 3: The following text could elaborate the function/properties of a 3R regenerator in a little bit more detail.
"On the other hand, translucent networks include 3R regenerators that are sparsely placed." :
2.       Figure 1:  "SwCap": this could use some more info in the text somewhere.
3.       Section 4:
a.       " the PCEP extensions that are going to be specified in this document based on
   this architecture." ->
" the PCEP extensions that are going to be specified in this document are based on
   this architecture."
4.       Section 4.1:
a.        text says that the WA object must be after the Endpoints object and does not say anything about ordering w.r.t. any following objects. It would be desirable to make an explicit statement either saying that ordering w.r.t. the other following objects is irrelevant, since the text is implying that that is the case.
b.      The term "explicit label control (ELC)" seems to have been coined in this draft and does not exist in RFC4003: while it logically follows from RFC4003, defining a new term in this doc should refer to lingo used in RFC4003 to enable better readability.
5.       Section 4.3:
a.       "Note that the Action field can be set to 0 when unnumbered link identifier is used." : not clear. Please clarify and this sentences belongs in a paragraph of its own to avoid entanglement with "action bits" description.
b.      "See Section 4.2.1. for the encoding of the Link Identifiers Field." : 4.2.1 -> 4.3.1
c.       "See Section 4.2.1. for Link Identifier encoding and Section 4.2.2. for the Wavelength Restriction Field encoding, respectively." -> 4.3.1 and 4.3.2
6.       Section 4.3.1:
a.       IPv4 address and IPv6 address as show in the figure do not align correctly as per the lengths: kindly fix.
b.      4.3.2: "section 2.6," hyperlink links to this draft rather than to RFC7579 as intended. Same for other sections referred in this section.
7.       Section 5:
a.       "Reply for wavelength allocation as discussed" -> "Reply for wavelength allocation request as discussed'
b.      4.2.1/4.2.2 -> 4.3.1/4.3.2
8.       Section 8.2/8.5/8.6: is this IANA request really necessary since an existing subTLV format is being re-used?


Regards
Ravi