[RTG-DIR] Rtgdir telechat review of draft-ietf-pim-source-discovery-bsr-11

Min Ye <amy.yemin@huawei.com> Wed, 31 January 2018 01:48 UTC

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Min Ye <amy.yemin@huawei.com>
To: rtg-dir@ietf.org
Cc: draft-ietf-pim-source-discovery-bsr.all@ietf.org, ietf@ietf.org, pim@ietf.org, dimitri.papadimitriou@nokia-bell-labs.com
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <151736328522.7871.1037222625991438704@ietfa.amsl.com>
Date: Tue, 30 Jan 2018 17:48:05 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/OnoaOfrGKZ9G_0Zxo4onHPiQ-9k>
Subject: [RTG-DIR] Rtgdir telechat review of draft-ietf-pim-source-discovery-bsr-11

Reviewer: Papadimitriou Dimitri
Review result: Has Nits

Couldn't find the template for experiment drafts, but I think this kind of
documents deserve its specific template

Summary:

Points to be clarified are related to

1.the flooding boundary. The document refers to PIM domain defined in RFC 4601

" A domain in this context is a contiguous set of routers that all implement
PIM and are
   configured to operate within a common boundary."

And states " PFM messages are generally forwarded hop by hop to all PIM
routers."

what now defines a PIM domain: the PFM flooding boundary or the PIM execution
domain.

2. Modified TLV (statement " Some TLVs may be omitted or modified in the
forwarded message." - example a boundary router changes the Src Address in the
GSH TLV to its own address - is that allowed/expected ? actually the document
doesn't explain or justify the need to "modify" TLV in forwarded messages.

3. Section 4.2 states

   "In order to meet the timing requirements, sending of the message may
   have to be delayed a small amount of time."

   Quantify "small amount of time"

Editorial:

First paragraph first sentence: add reference to PIM-SM

Second paragraph fifth sentence: add reference to SSM

Last paragraph

o) Refers to "parameters" please differentiate so-called architectural
constants from configurable parameters. Cf.RFC 2328 for a good example.

o) Suggest to write last paragraph as numbered points to facilitate their
clearing as more experience from the field is being obtained.

Dimitri

[RTG-DIR] Rtgdir telechat review of draft-ietf-pi… Min Ye
Re: [RTG-DIR] Rtgdir telechat review of draft-iet… Stig Venaas