Re: [RTG-DIR] RtgDir review: draft-ietf-idr-bgp-ls-node-admin-tag-extension-01
Pushpasis Sarkar <pushpasis.ietf@gmail.com> Thu, 29 June 2017 05:26 UTC
Return-Path: <pushpasis.ietf@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9070912025C; Wed, 28 Jun 2017 22:26:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.698
X-Spam-Level:
X-Spam-Status: No, score=-2.698 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TNZ4FbB6BMvU; Wed, 28 Jun 2017 22:26:41 -0700 (PDT)
Received: from mail-yw0-x231.google.com (mail-yw0-x231.google.com [IPv6:2607:f8b0:4002:c05::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EDD80127977; Wed, 28 Jun 2017 22:26:37 -0700 (PDT)
Received: by mail-yw0-x231.google.com with SMTP id l21so24194890ywb.1; Wed, 28 Jun 2017 22:26:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=gP+o5Ocn368I9f9ZUT8KostoHuwiHMOFixx4xuOwJWo=; b=s2XbGQxMyClgoMypKWsPYBEBTU+V4cOZhPSqABmZRC2C2yqWnjDgsKJYftzZ8viOjh 5nS0xaz4dwI9kKcC6CXunRVmuMOSLt0/CTGTJ6PbAv5B09XzUcJnSbnC8fKN8FbyOJoF wUMG1T398bNP44/YVgZQkWIYpNkzO7nAdkzTUbiSDQaEw5MpevmwcOE9TKMu2KLheg7e 03Zx2lsXvH1yBh8qA9vymT7qZn/tFlrjhT560Pxm+xHBWSGl/NdyO8FltZEMmxbUNXDt RGGDXD45g+NhW/hMcY7YivO3AY9brLe6b0FS9yexyTaYxAAzO56/GeMiIUVbRY+zVcJz j+BA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=gP+o5Ocn368I9f9ZUT8KostoHuwiHMOFixx4xuOwJWo=; b=IC29b3/3OxTj4Gl36WHUanW4u87dvKBOgXWl/h1AyLp3kIOWUtdIGjQhjoypHfFZRz VSCrvIiy3Tw4b0ec653nlUL/lkY2Rh6rFxoVrudoTM2qbcK1jGxhR0L3QeDM17WdzueA Blcl3B0y14z8uw9gEG516oGp+AnVlPlZSC97ZvDUnBZc9MMbioS3GVJNbZgTaNppmggp dubyR3YtYMKjmvtFg/p2nIXU7WYYJ3kD3SIrsCP3ruW9bUBFEP+xyG38zC6czi1e4NBl Kp+60LcUE0P9h7P0FGrw10qfbCLL3VGY8Waj0Gzu84tiXVhuJiy+PuO/4DAqaXnDi31W sEHA==
X-Gm-Message-State: AKS2vOyOSbhFJCAULZzD8ThjUo5BI3Q9Qk7G9znBm/R28FL7mNzc8sWg oCq9cjOOvB/OZI9WNP2zZpppH65qYA==
X-Received: by 10.129.72.17 with SMTP id v17mr1401219ywa.160.1498713997215; Wed, 28 Jun 2017 22:26:37 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.83.78.197 with HTTP; Wed, 28 Jun 2017 22:26:36 -0700 (PDT)
In-Reply-To: <a60975bbd3774d4cb4041ef0d005f642@XCH-ALN-001.cisco.com>
References: <a60975bbd3774d4cb4041ef0d005f642@XCH-ALN-001.cisco.com>
From: Pushpasis Sarkar <pushpasis.ietf@gmail.com>
Date: Wed, 28 Jun 2017 22:26:36 -0700
Message-ID: <CAEFuwkgtYbvHQdRUJb3jmFgq3+dtfJ+ERdpgB8aeKXryVBYYTA@mail.gmail.com>
To: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
Cc: "idr-ads@ietf.org" <idr-ads@ietf.org>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-idr-bgp-ls-node-admin-tag-extension.all@ietf.org" <draft-ietf-idr-bgp-ls-node-admin-tag-extension.all@ietf.org>, "idr@ietf. org" <idr@ietf.org>
Content-Type: multipart/alternative; boundary="001a114dd1a26c9b960553128bbb"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/vVrui1ssr1ar-R1H3X9K53ys22k>
Subject: Re: [RTG-DIR] RtgDir review: draft-ietf-idr-bgp-ls-node-admin-tag-extension-01
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jun 2017 05:26:44 -0000
Hi Les, Thanks a lot for the review comments. I will reply back addressing your comments soon. Thanks and regards -Pushpasis On Tue, Jun 27, 2017 at 11:37 PM, Les Ginsberg (ginsberg) < ginsberg@cisco.com> wrote: > Hello, > > I have been selected as the Routing Directorate reviewer for this draft. > The Routing Directorate seeks to review all routing or routing-related > drafts as they pass through IETF last call and IESG review, and sometimes > on special request. The purpose of the review is to provide assistance to > the Routing ADs. For more information about the Routing Directorate, please > see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir . > > Although these comments are primarily for the use of the Routing ADs, it > would be helpful if you could consider them along with any other IETF > comments that you receive, and strive to resolve them through discussion or > by updating the draft. > > > Document: draft-ietf-idr-bgp-ls-node-admin-tag-extension-01 > Reviewer: Les Ginsberg > Review Date: June 27, 2017 > Intended Status: Standards > > Summary: The document is of modest scope - covering definition of BGP-LS > codepoints for a relatively new IGP attribute (Node Admin Tags). > While I found nothing which I would consider a major issue, there are a > number > of places where the text lacks clarity. I think addressing these areas > would > greatly improve the quality of the draft. > > > Major Issues: None > > Minor Issues: > > Section 1 Introduction > > The acronym LSDB is not defined. > > Figure 1 > > I have a personal dislike for duplicating text/pictures from another > spec when that spec could simply be referenced. There are only two > possible outcomes: > > 1)The duplicated text is redundant (best case) > 2)The text differs somewhat from the original leading to possible > unintentional misinterpretations. > > Suit yourself on this comment - but I would prefer the duplication be > omitted. > > Section 2 First paragraph > > You refer to "sub-TLV" but that reference is unclear and ambiguous. > IS-IS uses a sub-TLV of Router Capability to advertise tags, but OSPF > uses a TLV of Router Info LSA. > What seems most relevant here is that you are defining a new Attribute > TLV for Node NLRI. > > Section 3 Second paragraph > > I do not know what the paragraph is trying to say, nor do > I know what the "TBD" in columns 4 and 5 in the following Table 1 is > meant to reference. If you are simply trying to describe the source > of the info advertised by the new BGP-LS Node attribute then you should > rewrite the above paragraph and in the figure below show: > > IS-IS 242/21 > OSPF RI-LSA/10 > > Section 3.1 > > A description of where in the Node NLRI the area/level information can be > found > (from RFC 7752) would be helpful. > > > Section 3.1 Penultimate Paragraph > > As TAGs with "global" scope will be advertised by the IGP multiple > times (once per area/level) I assume you are asking BGP-LS advertisements > to reduce these multiple occurrences to a single occurrence? More > explicit language on that point would be helpful. > > Section 3.1 Last paragraph > > I recognize this statement regarding policy being used to filter what is > advertised is consistent with RFC 7752. But it would also be good to > include > a statement like: > > "Definition of such a policy is outside the scope of this document." > > Nits: Please see attached diff file with some editorial corrections. >
- [RTG-DIR] RtgDir review: draft-ietf-idr-bgp-ls-no… Les Ginsberg (ginsberg)
- Re: [RTG-DIR] RtgDir review: draft-ietf-idr-bgp-l… Pushpasis Sarkar
- Re: [RTG-DIR] RtgDir review: draft-ietf-idr-bgp-l… Pushpasis Sarkar
- Re: [RTG-DIR] RtgDir review: draft-ietf-idr-bgp-l… Les Ginsberg (ginsberg)
- Re: [RTG-DIR] RtgDir review: draft-ietf-idr-bgp-l… Pushpasis Sarkar
- Re: [RTG-DIR] RtgDir review: draft-ietf-idr-bgp-l… Pushpasis Sarkar
- Re: [RTG-DIR] RtgDir review: draft-ietf-idr-bgp-l… Susan Hares