[RTG-DIR] RtgDir Review: draft-ietf-spring-sr-yang-28
Tal Mizrahi <tal.mizrahi.phd@gmail.com> Tue, 08 December 2020 11:52 UTC
Return-Path: <tal.mizrahi.phd@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 346573A0C3A; Tue, 8 Dec 2020 03:52:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IA7CS3iqRTf5; Tue, 8 Dec 2020 03:52:22 -0800 (PST)
Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DBD2B3A0C38; Tue, 8 Dec 2020 03:52:21 -0800 (PST)
Received: by mail-wm1-x331.google.com with SMTP id d3so1849700wmb.4; Tue, 08 Dec 2020 03:52:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=RgwFfSNn6LNGzncG/Y9+lRm7eQMenEcKzxIH3g029+w=; b=GmEJ+T019RYAHRHwMwUnLul3FhdXrU9W8AyWenYF9fjSvfmd066yikEfaDRvBP7YvO fOMS+j475UE4zc9N7hctvJantucgO66ef/dExlMhvWR8nIYpkczsjDR/phJYcZYITQ0x mHyLziIvcgu3JkuVfZe2+HyWYOYG6Sa4/pglpD9PSVp5gwDgT0v0AFpPIfFUO6PLMbWy 3Ad2jRW4svUSS0xR3kiY26Fzbz/jn5HuukuCaaj9WBhJCITAMnVZlXvcVMa4Am5a/TUh 1WBy8WjYy3ii2v5YY3xPm7DnQdFskr836JD3FDYKb5iy/hDdSvAJjyImKDyAyziKBQWz 4nmQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=RgwFfSNn6LNGzncG/Y9+lRm7eQMenEcKzxIH3g029+w=; b=O3dqffMtbNbiTEejyc+q6AQ0/zHQxRyKZAOguLqvi8vluaVdGo3bJRNXZYKG/DmRrh EHOcJes3bh56JyEbI4/Fhi9u9cQNHzA0fjpcyUffS3D4/0Q+XA7Oi24Pyg0L0VRtJMgF yKJ1oQorhxrx6Qh7y4NxY3oLS6eo1KsDdZpmIXthPwNe+R7dE9hW+xNmaR8tXhBTTE2Q tT3u9sNO6MXQNcru24dqjrX5lh5aaV3sEyZXgdI4w15IHHFzFvCQ627AqrydeUK3zb6G n1e2+aumy48ZLTgNsUXJE/Ois2nq82lCzOigALSCDPW4GxgN70WQjZwf9YoKRFCExzx+ OiZw==
X-Gm-Message-State: AOAM532uop/R2pnbxl5sB35HQZ8bUSJVhh6JGa+lIBfOFqL9waI6qDf9 +UjCWe50+CQiUBCsoURiz3NOpUjseWjmi36xoVrMrUSxbqFPRA==
X-Google-Smtp-Source: ABdhPJyPJtLQX+VXoTBL7yimZ/+v/Iv25QSoCL/C94X4bXrlEnANKL30qQ8BD3jJQ7mKpTle/129Bpa4zph8FLCC0aI=
X-Received: by 2002:a1c:bb07:: with SMTP id l7mr3574315wmf.9.1607428339788; Tue, 08 Dec 2020 03:52:19 -0800 (PST)
MIME-Version: 1.0
From: Tal Mizrahi <tal.mizrahi.phd@gmail.com>
Date: Tue, 08 Dec 2020 13:52:08 +0200
Message-ID: <CABUE3XmPp_MuAbCcA5EkUveDtUjkL8ovf5Sr_6+ebqpPL6xOmg@mail.gmail.com>
To: rtg-ads@ietf.org, draft-ietf-spring-sr-yang@ietf.org
Cc: rtg-dir@ietf.org, spring@ietf.org, last-call@ietf.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/xdILb1X0SikpI6Xdd-UEiyHRxp0>
Subject: [RTG-DIR] RtgDir Review: draft-ietf-spring-sr-yang-28
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Dec 2020 11:52:24 -0000
Hello, I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft. Document: draft-ietf-spring-sr-yang-28 Reviewer: Tal Mizrahi Review Date: 08-Dec-2020 Intended Status: Standards Track Summary: I have some minor concerns about this document that I think should be resolved before publication. Comments: The document defines a YANG data model for MPLS segment routing. The document is in good shape, and I believe it is almost ready for publication. My comments are mainly about the need for a clear definition of the scope of the document. While these comments do not require major changes in the document, a bit of rephrasing and clarifying text will go a long way here. Issues: - The document is focused on SR-MPLS, while RFC8402 discusses both SR-MPLS and SRv6. I am sure there is a good reason for this, but it is important to point out at the very beginning of the document that it does not cover SRv6 and preferably also the reason for this. - It is important to clarify the scope of the YANG models in the introduction: do they refer only to SR routers, or also to SR ingress/egress nodes? - The Common Types module is mentioned for the first time in Section 8. It would be appropriate to mention it and describe its purpose in Section 3. - In the following text it would be more accurate to replace: "with Segment Routing (SR)." ==> "with MPLS Segment Routing (SR)." "This augments routing data model (RFC 8349) with Segment Routing (SR).";
- [RTG-DIR] RtgDir Review: draft-ietf-spring-sr-yan… Tal Mizrahi
- Re: [RTG-DIR] RtgDir Review: draft-ietf-spring-sr… Yingzhen Qu
- Re: [RTG-DIR] RtgDir Review: draft-ietf-spring-sr… Tal Mizrahi
- Re: [RTG-DIR] RtgDir Review: draft-ietf-spring-sr… Yingzhen Qu