AD review of draft-ietf-rtgwg-yang-rip-04

[Alia Atlas <[e-mail]>]

As is customary, I have done my AD review of draft-ietf-rtgwg-yang-rip-04.
First, I would like to thank the authors, Xufeng, Prateek, and Vikram, as
well as the WG for their work on this document.

My one major issue is that this does not conform to the NMDA guidelines -
where augmenting -state models is not preferred.  It is quite acceptable to
have that in an appendix, if there are implementations. I do see the
shepherd's write-up indicates a partial implementation exists.
There is some tooling to help convert a model to conform to NMDA; I've cc'd
Rob Wilton, who was working on that.

I also have some questions.

1) For the prefix-set-ref, I don't see any information about what the
string should contain.

2) For the route-policy-ref, I don't see any information about what the
string should contain.

Nits:
a) p.26:"choice auth-type-selection {
                 description
                   "Specify the authentication scheme.
                    The use of the key-chain reference here is
                    designed to align with other proposed protocol
                    models.";"
   Since the key-chain model is approved for RFC publication, the
description can be updated.

Once the model conforms to the NMDA guidelines, I will be happy to advance
this draft to IETF Last Call.

Thanks,
Alia