[Sat] Re: Updated SATP Core draft uploaded --- Re: I-D Action: draft-ietf-satp-core-11.txt

[Rafael Belchior <[e-mail]>]

Hey Rama,

I've incorporated your feedback: 
https://github.com/ietf-satp/draft-ietf-satp-core/pull/49

Are we good to merge?

Cheers,

A 2025-09-17 21:16, Rafael Belchior escreveu:

> Hey Alex,
> 
> It's done! Conflicts could be avoided (mostly, I presume) by running 
> the linter, committing changes, and then rebasing onto the main branch 
> (assuming that the main differences are due to linting).
> 
> Cheers,
> 
> A 2025-09-17 18:25, Alex Chiriac escreveu:
> 
> Hi Rafael!
> 
> After you address Rama's comments on the PR, I will raise a follow-up 
> to address the comments on Wes's original PR. Just cautious there are a 
> lot of linting changes and I'm trying to avoid conflicts. Thanks!
> 
> Kind regards,
> Alex
> 
> Alex Chiriac
> 
> ​​​​
> 
> Engineering Lead
> 
> [1]
> 
> [e-mail]
> 
> T: [phone]
> 
> quant.network [2]
> 
> [3]
> 
> [4]
> 
> The content of this email is confidential and intended for the 
> recipient specified in message only. It is ​strictly forbidden to share 
> any part of this message with any third party, without a written 
> consent of ​the sender. If you received this message by mistake, please 
> reply to this message and follow with its ​deletion, so that we can 
> ensure such a mistake does not occur in the future.
> ​
> ​
> 
> -------------------------
> 
> From: Rafael Belchior 
> <rafael.belchior=[e-mail]>
> Sent: 16 September 2025 18:42
> To: Alex Chiriac <[e-mail]>
> Cc: Wes Hardaker <[e-mail]>; Thomas Hardjono 
> <[e-mail]>; [e-mail] <[e-mail]>; Claire Facer 
> <[e-mail]>; [e-mail] <[e-mail]>; 
> [e-mail] <[e-mail]>
> Subject: Re: [Sat] Re: Updated SATP Core draft uploaded --- Re: I-D 
> Action: draft-ietf-satp-core-11.txt
> 
> CAUTION: This email originated from outside of the organisation. Do not 
> click links or open attachments unless you recognise the sender and 
> know the content is safe.
> 
> 2025-09-16 20:39, Alex Chiriac escreveu:
> 
> Thanks Rafael! I approved the PR, needs 1 more approval!
> 
> - Error table looks good to me as a WIP. Do we expect the category, 
> type and description of these errors to appear in an error message 
> response? If yes, a further suggestion from me would be to use all 
> capitals and underscores as the categories and types would probably be 
> implemented as an enum (similar to the claim formats or lock types, 
> e.g. "HASH_TIME_LOCK", etc. for consistency).
> 
> Good question - possibly not mandatory, but surely would help 
> developers. In any case, those are in the specification.
> 
> - Great set of labels for the repo!
> - Thank you for spending the time on updating the linting!
> 
> You're welcome, I hope it helps.
> 
> Kind regards,
> Alex
> 
> Alex Chiriac
> 
> ​​​​
> 
> Engineering Lead
> 
> [1]
> 
> [e-mail]
> 
> T: [phone]
> 
> quant.network [2]
> 
> [3]
> 
> [4]
> 
> The content of this email is confidential and intended for the 
> recipient specified in message only. It is ​strictly forbidden to share 
> any part of this message with any third party, without a written 
> consent of ​the sender. If you received this message by mistake, please 
> reply to this message and follow with its ​deletion, so that we can 
> ensure such a mistake does not occur in the future.
> ​
> ​
> 
> -------------------------
> 
> From: Rafael Belchior <[e-mail]>
> Sent: 16 September 2025 17:37
> To: Wes Hardaker <[e-mail]>
> Cc: Alex Chiriac <[e-mail]>; Thomas Hardjono 
> <[e-mail]>; [e-mail] <[e-mail]>; Claire Facer 
> <[e-mail]>; [e-mail] <[e-mail]>; 
> [e-mail] <[e-mail]>
> Subject: Re: [Sat] Re: Updated SATP Core draft uploaded --- Re: I-D 
> Action: draft-ietf-satp-core-11.txt
> 
> CAUTION: This email originated from outside of the organisation. Do not 
> click links or open attachments unless you recognise the sender and 
> know the content is safe.
> 
> Dear All,
> Thank you Wes for your contribution and Alex for your review.
> I've added to the spec the table with the errors. Please note that the
> error section was done by Thomas and myself a while ago and does not
> cover all possible errors (a WIP).:
> https://gbr01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fietf-satp%2Fdraft-ietf-satp-core%2Fpull%2F49&data=05%7C02%7Calexandru.chiriac%40quant.network%7C415f9b5b34dc4fa1e09708ddf53f61ca%7C70500bf4d41742598a6eb7a550c6d120%7C0%7C0%7C638936374782845090%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=OOeetLRnlobDvQNy1R1Agb857wOEdR0Bpmbc%2FCt7PVY%3D&reserved=0 
> [5]
> 
> I would like feedback on the categories, as I've came with some basic
> ones (category mapped to stage and substage essentially).
> I have created a series of labels to help organize the issues:
> https://gbr01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fietf-satp%2Fdraft-ietf-satp-core%2Fissues%2Flabels&data=05%7C02%7Calexandru.chiriac%40quant.network%7C415f9b5b34dc4fa1e09708ddf53f61ca%7C70500bf4d41742598a6eb7a550c6d120%7C0%7C0%7C638936374782882899%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=V0EAbUdrimz9B4AICza5IzH%2BRLCIOXjva6hUcdcUX%2B4%3D&reserved=0 
> [6]. I've
> skimmed through the new issues and labeled them as best as I could, and
> those are good considerations. We may discuss them in one of our
> meetings (or at the IETF conference). Our implementation at Hyperledger
> Cacti effectively deals with some of these problems, namely
> under-specification of stage 0 (cc. Rodolfo, who was working on this).
> 
> I have also took the liberty to fix a common pain point: the linting.
> For every push, the pipelines will pass only (and only if) the linter
> passes. This guarantees compatibility between the current draft and a
> direct upload to the IETF. While I've configured this linter months 
> ago,
> it's application was manual. Now there is a target that can be ran to 
> do
> this: "make lint-fix". This job needs a binary, which can be obtained
> via "make setup". I have documented everything in the READNE.
> Supports/tested on "Linux 6.6.87.2-microsoft-standard-WSL2".
> 
> I've also made the review process more robust in the SATP-core repo by
> requiring at least 2 approvals from a maintainer (i.e., draft author)
> for changes to be incorporated.
> 
> Cheers,
> 
> A 2025-09-16 18:19, Wes Hardaker escreveu:
>> Alex Chiriac <[e-mail]> writes:
>> 
>>> I have reviewed the pull request in full and left detailed comments.
>>> It's mostly looking good
>>> to me, but there are 2 open questions on the mention of base64
>>> encoding and error message
>>> examples.
>> 
>> Note: I believe that the error codes need to be pulled into the IANA
>> section as a new table instead of as an appendix.  If you have an
>> enumerated set of codes somewhere (like err.15.1 or whatever), it
>> realyl
>> needs a registration table.
>> 
>> I was going to do that too, but didn't want to do it in the same PR.
>> Someone else could, of course, take it on.  To me it looked like a new
>> table with 4 columns: the enumeration string (eg err_3.3.1), a
>> category (eg "commit
>> ready errors"), a error type (eg "badly formed message"), and a
>> description ("mismatch transferContextId").
>> --
>> Wes Hardaker
>> Google
> 
> --
> -- Rafael Belchior
> 
> Ph.D in Computer Science and Engineering, Blockchain
> https://gbr01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frafaelapb.github.io%2F&data=05%7C02%7Calexandru.chiriac%40quant.network%7C415f9b5b34dc4fa1e09708ddf53f61ca%7C70500bf4d41742598a6eb7a550c6d120%7C0%7C0%7C638936374782926672%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=ROlZE9cljMVEHY8%2FtHEkjC7q6Z2Ke5Q%2BSwCUupyxf1c%3D&reserved=0 
> [7]
> 
> --
> -- Rafael Belchior
> 
> Ph.D in Computer Science and Engineering, Blockchain
> https://rafaelapb.github.io/

-- 
-- Rafael Belchior

Ph.D in Computer Science and Engineering, Blockchain
https://rafaelapb.github.io/

-- 
-- Rafael Belchior

Ph.D in Computer Science and Engineering, Blockchain
https://rafaelapb.github.io/

Links:
------
[1] https://www.quant.network/
[2] http://www.quant.network/
[3] https://twitter.com/quant_network
[4] https://www.linkedin.com/company/quantnetwork/
[5] https://github.com/ietf-satp/draft-ietf-satp-core/pull/49
[6] https://github.com/ietf-satp/draft-ietf-satp-core/issues/labels
[7] https://rafaelapb.github.io/