[secdir] Secdir review of draft-eastlake-fnv

Watson Ladd <watsonbladd@gmail.com> Fri, 11 October 2024 20:10 UTC

Return-Path: <watsonbladd@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6BA07C1D8776; Fri, 11 Oct 2024 13:10:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.105
X-Spam-Level:
X-Spam-Status: No, score=-2.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dXvXNLou5wFw; Fri, 11 Oct 2024 13:10:29 -0700 (PDT)
Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 96F73C15155A; Fri, 11 Oct 2024 13:10:29 -0700 (PDT)
Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-37d43a9bc03so1360865f8f.2; Fri, 11 Oct 2024 13:10:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728677428; x=1729282228; darn=ietf.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=CJDDrp85b/6bYzmNsgK21lPryLwnh79L9TAioqndp+M=; b=fiUiF7IOYWpHGpmkkV+mbl4/EMsMYc5QSNux0jl8MsJJm0qALsM3auHmw6CAYwatRr nhF0b6DahTPwHf4lUujodMQdEgIb4Y2I8AwEcwCYsjN6CzvbkTkVEG22HxHG5A/U9pHv t2EZDhHRWxv+Of6ZWpe0CN+I+E7PWf5UIoykobTFrz+E4TMnwM8MP3x+oh4axgW9Q6vo t9BpXtxxh2wWQkoWtv+s4/Q6SIbpPGJ/Nul7/UdIgq+88qBfsdk9SEj1bPhTAUqdWZac 5KsQ+JeKeWEIcIFMfHA3CJ/TUrMR5BQEyZrH731woIU4/kGNBm/6kDlgaCJkUZF4zzt1 jOQQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728677428; x=1729282228; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=CJDDrp85b/6bYzmNsgK21lPryLwnh79L9TAioqndp+M=; b=ffrCBvrcLfkoJ2vfVyaCkLy6lRi+DPZ4q8MTneDmIfLPUz3E+WU1Jb+IoDsCPKawS0 tdqdSFt6YHzciDXzro1yT+1Nqt06+kmi1arp2B0bltqpxXkvQcr7pLEWwhN/v5rbC5/5 X+Jfz68KL8Nixb/0pTfG/iQCOwMlWQBK/Ox+9spKLMWCbL+aGCYGekuszcsgPG00jooA UGtD5DNEMZZouuecPmH354/UiPPnAQ4B/BjHyGnrnwyVVQjr/omVwzwP4IB+00jVXOQX iZKmF1sREiNgLEe51KuIcDk33889Hk98ALn9jelpexB0xJ/kqkgVnAf+kIMdtDUS5inE Jw2A==
X-Forwarded-Encrypted: i=1; AJvYcCVKkHyj++AvvsYfJLTszUYVTmlBM5PDQrtTgqVnFfUDN8vTUiNZnwkaNVSeq5yFKlcveHbbqjpIkik=@ietf.org
X-Gm-Message-State: AOJu0Ywhi/gNV1ClsIgy6aALyXAvfVEfT55qU30LNsubD3CTFpkbcZmp PFNnY55IyISNnwFwKj9iZV8zJvQcHlGoOYw8+ZfF0TvfhZiB7vDNVQBjzOGvz2K96mKGCprw95W UVRfGo4cB2ieWh4bEkprATG/xwaIRX0Q9
X-Google-Smtp-Source: AGHT+IG6SbmXcfNEkZwYJdPpL77QYTOsrGCZpmzJ9KlG8zVI8yWTynPg7x/WF/IZYPa7q6XX252updonMNUhg4B0w+g=
X-Received: by 2002:a05:6000:18a:b0:37d:41c5:a527 with SMTP id ffacd0b85a97d-37d5feaa088mr451379f8f.13.1728677427443; Fri, 11 Oct 2024 13:10:27 -0700 (PDT)
MIME-Version: 1.0
From: Watson Ladd <watsonbladd@gmail.com>
Date: Fri, 11 Oct 2024 13:10:16 -0700
Message-ID: <CACsn0ckfrAfi8HkKexqrFj6OisqFcYYN55L4OXuG0mxXJt1J3g@mail.gmail.com>
To: secdir <secdir@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID-Hash: KFSXNW4S5XYPFN7XKEM5PWWHAXT3HOEC
X-Message-ID-Hash: KFSXNW4S5XYPFN7XKEM5PWWHAXT3HOEC
X-MailFrom: watsonbladd@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-secdir.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-eastlake-fnv.all@ietf.org, last-call@ietf.org
X-Mailman-Version: 3.3.9rc5
Precedence: list
Subject: [secdir] Secdir review of draft-eastlake-fnv
List-Id: Security Area Directorate <secdir.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/AcNuChsy8e1Zz7ZlUFCnH9Am0Ks>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Owner: <mailto:secdir-owner@ietf.org>
List-Post: <mailto:secdir@ietf.org>
List-Subscribe: <mailto:secdir-join@ietf.org>
List-Unsubscribe: <mailto:secdir-leave@ietf.org>

Dear all,

I have reviewed this document as part of the security directorate's
ongoing effort to review all IETF documents being processed by the
IESG. These comments were written primarily for the benefit of the
security area directors. Document editors and WG chairs should treat
these comments just like any other last call comments.

The summary of the review is Not Ready.

The draft does a good job of describing the FNV-1a hash function.
However, it falls short on recommending when it should be used and
when it should not be. Python had to change away from FNV-1a due to
collision attacks leading to DoS (https://peps.python.org/pep-0456/,
https://www.youtube.com/watch?v=Vdrab3sB7MU) The offset is
insufficient to solve this problem. FNV-1a is slower than other hash
functions with better guarantees of equidistribution, taking one
multiply per byte and is hard to parallelize. I think this draft needs
to say these things, and advise against usage in new applications and
protocols.

Sincerely,
Watson Ladd

-- 
Astra mortemque praestare gradatim