[secdir] Secdir review of draft-ietf-ace-oauth-params-06

Charlie Kaufman <charliekaufman@outlook.com> Fri, 13 December 2019 07:48 UTC

Return-Path: <charliekaufman@outlook.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 03BDB1201EA; Thu, 12 Dec 2019 23:48:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=outlook.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hYbEK5jbSj9U; Thu, 12 Dec 2019 23:48:24 -0800 (PST)
Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10olkn2035.outbound.protection.outlook.com [40.92.40.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 92CB71200F7; Thu, 12 Dec 2019 23:48:24 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ddMW9xa6+5H/+XQzAaSFuqw/TGYJwbx8bVDFLLqF5ga7pS1VaIWhxe8/GdeDiNRS7XAkYVZxdVVQU3gt4GCfuvSMXB11DD8ZEFTAxbrudalcAWWTUdv1q7jIGe0pf8aqi0Yv8G4IDjJDELNqg4Hu5ds5zyR+/+GRchYuzPYkU4E5rcf31Kj5OLHD3Ozy82CPYunRbOcnbIeRwSMrt8aMyjtZxTAcHLI8H8SRg5zb2GddgS06nLU+0tFYSC+vteMHRalaPBeJqUCBoiWb9i87NL0KPZ5EEFNoTp+31/wu14Lbtt3A67ZIOaMDgGWv34BP5cn0vmX6ZnA81wZzd1SrtA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jO/Ioxyy2SBmn64K33adfWc3LWG8plRuN9Qt6t4pdKE=; b=DmOM+JwgdbFTfRCEI0gpUtRm7/PjxlNmLBng6NwO5ewhNWdZWdwuAbUmEa1FbWYV3EBt10BquqNJSiq4NhjadAGELTmFihys/DJyp3ytV7QI3xEucaCLTn53GJc0A3mckFCksCL8rGHzulG41UqErTAvS3IriL1mp8h+JQBC3dToi/YmuuSHtroUyUDLTR5Sqh5TTmDnTrcNxyvaB2Ym46wDAoQHvPNqm9VFhVVj03KZVFMMct635q+bsv4Ota9mGktr1WR77Qtz4NvzcYVqg9Sd4rXE3nYLTrOLbkXeNwejQ2cQgLoQXH/8R73HiHWB3apPAPVkd7RhcM8tj7kx4A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jO/Ioxyy2SBmn64K33adfWc3LWG8plRuN9Qt6t4pdKE=; b=DDCGiEezIXS/YfusbezFlTJI7xsMTPev3ORUUlOAjoyB2vzcIF7waTtFVjD25CMhTPooPr/dBxNQGvyhJnuqTxHzsjRUVSYr8KnCey/yPfMJM6IYTTmDKXvFFqiWK9PPMDUMjoYCNB0IHsjA3kDqmT9K5GQ+7q8Y9FyOv4QWq5antyT6fbvmbafTGNtjQB/2hqrsflHiSJFwfZTT0YR28MT08kf+b7XIEngO8yY0gW+XD+dCnVmPoIawb6YdZIO1AZqZolaXeSp1cgv3eiQpZi1OjGJ4q+bNK4PBztnL0s/6WCYZmmyekc1soLA69gWsJgP67nbJdiru33R95PuzNQ==
Received: from DM6NAM10FT063.eop-nam10.prod.protection.outlook.com (10.13.152.58) by DM6NAM10HT179.eop-nam10.prod.protection.outlook.com (10.13.153.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.14; Fri, 13 Dec 2019 07:48:23 +0000
Received: from MWHPR04MB0367.namprd04.prod.outlook.com (10.13.152.57) by DM6NAM10FT063.mail.protection.outlook.com (10.13.152.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.14 via Frontend Transport; Fri, 13 Dec 2019 07:48:23 +0000
Received: from MWHPR04MB0367.namprd04.prod.outlook.com ([fe80::1d83:aeb7:d1b7:ef79]) by MWHPR04MB0367.namprd04.prod.outlook.com ([fe80::1d83:aeb7:d1b7:ef79%10]) with mapi id 15.20.2538.017; Fri, 13 Dec 2019 07:48:22 +0000
From: Charlie Kaufman <charliekaufman@outlook.com>
To: "secdir@ietf.org" <secdir@ietf.org>, "iesg@ietf.org" <iesg@ietf.org>, "draft-ietf-ace-oauth-params.all@ietf.org" <draft-ietf-ace-oauth-params.all@ietf.org>
Thread-Topic: Secdir review of draft-ietf-ace-oauth-params-06
Thread-Index: AQHVsYlz67iuRug560mk2vT/YE5oCg==
Date: Fri, 13 Dec 2019 07:48:22 +0000
Message-ID: <MWHPR04MB036776E5D9FF69796005E730DF540@MWHPR04MB0367.namprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-incomingtopheadermarker: OriginalChecksum:1C6F730ED9AFC6174B1000F7AE89873D243805D6B8334C9AD6BDE6DEDC65B2DF; UpperCasedChecksum:FC18AEA5B492A3A38559DC1F1DA202F8CCDD7119E451A1582DD0B430A8D23B18; SizeAsReceived:6998; Count:42
x-tmn: [BwndDDAu5zlDQ60kkAXifg6Nmbx8HuED97/GFVvcBaNBs4dtQ6m20YYeN6796Sze]
x-ms-publictraffictype: Email
x-incomingheadercount: 42
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: 1c55bbf5-9530-4f92-c706-08d77fa0d450
x-ms-traffictypediagnostic: DM6NAM10HT179:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: FhOpN7Y6WO5MdPJrkx5gr3jX6LiDb6FRHj0QQyOUNVKx1fZW4ExhNZAW3Js02VI4tDTTMMPwYbEcXQIFMh5UymW6XpVG3TmRHS1GNTJI7+c0Nc2XUTtRKKaOX5ZId+cuhNRPWbLX+gb0yy1h4JZaccbPtzJm4Lr5uy7cWfq0FJ/gclHw1Wjz4Wg7oOcQ/GvO
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_MWHPR04MB036776E5D9FF69796005E730DF540MWHPR04MB0367namp_"
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c55bbf5-9530-4f92-c706-08d77fa0d450
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2019 07:48:22.8443 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM10HT179
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/KaYEiThsRWP6K3QZ4OPIT8TFL84>
Subject: [secdir] Secdir review of draft-ietf-ace-oauth-params-06
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Dec 2019 07:48:27 -0000

I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG.  These comments were written primarily for the benefit of the security area directors.  Document editors and WG chairs should treat these comments just like any other last call comments.

This document only exists because of a scheduling issue between the ACE and OAUTH working groups. The ACE working group needed some additional OAUTH extensions added more quickly that the OAUTH group could manage to do it. This document is intended to only exist until the OAUTH group can make the corresponding changes. As such, it really doesn't have security considerations beyond those in the document it modifies.

The security considerations section says (and I agree):

This document is an extension to [I-D.ietf-ace-oauth-authz]. All security considerations from that document apply here as well.

Some acronyms that were not defined (but this might be OK in the context of this being a modification to another document): AS, RS, CoAP, cnf, CBOR, pop, CWT


A few typos / odd phrasing:

Abstract: whishes -> wishes
Appendix A: possesion -> possession

>From Section 2:
Note that the term "endpoint" is used here following its OAuth 2.0 [RFC6749] definition, which is to denote resources such as token and introspection at the AS and authz-info at the RS.

Really? The term "endpoint" refers to tokens and authz-info data structures? This seems unlikely.

Continuing in Section 2:
The CoAP [RFC7252] definition, which is "An entity participating in the CoAP protocol" is not used in this specification.

Why is a definition that does not apply relevant to this document?