[secdir] SECDIR Review draft-ietf-ippm-ioam-flags-06

Donald Eastlake <d3e3e3@gmail.com> Wed, 22 September 2021 21:24 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C3F333A0863; Wed, 22 Sep 2021 14:24:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.849
X-Spam-Level:
X-Spam-Status: No, score=-1.849 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YK-o1pcYZHkR; Wed, 22 Sep 2021 14:24:20 -0700 (PDT)
Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 13E873A084E; Wed, 22 Sep 2021 14:24:17 -0700 (PDT)
Received: by mail-io1-xd33.google.com with SMTP id y197so5267637iof.11; Wed, 22 Sep 2021 14:24:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to:cc; bh=S1nexqenueCERDZC9krCjJE+LEJlryoM6D7/F2xpros=; b=Q0sCF7JVEng2S+E7NsYiKBoMdTPCt3UrgCk3X6/ACw7YEizw3PCBstjWo9YVz73UAJ 7su8NPmgcQLoR8dyj4rpVQ92tbq2XKak1oA937acUjQ4NPxUYZs7PRX7BXxVY2YSD+tu 6k45mZQC3xSbqcjK7bcCJZYMqxJz5ncVxEUeMkV7rvsR/cnaqh6CUpVbnwTon5PBbo98 ESP9Q6DpL9uifAWri4A/+gAd0j06Fv3HzST9OqMC+E4CqN3jLdRcc/alpenQWv+mp5OJ OfACStpOJ1kowOR9tisC/GzWbw6o40UCsNWxzKHwkBWVbXy+q+kbJObafDMOohb1IrLU gJaA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=S1nexqenueCERDZC9krCjJE+LEJlryoM6D7/F2xpros=; b=RYCyX/N24SBE9udf212/cmtHzVyCVbFh9ym2IXov1NfTKqUPZy3xlPzO0+unpNi9hK z6znTEszrWjtsAfCOd2OPOI4B9zVHL97TKJ6qo13Cjd3ZZP19ndHI5H2oSCPv1roakqP +3KdXwBXgh53zvK7dUhib0fYRk13E8sHBhzo4z3ez9w11DiyiSyvqM/FGrMT6Huda6ea h3392peBjLQmLBQUdzpskh1gIs/RkyOJrgYXSBJ7m5smg7fSZJRMzD4PmrxEPQgmU7oX 4VQBfniCHQQv3qwt3dGO/K70LuwuF4RPtubS1Di+7gBhz1XZ5q94PYIZWGNquDeCjElP iBVg==
X-Gm-Message-State: AOAM533DX+uiLWYQyLDkodqavdAm+Zxm4pf37NPllKwkJivzHwyIOL1T lqTFgN0VZTQkMAnkzYFZVnkbMTy7aSwX0+lTZzniJsn0sQQ=
X-Google-Smtp-Source: ABdhPJxAuvINjVnGGY30gxIQGdU3VyTnKuWvMrUojvtESn7XlxcKQf3qO2iYw/5CqYH9vH32H1yy6nMxXWy/ZjYjPpY=
X-Received: by 2002:a02:7f4a:: with SMTP id r71mr1014656jac.132.1632345855839; Wed, 22 Sep 2021 14:24:15 -0700 (PDT)
MIME-Version: 1.0
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Wed, 22 Sep 2021 17:24:04 -0400
Message-ID: <CAF4+nEGPGAUGg0o9-jAm4MPgiitF2h6u99tRJeDGX9dZE15tDw@mail.gmail.com>
To: "iesg@ietf.org" <iesg@ietf.org>
Cc: secdir <secdir@ietf.org>, draft-ietf-ippm-ioam-flags.all@ietf.org, Last Call <last-call@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/Kjb-S2PQDqnzGiPmROEfwauujx4>
Subject: [secdir] SECDIR Review draft-ietf-ippm-ioam-flags-06
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Sep 2021 21:24:26 -0000

I have reviewed this document as part of the security directorate's
ongoing effort to review all IETF documents being processed by the
IESG..  Document editors and WG chairs should treat these comments
just like any other last call comments.

The summary of the review is Ready with a minor issue. (really just
capitalization of key words)

Security:

I believe that the theme of the Security Considerations section, that
possible use of the IOAM flags specified in this document could be
used in amplification attacks, is correct and that the Security
Considerations section adequately explores this topic.

Minor:

Section 4.1.1: Both occurrences of "recommended" seem like they should
be in all capital letters.

Section 4.2: Second paragraph, "recommended" should be all capital
letters. Also, this stuff about N seems to be redundantly included in
both 4.1.1 and 4.2 which are adjacent sections. Maybe the second
paragraph in 4.2 could be replaced by a tweaked version of its first
sentence something like: "An IOAM node that supports the reception and
processing of the Loopback flag MUST support the ability to limit the
rate of the looped back packets as discussed in Section 4.1.1.".

Section 5: last paragraph, "It is recommended to use N>100." -> "Using
N>100 is RECOMMENDED."

Nits:

Section 2.2: Suggest adding reference to the Terminology entry for
OAM:  [RFC6291]

Section 4.1: last sentence of 2nd paragraph (first full sentence of
page 5): Somehow "allowing a single data field" does not sound quite
strong enough to me. Suggest "allowing only a single data field" or
"limiting to a single data field" or some other stronger and clearer
wording.

Section 4.1.1: Remove superfluous wording: "It is noted that this
requirement..." -> "This requirement..."
Section 4.1.1: Grammar and incorporating capitalization point from
above: "it is recommended to use N>100." -> "using N>100 is
RECOMMENDED." (and same change in Section 4.2 if Section 4.2 is not
modified as suggested above)

Section 5: third bullet point "one or more IOAM option," -> "one or
more IOAM options," Also, in the same bullet point, remove superfluous
wording "It should be noted that the current..." -> "The current..."

Multiple places "to avoid loading" would be a little better as "to
avoid overloading" or "to avoid excessively loading".

There are almost twice as many authors as the guideline maximum of 5.

Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 2386 Panoramic Circle, Apopka, FL 32703 USA
 d3e3e3@gmail.com