[secdir] Early review of draft-ietf-p2psip-share-09

Russ Housley <housley@vigilsec.com> Thu, 13 October 2016 15:15 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 86E1F1295D8 for <secdir@ietfa.amsl.com>; Thu, 13 Oct 2016 08:15:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -101.9
X-Spam-Level:
X-Spam-Status: No, score=-101.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, USER_IN_WHITELIST=-100] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qvp2EkNbaVNa for <secdir@ietfa.amsl.com>; Thu, 13 Oct 2016 08:15:05 -0700 (PDT)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AE029129549 for <secdir@ietf.org>; Thu, 13 Oct 2016 08:15:05 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id BF63F300A58 for <secdir@ietf.org>; Thu, 13 Oct 2016 11:15:04 -0400 (EDT)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id TNypSiNQIfP5 for <secdir@ietf.org>; Thu, 13 Oct 2016 11:15:03 -0400 (EDT)
Received: from [192.168.2.100] (pool-108-45-101-150.washdc.fios.verizon.net [108.45.101.150]) by mail.smeinc.net (Postfix) with ESMTPSA id 30001300579; Thu, 13 Oct 2016 11:15:03 -0400 (EDT)
From: Russ Housley <housley@vigilsec.com>
X-Pgp-Agent: GPGMail
Content-Type: multipart/signed; boundary="Apple-Mail=_63B53435-893D-4EC0-9026-26F9E76B6A78"; protocol="application/pgp-signature"; micalg=pgp-sha1
Date: Thu, 13 Oct 2016 11:08:10 -0400
Message-Id: <9A291382-85CD-48AD-8807-F2B3E6089138@vigilsec.com>
To: draft-ietf-p2psip-share.all@ietf.org
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
X-Mailer: Apple Mail (2.1878.6)
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/T5WEaI5doUzJmIX6so3t9ARvg9c>
Cc: Alissa Cooper <alissa@cooperw.in>, IETF SecDir <secdir@ietf.org>
Subject: [secdir] Early review of draft-ietf-p2psip-share-09
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Oct 2016 15:15:07 -0000

I reviewed this document for the Security Directorate after a request
by the ART AD for an early review.

Version reviewed: draft-ietf-p2psip-share-09


Summary: Ready (from a Security Directorate perspective)

Thank you for addressing the comments that I provided on -08.


Major Concerns:  None


Minor Concerns:  None


Nits:

Section 5.1 says:

   When defining the pattern, care must be taken to avoid conflicts
   arising from two user names of witch one is a substring of the other.

s/witch/which/