Re: [secdir] SECDIR Reveiw of draft-ietf-hip-dex-11
Donald Eastlake <d3e3e3@gmail.com> Fri, 07 February 2020 05:29 UTC
Return-Path: <d3e3e3@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6E37412001B; Thu, 6 Feb 2020 21:29:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.748
X-Spam-Level:
X-Spam-Status: No, score=-1.748 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UzQ5gdTXXWtT; Thu, 6 Feb 2020 21:29:55 -0800 (PST)
Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E93D8120058; Thu, 6 Feb 2020 21:29:54 -0800 (PST)
Received: by mail-il1-x130.google.com with SMTP id f10so672145ils.8; Thu, 06 Feb 2020 21:29:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yADnkR/ou0fhxAvh9doASDpI+WHLBDlt91fN5ZrqqNQ=; b=aP+3KgVkHYrMc9Mdft2ljeBLe6uPJzl83cadkUF7ku5SkTKllzvNTiW17IU5c6gBuq +isOQvhuaJ9LUq5v6BeNWCl8JwaiBkYYS0y8EFjOXk2zKa1zlVrskYb8ob1taQZJi1E9 QI/X5kabJP6SqGI3fHF5M0cAxhrLJhm3cgByQ4I3NE4lsZ43jOPsCVdlZv8xQQb16kkX ZFFl8qiQfEtTD5Jg/VIkFsTRnMYN0u8v9qNIB7T4QBMhQj0FN4XriqqM+C7J9MWT3/3B uor9p0k2Roqe3V14Z0ood55Ac528FAORaRsCELx6cT6OmpAu8K0BywQmNYWG/66peqBE OUew==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yADnkR/ou0fhxAvh9doASDpI+WHLBDlt91fN5ZrqqNQ=; b=IX6HwCtjt8KsWD7NHuOPzvW2s1tZ218H2jT2RuUSOSvo7XfpGNr9E/BQxICuALSShl 4v3/4N6eU2w00VCydm9JOeUcpWFVidFgvYXwcQaTEqrZVwyDZHn6PMqtGhoRyzwAbyRE WE8ZfHYD9e1X/4UmxBCcXeNuxZhflta5Rzhbese85bZa86hdnkHKSOtSV1TuRuLed4w9 Ez1iJs8DJdnU17nFOIf33Mb/uB8JAtIZhrRr8mURTvabyDVFYQNdaaRcLMtp+YKVBRCN TW0b7lzu8ITvjKwkjpVN7X6pchHCM4d2xa/J1y4qSBPsyf+BRsWGWMyGIaFzgwIiqpqV tmxw==
X-Gm-Message-State: APjAAAWB7KmeaIvFQZysSyFgY/eC1Pfaw1CQiEoEAdm7Z+l0NogQw943 njLFRnnZkiACrgUORr0FGEivJKJgLoPI/T4ocwlHu/kj
X-Google-Smtp-Source: APXvYqxwgQ/4IivCnxH1AST2b+yc7kmtvebpFzXOyiICbwZ0mDVzxkfsyGB7cr9chVrTvVqOC79eBlOTDE1Ig0KBrF0=
X-Received: by 2002:a92:4e:: with SMTP id 75mr7454190ila.276.1581053394250; Thu, 06 Feb 2020 21:29:54 -0800 (PST)
MIME-Version: 1.0
References: <CAF4+nEH=x4Lggm+mmr2aFz9eEy6ajWK9upJE7BQk60p6xLDBxw@mail.gmail.com> <f9d85f45-0385-f552-f324-3f5352632815@labs.htt-consult.com>
In-Reply-To: <f9d85f45-0385-f552-f324-3f5352632815@labs.htt-consult.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Fri, 07 Feb 2020 00:29:43 -0500
Message-ID: <CAF4+nEH=oC0MSP_1p25H2-gmhRD++Gcr7WEEqOJ1R7xOnaMjwA@mail.gmail.com>
To: Robert Moskowitz <rgm@labs.htt-consult.com>
Cc: draft-ietf-hip-dex.all@ietf.org, "iesg@ietf.org" <iesg@ietf.org>, secdir <secdir@ietf.org>, Miika Komu <miika.komu@ericsson.com>
Content-Type: multipart/alternative; boundary="000000000000ef7346059df5add6"
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/c9w3DNH3UDPzbN__Jl8cDqaUjC4>
Subject: Re: [secdir] SECDIR Reveiw of draft-ietf-hip-dex-11
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Feb 2020 05:29:57 -0000
Hi Bob, Sorry to delay in response... Changes look good to me with one little exception: On page 52, after the line beginning "Section 6", the next three lines are nicely indented but I believe the fourth line of text is sort of a continuation of the line beginning "Section 6" and so should not be specially indented but should be left justified lining up with the words "Section 6". Thanks, Donald =============================== Donald E. Eastlake 3rd +1-508-333-2270 (cell) 2386 Panoramic Circle, Apopka, FL 32703 USA d3e3e3@gmail.com On Mon, Jan 27, 2020 at 11:25 AM Robert Moskowitz <rgm@labs.htt-consult.com> wrote: > Donald, > > This is a partial update which I believe addresses your comments plus a > strong request to justify no PFS. > > Please check that I have indeed addressed your comments. > > More edits for other comments next. > > Bob > > On 1/20/20 11:18 PM, Donald Eastlake wrote: > > I have reviewed this document as (a very late) part of the security > directorate's ongoing effort to review all IETF documents being > processed by the IESG. > > The summary of the review is Ready with Nits. > > Sorry to get this review in so late but, while approved by the IESG, > the draft is still in revised draft needed state so this may do some > good. On the security front, although the draft is pretty complex and > I am not that familiar with HIP, I did not see any significant > security issues that were not already called out in the draft. So I > concentrated on possible editorial issues. > > Editorial: > > Section 1.1, 3rd paragraph, page 5. Delete "However," a the beginning > of the 2nd sentence. It doesn't make sense. > > Section 2.3, Definitions should be in alphabetic order. > > Section 2.3: It seems to me that people who are puzzled about what > something means are most likely to be puzzled by the acronym. So I > would put the acronym first, where there is an acronym or acronym-like > term to use, then the expansion in parenthesis or in the body of the > definition. This done for a couple of entries like CMAC and CKDF but > most are the other way. > > Section 3 last paragraph and Section 12.10 5th bullet: "to use" -> "use of" > > I think OGA and KEYMAT should be in the Definitions list and KEYMAT, > which I assume just is short for "keying material", should be expanded > on first use in Section 6.3. Alternatively, you could just replace all > occurrences of KEYMAT with "Keying Material". > > Section 5.3.2, page 23. The first sentence of the first paragraph > starting on that page has problems. Maybe "chose" should be "choses" > but I'm not sure: > "The DH_GROUP_LIST parameter contains the Responder's order of > preference based on which the Responder chose the ECDH key contained > in the HOST_ID parameter (see below)." > > Appendix A, first sentence, "allows to identify" -> "allows identifying" > > Appendix B, "IEDG" -> "IESG" > > Appendix B, around the middle of page 51, right after the line > beginning with "Section 6," there are three line with a blank line > before and after. I found this confusing at first. I suggest those > three line also be indented. > > Appendix B, page 52, "SHOUDS" -> "SHOUDs" > > Thanks, > Donald > =============================== > Donald E. Eastlake 3rd +1-508-333-2270 (cell) > 2386 Panoramic Circle, Apopka, FL 32703 USA > d3e3e3@gmail.com > > > -- > Robert Moskowitz > Owner > HTT Consulting > C: 248-219-2059 > F: 248-968-2824 > E: rgm@labs.htt-consult.com > > There's no limit to what can be accomplished if it doesn't matter who gets > the credit >
- [secdir] SECDIR Reveiw of draft-ietf-hip-dex-11 Donald Eastlake
- Re: [secdir] SECDIR Reveiw of draft-ietf-hip-dex-… Eric Vyncke (evyncke)
- Re: [secdir] SECDIR Reveiw of draft-ietf-hip-dex-… Donald Eastlake
- Re: [secdir] SECDIR Reveiw of draft-ietf-hip-dex-… Robert Moskowitz
- Re: [secdir] SECDIR Reveiw of draft-ietf-hip-dex-… Robert Moskowitz
- Re: [secdir] SECDIR Reveiw of draft-ietf-hip-dex-… Donald Eastlake
- Re: [secdir] SECDIR Reveiw of draft-ietf-hip-dex-… Robert Moskowitz