[secdir] SECDIR Review draft-ietf-ippm-ioam-flags-08
Donald Eastlake <d3e3e3@gmail.com> Wed, 15 June 2022 22:54 UTC
Return-Path: <d3e3e3@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 99509C14CF01; Wed, 15 Jun 2022 15:54:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.858
X-Spam-Level:
X-Spam-Status: No, score=-6.858 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sWCDw3U-JpTL; Wed, 15 Jun 2022 15:54:32 -0700 (PDT)
Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0ED89C14F693; Wed, 15 Jun 2022 15:54:32 -0700 (PDT)
Received: by mail-lf1-x136.google.com with SMTP id s6so21056060lfo.13; Wed, 15 Jun 2022 15:54:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to:cc; bh=kPdecYWky5ldZwxRSZOnl9nEDL5DPibqdQKK6HcnGPQ=; b=J04aIAfSEymkIKpJDUeNqy7Ihalgr/vuUS4tsWmyOuQdJq70EbPuk34r5GBEgszjYY ukb6STfXd0Kuxe3J/+AaS0FpyHHl4rvUhkWoOenppDTcAhFJmyiCUOh1JCM7FKcNXXcu w22g2fUcePIFTzB1z+xeo6CBTgwS+aTkEqdwKMvLFOQ5Eh7MQ9dkjYpBTbqhQJUOjPEh +ag9KlrWIITiq8X6ayFvhMQJmF/MAOIcdy8nE7vKNkGfinmLHos3gO0ACPFC4RJMz2re uIHjxUDZQSelp033jcxnW85NAVWXmhWKx9PIUSv1dRBOMdJT2okU97X1LvBX10ybj8in eEXQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=kPdecYWky5ldZwxRSZOnl9nEDL5DPibqdQKK6HcnGPQ=; b=JvO1cGaoP6OPj7aHq0IE0VqtP5NjDcnwQauYVi+mh61jT7Vo0+cpXVuYNefcVDyokw +Ln0HzJYw2OOAZe+HOYgmabO4FVsBCtlRWZ1r6VGVNP2IxGcKDpIPSo3QR4uA3NRZEw0 OxQqU788sJr+ZQU95qLnw4BGTdVInYE3GqmBi+UQMx5McosbSCJ/yTvm9D2zhoQv20nk dgowW3We/z8PralD6VlbT/B3lI5BkjWDV4WRMzjktp25CWhz2mqVLD9OJaEsXVx+L9Jx bB/xFkRvq4d2hpeYnDGRZcs/PvSXR6nbKRkilvhsUHo3Asd9fR3rCMWpdBX/yNg8sYrn 1bTw==
X-Gm-Message-State: AJIora8SCSG3jmkmrbJN0dOA9LWZ3WosqhOQ4MNvS6hJMyixcXy2cS2Z 1gUkQRp0BytsjGBsRQ0Ud3UpJRfbFrRrO1PSY5YdQG8CESs=
X-Google-Smtp-Source: AGRyM1vOlvAIVSRYf6dV4HgF5IQrmwLyYO6J0sHsbSa6hhwX8w5QBWs/G7cWjpJpbs9DOtFpWdbL0WnGRZWQmBTAsvc=
X-Received: by 2002:a05:6512:ea8:b0:479:8e3:df22 with SMTP id bi40-20020a0565120ea800b0047908e3df22mr981734lfb.43.1655333669211; Wed, 15 Jun 2022 15:54:29 -0700 (PDT)
MIME-Version: 1.0
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Wed, 15 Jun 2022 18:54:18 -0400
Message-ID: <CAF4+nEFWO4GJPRn1NAqr7V7edSBD3PK452G0vTJoBEMg836uQQ@mail.gmail.com>
To: "iesg@ietf.org" <iesg@ietf.org>
Cc: secdir <secdir@ietf.org>, draft-ietf-ippm-ioam-flags.all@ietf.org, Last Call <last-call@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000005690bb05e1846787"
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/pBFMKBGTtUIemV6qknWaqL8zVGQ>
Subject: [secdir] SECDIR Review draft-ietf-ippm-ioam-flags-08
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jun 2022 22:54:32 -0000
I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG.. Document editors and WG chairs should treat these comments just like any other last call comments. The summary of the review is Ready with nits. I previously reviewed -06 and almost all of my suggestions then were adopted. :-) Security: I believe that the theme of the Security Considerations section, that possible use of the IOAM flags specified in this document could be used in amplification attacks, is correct and that the Security Considerations section adequately explores this topic. Minor: In Section 2.2, Terminology: Suggest adding, for OAM, a reference to RFC 6291 "Guidelines for the Use of the "OAM" Acronym in the IETF". Section 4.1, 1st paragraph, 2nd sentence: I think "i.e." (which mean "id est" or "that is") should be "e.g." (which means "exempli gratia" or "for example") because I think there are reasons for on-demand use of IOAM Loopback other than failure detection. Section 4.1, last paragraph, 1st sentence: "with the Loopback flag" -> "with the Loopback flag set to 1". Section 4.1.1, last sentence of 3rd paragraph: "If there is no prior knowledge about the network topology or size, it is recommended to use N>100." -> "It is RECOMMENDED that N > 10*M or, if there is no knowledge of network topology or size, N > 100." Section 5, 2nd paragraph: "must terminate" -> "MUST terminate". Miscellaneous: Section 4.1.1, last paragraph: "guaranteed" is impossible to enforce. Suggest making this a little weaker such as: "if it is not guaranteed that" -> "unless". Editorial: Section 4.2, 2nd paragraph: "The looped back data rate SHOULD NOT exceed 1/N of the interface capacity on any of the IOAM node's interfaces. It is recommended to use N>100." -> "The looped back data rate SHOULD NOT exceed one percent of the interface capacity on any of the IOAM node's interfaces." Section 4.4, 1st paragraph: "and processed accordingly." -> "and the packet is processed accordingly." Section 5, 1st sentence after Figure 2: I don't think the whole draft focuses on active measurement. Perhaps "This draft focuses ..." -> "This section focuses ..." Section 5, 3rd bullet point: Fix up confusing wording. "A selected data packet that is replicated, and its (possibly truncated) copy is forwarded with one or more IOAM option," -> "A selected data packet is replicated and its (possibly truncated) copy is forwarded with one or more IOAM options,". Section 5, last paragraph: Could make a similar "one percent" change as suggested above. Section 6, 1st sentence: Too many "follow"s. Either delete "the following" or delete "as follows". That's it. Thanks, Donald =============================== Donald E. Eastlake 3rd +1-508-333-2270 (cell) 2386 Panoramic Circle, Apopka, FL 32703 USA d3e3e3@gmail.com
- [secdir] SECDIR Review draft-ietf-ippm-ioam-flags⦠Donald Eastlake