[secdir] draft-ietf-ipsecme-ikev2-pqc-auth-09 ietf last call Secdir review

Russ Housley via Datatracker <noreply@ietf.org> Fri, 17 July 2026 13:38 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: secdir@ietf.org
Delivered-To: secdir@mail2.ietf.org
Received: from [10.244.22.19] (gaia.k8s.ietf.org [4.156.85.76]) by mail2.ietf.org (Postfix) with ESMTP id 5E24211865528; Fri, 17 Jul 2026 06:38:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ietf.org; s=ietf1; t=1784295516; bh=4FSSmTD9vl3CMk70J/kxnDapDpT3DIfXGsiH3bSf6bE=; h=From:To:Cc:Subject:Reply-To:Date; b=k75joJGpQY/s4dyOIpExUa1TaRuw2/yE7GM74you0V3pHNg4DJRXsDAGy/8Ylu1S2 Np4j/clBHLc4Y0qTN0u+d/oIvfPtTSd4uEeqfUKKloJG0CBTVMfeZp85R5NO4f+zOK xJtUjyl0IG/kK2RBfhXpZZ0HJddc/WGlcVZsVoxQ=
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Russ Housley via Datatracker <noreply@ietf.org>
To: secdir@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.69.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <178429551628.939932.15174663595538430272@dt-datatracker-d4d6ff9d9-x8khv>
Date: Fri, 17 Jul 2026 06:38:36 -0700
Message-ID-Hash: C7TOSBLMJEOA7JHHX55CNCNTF63KGF46
X-Message-ID-Hash: C7TOSBLMJEOA7JHHX55CNCNTF63KGF46
X-MailFrom: noreply@ietf.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-secdir.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-ipsecme-ikev2-pqc-auth.all@ietf.org, ipsec@ietf.org, last-call@ietf.org
X-Mailman-Version: 3.3.9rc6
Reply-To: Russ Housley <housley@vigilsec.com>
Subject: [secdir] draft-ietf-ipsecme-ikev2-pqc-auth-09 ietf last call Secdir review
List-Id: Security Area Directorate <secdir.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/pk-mszLbStzrXqC8bFuecDE1oPY>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Owner: <mailto:secdir-owner@ietf.org>
List-Post: <mailto:secdir@ietf.org>
List-Subscribe: <mailto:secdir-join@ietf.org>
List-Unsubscribe: <mailto:secdir-leave@ietf.org>

Document: draft-ietf-ipsecme-ikev2-pqc-auth
Title: Signature Authentication in the Internet Key Exchange Version 2 (IKEv2) using PQC
Reviewer: Russ Housley
Review result: Has Nits

I reviewed this document as part of the Security Directorate's ongoing
effort to review all IETF documents being processed by the IESG.  These
comments were written primarily for the benefit of the Security Area
Directors.  Document authors, document editors, and WG chairs should
treat these comments just like any other IETF Last Call comments.

Document: draft-ietf-ipsecme-ikev2-pqc-auth-09
Reviewer: Russ Housley
Review Date: 2026-07-18
IETF LC End Date: 2026-07-31
IESG Telechat date: unknown

Summary: Has Nits


Major Concerns: None


Minor Concerns:

Section 6 says:

   The different parameter sets of SLH-DSA are identified via
   AlgorithmIdentifier ASN.1 objects, as specified in NIST [CSOR] and
   referenced in PKIX Algorithm Identifiers for the SLH-DSA [RFC9909].
   [FIPS205] defines two signature modes: pure mode and pre-hash mode.
   PKIX Algorithm Identifiers for the SLH-DSA [RFC9909] specifies the
   use of both Pure SLH-DSA and HashSLH-DSA in Public Key Infrastructure
   X.509 (PKIX) certificates and Certificate Revocation Lists (CRLs).
   
I think that discussing the fact that OIDs have been assigned for 
HashSLH-DSA leads to confusion since Section 3.2 says:

   This document specifies the use of
   pure mode for signature-based authentication in IKEv2, where the
   message is signed directly along with domain separation information.
   The data used for authentication in IKEv2, as described in
   Section 2.15 of IKEv2 [RFC7296], ...
   
   Please remove discussion of the HashSLH-DSA OIDs.


Nits:

Section 3.2: s/ML-DSA and SLH-DSA algorithms/ML-DSA and SLH-DSA algorithms, respectively/

Section 3.2: s/that implements side-/that implement side-/


Note:

I checked the hex strings for the OIDs in Appendix B, and they are correct.