Re: [sipcore] draft-ietf-sipcore-digest-scheme comments

Christer Holmberg <christer.holmberg@ericsson.com> Tue, 21 May 2019 20:57 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: sipcore@ietfa.amsl.com
Delivered-To: sipcore@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 44B4E1200D6 for <sipcore@ietfa.amsl.com>; Tue, 21 May 2019 13:57:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.011
X-Spam-Level:
X-Spam-Status: No, score=-2.011 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SPTi-Nyku4jc for <sipcore@ietfa.amsl.com>; Tue, 21 May 2019 13:57:32 -0700 (PDT)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30085.outbound.protection.outlook.com [40.107.3.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 76D9F12001A for <sipcore@ietf.org>; Tue, 21 May 2019 13:57:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HDBbnhB06ODFTP2S1X0uI+ONgZzvqseEbs1Z3X+cOU0=; b=P4ZTfwcy3y59KL16/MjCJcVMGV9lr++dHwfdZNBjyYbmNWSif9fnPHeduKm6FeDE4Y5EcMFrKeJIJ+6X3IQ6f+aUTSZmIby77UxYTL25txvN0LwdQFcdJT5XQ/fM/kW9aPHbE2hCCKFTQ7LdqU+cJZjd2Hrxw6HsUn/PDrDbjsc=
Received: from HE1PR07MB3161.eurprd07.prod.outlook.com (10.170.245.23) by HE1PR07MB3516.eurprd07.prod.outlook.com (10.170.248.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1922.7; Tue, 21 May 2019 20:57:29 +0000
Received: from HE1PR07MB3161.eurprd07.prod.outlook.com ([fe80::c999:f848:9abc:d321]) by HE1PR07MB3161.eurprd07.prod.outlook.com ([fe80::c999:f848:9abc:d321%6]) with mapi id 15.20.1922.013; Tue, 21 May 2019 20:57:29 +0000
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: "Olle E. Johansson" <oej@edvina.net>, Rifaat Shekh-Yusef <rifaat.ietf@gmail.com>
CC: SIPCORE <sipcore@ietf.org>
Thread-Topic: [sipcore] draft-ietf-sipcore-digest-scheme comments
Thread-Index: AQHVDLXhQrBFZP79BUqVpCNPfRzS+KZxOB6AgAJLmwCAAqM3AA==
Date: Tue, 21 May 2019 20:57:29 +0000
Message-ID: <B4A08741-A092-480C-AE12-2DD25D7835D0@ericsson.com>
References: <DE595AFF-5DEA-4A32-8527-10B841D6C7C1@edvina.net> <CAGL6epLMHoneH6PNgeF5TgJhveh-xWeZSW6XQDBB2Gf5mS9eRQ@mail.gmail.com> <C1431DCD-C4DD-4BFA-9C5D-E4DFE7B0F2DA@edvina.net>
In-Reply-To: <C1431DCD-C4DD-4BFA-9C5D-E4DFE7B0F2DA@edvina.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.19.0.190512
authentication-results: spf=none (sender IP is ) smtp.mailfrom=christer.holmberg@ericsson.com;
x-originating-ip: [79.140.208.49]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b41c8721-4be0-499a-279a-08d6de2ef024
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:HE1PR07MB3516;
x-ms-traffictypediagnostic: HE1PR07MB3516:
x-microsoft-antispam-prvs: <HE1PR07MB35160CB86C5CEB7F7A9E99F493070@HE1PR07MB3516.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 0044C17179
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(396003)(39860400002)(136003)(376002)(189003)(199004)(18543002)(51444003)(5660300002)(91956017)(76116006)(36756003)(66946007)(486006)(73956011)(25786009)(186003)(86362001)(6512007)(4326008)(102836004)(26005)(476003)(446003)(83716004)(11346002)(71190400001)(71200400001)(2616005)(66066001)(6436002)(3846002)(6116002)(14444005)(256004)(58126008)(110136005)(8676002)(68736007)(82746002)(33656002)(6486002)(81156014)(14454004)(81166006)(99286004)(53936002)(8936002)(66556008)(508600001)(66476007)(229853002)(6246003)(305945005)(44832011)(316002)(76176011)(6506007)(64756008)(66446008)(7736002)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR07MB3516; H:HE1PR07MB3161.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: USHETi8xb5zBIDsVQxsNLQJwLNXLeEIoAhzIISKWekdGvv7zWJNuL/lnIlVbucsuHoGz7G6VC+efjPUeMBtC9fIWp3JMXv/TFr7SCi3I5+8c/vcGoordRIAS1djrgLtmt6634jAWx69e+G70F5nrMMKwbfPCFu8KU/y1A5XQhAqHQEWLph1ePAgvHUu2BzsdT+rGMZuoAe0S17wvuHKL94z72u83mzg+B4n7hvVAGzR8z0Ot/6bTWG2iqD75//AfHCivfLN/LjmSH61/2QQyyUAc4Sl/ShRr+b5w1wY7R3+M4/BVrPPfmiUQiVsrtUr6cSdSA+rUF6iEt6sOHfSvN/P3GLfIPyaGQtBQ0jwu8dP7QWmJS6mQ/yF/esJbGZ7AMQxElA9fBx9eQpHtOWZWVDftXkKqtzwstBMdS5qiun4=
Content-Type: text/plain; charset="utf-8"
Content-ID: <9BCFB4CE6664744EB6576E12EED7B0D6@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b41c8721-4be0-499a-279a-08d6de2ef024
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2019 20:57:29.6378 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: christer.holmberg@ericsson.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB3516
Archived-At: <https://mailarchive.ietf.org/arch/msg/sipcore/bMafaQlK1YTEh45VHKF5LD44ASQ>
Subject: Re: [sipcore] draft-ietf-sipcore-digest-scheme comments
X-BeenThere: sipcore@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SIP Core Working Group <sipcore.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sipcore>, <mailto:sipcore-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sipcore/>
List-Post: <mailto:sipcore@ietf.org>
List-Help: <mailto:sipcore-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sipcore>, <mailto:sipcore-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 May 2019 20:57:35 -0000

Hi,

...
 
>> Section 2.1:
>> 
>> "Note that [RFC7616] defines a -sess variant for each algorithm; the
>>   -sess variants are not used with SIP.”
>>
>> Is this already forbidden in 3261 or is this new proposed language? If so, “are not” should propably
>> be something like “MUST not”
>
> I do not think that 3261 forbids the -sess variant, and I do not see the need to forbid it here either
> So then I suggest we remove the statement that the -sess variants are not used with SIP.

If -sess variant was defined in RFC 7616, it was obviously not mentioned in RFC 3261 __

What is the difference between the session variant and the non-session variant? What is meant by "session"? RFC 7616 doesn't give any explanation, and I couldn't find anything by googling either.

I do think we need to say *something*.
 
... 

>> Section 2.4:
>>
>> "When the UAC receives a response with multiple header fields with the
>>   same realm it SHOULD use the topmost header field that it supports,
>>   unless a local policy dictates otherwise.”
>>
>> Why a SHOULD? I would prefer a MUST.
>
> I can do that, but the last part of this paragraph states that local policy can override this recommendations anyway.
> So, does it make any difference?
> Should we allow that? Why would local policy enforce a downgrade?
>
>> “When the UAC receives a 401 response with multiple WWW-Authenticate
>>   header fields with different realms it SHOULD retry and include an
>>   Authorization header field containing credentials that match the
>>   topmost header field of any one of the realms.”
>>
>> If you are disallowing multiple Authorization headers for the same realm,
>> but with different algorithms I think this should be clearly written. In my
>> view, that would be a good thing.
>
> This is allowed.
 
RFC 3261 does not say anything about using the topmost header, does it?

>> "8.  Servers MUST be able to properly handle "qop" parameter received
>>   in an authorization header field, and clients MUST be able to
>>   properly handle "qop" parameter received in WWW-Authenticate and
>>   Proxy-Authenticate header fields.  Servers MUST always send a "qop"
>>   parameter in WWW-Authenticate and Proxy-Authenticate header field
>>   values, and clients MUST send the "qop" parameter in any resulting
>>   authorization header field.”
>>
>> This is not clear. If the servers MUST always send “qop” then we
>> add that to SIP 2.0 with no backwards options or compatibility.
>> Since you write “clients MUST be able to”… it seems like you
>> assume that clients have a choise of whether they use it. I think
>> one has to be a bit more clear so developers understands how
>> to modify their implementations.
>> In addition:
>> Are we ready to require that all SIP 2.0 compliant software support QOP?
>>
>> Here is a quote form RFC3261:
>> "Use of the "qop" parameter is optional in RFC 2617 for the purposes
>> of backwards compatibility with RFC 2069; since RFC 2543 was
>> based on RFC 2069, the "qop" parameter must unfortunately
>> remain optional for clients and servers to receive."
>>
>> That is no longer the case with RFC7616.
>> Since this is a change from RFC 3261 we propably want clarify that for developers. 
>> I think that if we want to modify RFC7616 for SIP, we can. The question still
>> stands - are we ready to change the way current auth works today in SIP/2.0. There’s
>> a lot of implementations out there that will suddenly not be standard-following.
>>
>> I’m not saying it’s a bad thing, just that we have to understand the implication.

The typical way to solve this is to say that endpoints compliant with this specification must do this and that, but for backward compatibility also needs to be able to not do it.

Regards,

Christer