[stir] AD Review: draft-ietf-stir-passport-shaken-04

Adam Roach <adam@nostrum.com> Fri, 19 October 2018 23:54 UTC

Return-Path: <adam@nostrum.com>
X-Original-To: stir@ietfa.amsl.com
Delivered-To: stir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3CC2C130E17; Fri, 19 Oct 2018 16:54:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.879
X-Spam-Level:
X-Spam-Status: No, score=-1.879 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fdaWCJBbVRjh; Fri, 19 Oct 2018 16:54:07 -0700 (PDT)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AC3A41310AF; Fri, 19 Oct 2018 16:54:07 -0700 (PDT)
Received: from Svantevit.local (99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id w9JNs5Qn033994 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Fri, 19 Oct 2018 18:54:06 -0500 (CDT) (envelope-from adam@nostrum.com)
X-Authentication-Warning: raven.nostrum.com: Host 99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228] claimed to be Svantevit.local
To: draft-ietf-stir-passport-shaken@ietf.org, "stir@ietf.org" <stir@ietf.org>
From: Adam Roach <adam@nostrum.com>
Message-ID: <9237bcc9-9124-24a2-1e95-77715d309daa@nostrum.com>
Date: Fri, 19 Oct 2018 18:54:00 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/stir/HxVSCLPGfSgwFuvqLkWSVNI0PtQ>
Subject: [stir] AD Review: draft-ietf-stir-passport-shaken-04
X-BeenThere: stir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Secure Telephone Identity Revisited <stir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/stir>, <mailto:stir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/stir/>
List-Post: <mailto:stir@ietf.org>
List-Help: <mailto:stir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/stir>, <mailto:stir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Oct 2018 23:54:10 -0000

This is my AD review for draft-ietf-stir-passport-shaken-04.  I have a 
handful
of comments below that I'd like to see addressed prior to asking the IESG to
consider the document. Please treat them as you would any other last-call
comments. I have no blocking comments, and will be placing the document
in IETF last call shortly.

Thanks to everyone who worked on this document.

/a

---------------------------------------------------------------------------

Abstract:

 >  Industry Solutions) and the SIP Forum IP-NNI Joint Task Force.  These

Please expand "IP-NNI".

 >  coming from both STIR participating originating communications as

Please expand "STIR" on first use.

Also, as "STIR-participating" is a compound adjective, it needs to be
hyphenated. With the expansion, this would look like:

    coming from both SIP Telephony Identity Revisited (STIR)-participating
    originating communications as...

---------------------------------------------------------------------------

§1:

 >  The SHAKEN [ATIS-1000074] specification defines a framework for using
 >  STIR protocols including PASSporT [RFC8225], SIP Authenticated
...
 >  current telephone network contains both VoIP and TDM/SS7 originated

For the purposes of acronym expansion, the Abstract is not treated as 
part of
the document. Please expand SHAKEN, STIR, PASSporT, VoIP, TDM, and SS7 on
first use.  See 
https://www.rfc-editor.org/materials/abbrev.expansion.txt for
more details.

---------------------------------------------------------------------------

§2:

 >  The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT",
 >  "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this
 >  document are to be interpreted as described in [RFC2119].

Please update to the boilerplate in RFC 8174.

---------------------------------------------------------------------------

§3:

 >  and represents the service provider receiving a call from a non
 >  PASSporT or STI supporting telephone gateway.

Nit: "...from a non-PASSporT- and non-STI-supporting telephone gateway."

---------------------------------------------------------------------------

§4:

 >  can be one of the following three values, 'A', 'B', or 'C' as defined
 >  in [ATIS-1000074].

Nit: "...one of the following three values: 'A', 'B',..."

---------------------------------------------------------------------------

§5:

 >  opaque identifier corresponding to the service provider-initiated
 >  calls themselves,

Nit: "...service-provider-initiated calls..."

 >  documents that more precisely guide it's usage in real deployments.

Nit: "...its usage..."

---------------------------------------------------------------------------

§6:

 >     "orig":{"tn":"12155551212"},

The NANPA has reserved the range "555-0100" through "555-0199" in all area
codes for fictitious use. The number used in this example is a valid number
allocated for directory assistance use. Consider using "12155550121" (or 
some
similarly reserved number for this example. See
https://www.nationalnanpa.com/number_resource_info/555_numbers.html for more
information.

---------------------------------------------------------------------------

§7:

 >  [RFC3261] aligned with the use of the identity header defined in

Nit: "...identity header field..."