Re: [tcpm] I-D Action: draft-ietf-tcpm-dctcp-09.txt

Neal Cardwell <ncardwell@google.com> Thu, 20 July 2017 15:37 UTC

Return-Path: <ncardwell@google.com>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A978613188D for <tcpm@ietfa.amsl.com>; Thu, 20 Jul 2017 08:37:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.702
X-Spam-Level:
X-Spam-Status: No, score=-2.702 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o_4GaFv7oJWd for <tcpm@ietfa.amsl.com>; Thu, 20 Jul 2017 08:37:27 -0700 (PDT)
Received: from mail-oi0-x231.google.com (mail-oi0-x231.google.com [IPv6:2607:f8b0:4003:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6C7EC12EC46 for <tcpm@ietf.org>; Thu, 20 Jul 2017 08:37:26 -0700 (PDT)
Received: by mail-oi0-x231.google.com with SMTP id 191so29893618oii.2 for <tcpm@ietf.org>; Thu, 20 Jul 2017 08:37:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KM9V9epuemuMAdRQvlJpZgiH0xuiNbpQkMEQsMKKZuE=; b=C+yxWmTVnBHc5jqK/pNVfdSEzRpnaxKbmBQzX0waHBF4EfVA/Z/47KQvhoJkot/xqb XPI9+Icjn3leD9Vsd1WhsUURhWA5+CnmdPea+eH8B/vF4H9PfFnPT3Bt6FWrwmBidCq9 cM8dB2F91Agjb+PoOS3sCYwZ6LRqwuVHsB5ouZdsXOt8+Bl//A79pgvsEjkOJeD1vxrj cCta86r+0F+kLr4n2stmXvtrBSRu1zVmtcCVw6VzRDWxexFp2NDxhULQPAt1OK47SVdi KD8QR5gOtW48NgyZ8LG293Rkz01zF9i432gjpCBW3G6QeyfsVY7xyGHjI+JaJ6WUvTcZ 09Pg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KM9V9epuemuMAdRQvlJpZgiH0xuiNbpQkMEQsMKKZuE=; b=ISiQGrg0mFX3voCNNWQWpgT0VEzY1KlHiok66mTAYTox9tt78HBRSoHOcNdPCcxRaz UTOwxNIu5ncVt2wzBz9F7KIe+w5Ij0Yv+YfPVO3t64MfqA16vdpMN5bW0FTIdST7S2ys mIxwM2cQ0FGHoe7Wm7VT4NsQKy0/nsVY57Gb6K7WTAH0B3DJtYkc6nHG4b8uY63CXVgH e8s2VoIMoeBk7bsz3EYHWFJFb1kw3jxNa287APRDOgr0O9oR4dCMi/pQs3YenNKJVqI3 h3qavDii1RLe9VZ94535m9SMciujAxcNEtPXHOKUawr1KnApsCqVTkWkN0ARxKiaUbKu zLcg==
X-Gm-Message-State: AIVw110MO4H/81QJZXSWIwhKfE5LakUKs60UaoCr+bqcSaTXUdcRYlT8 +o2rshZp60Qc9vC0xhbqrRPDlU4eAW5N
X-Received: by 10.202.197.74 with SMTP id v71mr3189286oif.40.1500565045480; Thu, 20 Jul 2017 08:37:25 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.202.52.67 with HTTP; Thu, 20 Jul 2017 08:36:54 -0700 (PDT)
In-Reply-To: <150026900560.32439.2656659494607932107@ietfa.amsl.com>
References: <150026900560.32439.2656659494607932107@ietfa.amsl.com>
From: Neal Cardwell <ncardwell@google.com>
Date: Thu, 20 Jul 2017 11:36:54 -0400
Message-ID: <CADVnQyk5Dhi9cfmdwmabTNZdRds_ozmj2ca2SEogoVPimVEhMw@mail.gmail.com>
To: Stephen Bensley <sbens@microsoft.com>, "Eggert, Lars" <lars@netapp.com>
Cc: "tcpm@ietf.org" <tcpm@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/NGFA-JBOoAFO_egjxbDmhv46fy4>
Subject: Re: [tcpm] I-D Action: draft-ietf-tcpm-dctcp-09.txt
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Jul 2017 15:37:28 -0000

On Mon, Jul 17, 2017 at 1:23 AM,  <internet-drafts@ietf.org> wrote:
>
> A New Internet-Draft is available from the on-line Internet-Drafts directories.
> This draft is a work item of the TCP Maintenance and Minor Extensions of the IETF.
>
>         Title           : Datacenter TCP (DCTCP): TCP Congestion Control for Datacenters
>         Authors         : Stephen Bensley
>                           Dave Thaler
>                           Praveen Balasubramanian
>                           Lars Eggert
>                           Glenn Judd
>         Filename        : draft-ietf-tcpm-dctcp-09.txt
>         Pages           : 16
>         Date            : 2017-07-16
...
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-tcpm-dctcp-09

I would like to re-raise an issue I raised in Nov 2016:
 https://www.ietf.org/mail-archive/web/tcpm/current/msg10632.html
There I did not get a response, but I think it's an issue worth
at least a sentence in the draft...

This is a nice draft. One quick thought on a minor point:
I couldn't find a passage in the draft about how cwnd is increased.
I didn't see a mention of the word "increase",
or slow start, or congestion avoidance, or a reference to DCTCP
inheriting RFC5681 behavior for cwnd increase.

The SIGCOMM 2010 paper is clear on this point: "The only difference
between a DCTCP sender and a TCP sender is in how each reacts to
receiving an ACK with the ECN-Echo flag set. Other features of TCP
such as slow start, additive increase in congestion avoidance, or
recovery from packet lost are left unchanged."

And the Linux DCTCP code is clear as well, since it uses
tcp_reno_cong_avoid(), meaning it inherits the standard Reno behavior
of slow start and congestion avoidance.

So I presume the intent of the IETF DCTCP would be the same
as the SIGCOMM 2010 DCTCP paper and Linux DCTCP code,
which is to say cwnd increase would be like Reno/RFC5681.

But IMHO it would be useful for the draft to have explicit language to
this effect as well. Particularly since now there are IETF documents
for both Reno and CUBIC, and the details of the DCTCP cwnd
decrease algorithm may or may not depend on the
Reno-style increase.

Apologies if I just missed this discussion.

cheers,
neal