[tcpm] Review of draft-ietf-tcpm-prr-rfc6937bis-08
Martin Duke <martin.h.duke@gmail.com> Fri, 29 March 2024 17:33 UTC
Return-Path: <martin.h.duke@gmail.com>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9D71CC14F681; Fri, 29 Mar 2024 10:33:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.097
X-Spam-Level:
X-Spam-Status: No, score=-7.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9SJIuX_0DqqO; Fri, 29 Mar 2024 10:33:01 -0700 (PDT)
Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 289E4C14E513; Fri, 29 Mar 2024 10:32:58 -0700 (PDT)
Received: by mail-oi1-x22e.google.com with SMTP id 5614622812f47-3c3e67fd552so1058873b6e.3; Fri, 29 Mar 2024 10:32:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711733576; x=1712338376; darn=ietf.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=a82LVV5NUI1c0ZUqZndTuy+nZUHR6YiJvgo3phwvz1U=; b=iJVabeFwU/vPHu4U/UMoLyK7YIONhdZU4kOrALkbVYH/6xRkkjbAO+SWdMLeuPoyto 0mMzJ2NvwC0nOVgR8vkbyjGisFVfKzdj0bqZU0Ehv9KGwVh4UmQOHKrL2777rA1Vpti/ 2giYkyZig44j5En5O3e3pdPGKNbgwlFFvhT3WfMWA72Ot8Pu061PIe3cJkrZ+E3Xeh6y 6efarMosjKUTXFebc8y/ifSfgQjA+n5pzNwEH6FPK3jMyWcsH1mBMjx3WQstK6xC7jcC K3o50HOOfV90jg19YcrZGSva7GABNP96wRCp1WkLeW1jchmXnm3lx2ot/ohtWJ/XNsjn ting==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711733576; x=1712338376; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=a82LVV5NUI1c0ZUqZndTuy+nZUHR6YiJvgo3phwvz1U=; b=RmyzJrPatxj/9ibkIkqzOmVrqUEBYIVmjV2D1h6Cy9K2jSP7q9VCu29foFc9gb17hH IrGvLNGXTQ+uzrcxJVFwlvfBeysx+jgTN2tayg3xFMCd0s7yth1dK85spsw9nr+6+BFV WvjBMb2vnHPdy45g6gIXl7T1u5u6vfirX0grWOR6wHPeCJ34KV1rxbOAbxXqVWSQuSFo gQS+EPr1CuRg4zBE4QHtXCO1RWpbq5EuDtoJVSiykiNiYPCe4jqvhmOdrOinWTv65cDm GYqXYAmIGh3PL6Tqbz+4C+rDy94B/ptrE+97OEUvT23WXZb6q9+sNnkoss7oyWV4PNcd 8zYQ==
X-Forwarded-Encrypted: i=1; AJvYcCVqSm63Q29k+IqkOc94wvegGH3STbo3BkYOpI9wh6TtW6ha5WxIwzZYhauhDOEI4mpI1ypG5qqcUq3FWoddnKjn4xtdv+nHByhjy8hBQycmq28iuI71/3TR539A
X-Gm-Message-State: AOJu0YwAZuCoSyaJuILdCwMUk/vnVbXeXSNx1axNPTbGSFIa6uHGJ9r8 vpw2dlEDDCpUTZz9SwXFXcZ36uo7yIxVSxDrAX8aEi6LuE5YJDkgxCTUS9yYZxTY4FxuYYiTGf5 00sVvU/3NNE+CxksRFAiqp9RueraU6Rpv
X-Google-Smtp-Source: AGHT+IE+Wkjzki+qb3Bec/ZAiHMhbnEtIp3jI0kcc/N0H7HubnjPGBnzgVtXbZk/jNQT6SzTNCfZtMEhf79sGPBVccc=
X-Received: by 2002:a05:6808:15aa:b0:3c3:d74a:498 with SMTP id t42-20020a05680815aa00b003c3d74a0498mr3149402oiw.44.1711733576544; Fri, 29 Mar 2024 10:32:56 -0700 (PDT)
MIME-Version: 1.0
From: Martin Duke <martin.h.duke@gmail.com>
Date: Fri, 29 Mar 2024 10:32:43 -0700
Message-ID: <CAM4esxQJdi8oVOs0KkgpAkCnPtE+F8_m=mesPQSrtr9iucYWUw@mail.gmail.com>
To: "tcpm@ietf.org Extensions" <tcpm@ietf.org>, draft-ietf-tcpm-prr-rfc6937bis.all@ietf.org
Content-Type: multipart/alternative; boundary="000000000000c7b9010614d00789"
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/_U50YThjOezOaszM_Ax77B11rYA>
Subject: [tcpm] Review of draft-ietf-tcpm-prr-rfc6937bis-08
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Mar 2024 17:33:01 -0000
As responsible AD, I generally didn't read drafts before my AD evaluation. So I'm catching up on ones I would have ready as an individual. I have read the draft and believe it is ready for publication. It makes the proposed solution seem pretty obvious, which is a sign of good writing. In spite of not remembering much about PRR, I was able to follow the spec pretty easily. One nit: It might be useful to define the CEIL() function used in the pseudocode. Presumably this is a "round up to MSS" function. Martin