Re: [tcpm] WGLC comments for draft-ietf-tcpm-dctcp-04

Praveen Balasubramanian <pravb@microsoft.com> Thu, 16 March 2017 18:30 UTC

Return-Path: <pravb@microsoft.com>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5C6831297CD; Thu, 16 Mar 2017 11:30:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.012
X-Spam-Level:
X-Spam-Status: No, score=-3.012 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=microsoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RR23NrWT4iJj; Thu, 16 Mar 2017 11:30:17 -0700 (PDT)
Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0135.outbound.protection.outlook.com [104.47.37.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E345A1297E6; Thu, 16 Mar 2017 11:30:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jK6XtJYyHwKxFX+XnVZsm7k7alpfXNO+B99TDtvWCMU=; b=EPgPFRXpbOdyZh8Tey5rUfB4Lv1ZImI1mef44uv4HKqHqsC92wcI4hu5ISevfTOKx0YZsz4Lad27lQLtKz7M4JEePMQhGbyR1hmZoQh9zIbVNuJp+cC6tZ6BmoTds6iMp1ZIAWHfl7RnZ/mWVKZJDvE5hiQDCrraT+MvV8NQl/0=
Received: from CY4PR21MB0277.namprd21.prod.outlook.com (10.173.193.143) by CY4PR21MB0279.namprd21.prod.outlook.com (10.173.193.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.991.0; Thu, 16 Mar 2017 18:30:15 +0000
Received: from CY4PR21MB0277.namprd21.prod.outlook.com ([10.173.193.143]) by CY4PR21MB0277.namprd21.prod.outlook.com ([10.173.193.143]) with mapi id 15.01.0991.007; Thu, 16 Mar 2017 18:30:15 +0000
From: Praveen Balasubramanian <pravb@microsoft.com>
To: "gorry@erg.abdn.ac.uk" <gorry@erg.abdn.ac.uk>
CC: "tcpm@ietf.org" <tcpm@ietf.org>, "draft-ietf-tcpm-dctcp@ietf.org" <draft-ietf-tcpm-dctcp@ietf.org>
Thread-Topic: WGLC comments for draft-ietf-tcpm-dctcp-04
Thread-Index: AQHSm9+CcGtvXn3gd0aQAvDPuOHIZKGWlixQgACZ14CAAJ5EAA==
Date: Thu, 16 Mar 2017 18:30:15 +0000
Message-ID: <CY4PR21MB0277226072E5425C8947726BB6260@CY4PR21MB0277.namprd21.prod.outlook.com>
References: <58C66BB3.1000003@erg.abdn.ac.uk> <CY4PR21MB027775A417785976A70C6B11B6260@CY4PR21MB0277.namprd21.prod.outlook.com> <58CA5461.9010108@erg.abdn.ac.uk>
In-Reply-To: <58CA5461.9010108@erg.abdn.ac.uk>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: erg.abdn.ac.uk; dkim=none (message not signed) header.d=none;erg.abdn.ac.uk; dmarc=none action=none header.from=microsoft.com;
x-originating-ip: [2001:4898:80e8:f::584]
x-microsoft-exchange-diagnostics: 1; CY4PR21MB0279; 7:heeOyxWemsT8EotyljRHJXolH+mUCutwdszb+xCLpxnAXA+ekr5dypHWIh9LE5+b36yRMB3ZRaWSz28w1BW5+vLTr0d6zjCt4xU9rztR1k6CIvxCBOBYv9qIA3Kqa3sD9Vn/RRwilkG+KqxLMQMFNH+vgLHKJ1d7QxrZSbKA4zw0BVKS8gCq4dCvKAwusH9wLZqEOhPipX1aeZOvDLzYlHE2h6Q2Yls4D3DztqVN0q6FgsxkLzRNOY1gqFdm1AnLcucHV2q2Xs1w60DYaXIlzCmlHUtK+kpWG1lMGW5BIxPr6PYrGuWuS2rieWqKFr2/8dFWTyptnjWjqNlB67g6IZAGhSfbfYvZZW/lbrLUwIs=
x-ms-office365-filtering-correlation-id: 3f16759e-663b-48d7-2365-08d46c9a7dad
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254036)(48565401081); SRVR:CY4PR21MB0279;
x-microsoft-antispam-prvs: <CY4PR21MB0279E7E481BBA46F5C6AA318B6260@CY4PR21MB0279.namprd21.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:;
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425038)(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041248)(20161123564025)(20161123555025)(20161123560025)(20161123558025)(20161123562025)(6072148); SRVR:CY4PR21MB0279; BCL:0; PCL:0; RULEID:; SRVR:CY4PR21MB0279;
x-forefront-prvs: 024847EE92
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(39860400002)(39840400002)(39450400003)(377454003)(13464003)(24454002)(54094003)(2501003)(5660300001)(230783001)(3660700001)(7696004)(3280700002)(2351001)(5005710100001)(10290500002)(50986999)(229853002)(2900100001)(86362001)(77096006)(2906002)(6506006)(10090500001)(6916009)(2950100002)(6436002)(102836003)(6116002)(53936002)(4326008)(33656002)(6246003)(5640700003)(55016002)(99286003)(25786008)(305945005)(54906002)(76176999)(54356999)(9686003)(38730400002)(110136004)(74316002)(53546007)(189998001)(1730700003)(8676002)(8936002)(122556002)(81166006)(7736002); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR21MB0279; H:CY4PR21MB0277.namprd21.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en;
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2017 18:30:15.3172 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0279
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/xuLrohvZepfWt08IFgqFOPUnDF8>
Subject: Re: [tcpm] WGLC comments for draft-ietf-tcpm-dctcp-04
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Mar 2017 18:30:19 -0000

It is pretty clear that all the considerations are for ACK packet loss:

" However, if one or more ACK packets are dropped, it is possible that a subsequent ACK will cumulatively acknowledge
      a mix of CE and non-CE segments. This will, of course, result in a less accurate congestion estimate. There are some potential considerations:"

The fact that CE is being set also implies this is a response packet. 

"If packet loss mostly occurs under heavy congestion, most drops will occur during an unbroken string of CE packets,
          and the estimate will be unaffected."

I wasn't sure this needed further qualification but I don't see the harm adding ACK to qualify the packet loss, so fixed.

-----Original Message-----
From: Gorry Fairhurst [mailto:gorry@erg.abdn.ac.uk] 
Sent: Thursday, March 16, 2017 2:01 AM
To: Praveen Balasubramanian <pravb@microsoft.com>
Cc: tcpm@ietf.org; draft-ietf-tcpm-dctcp@ietf.org
Subject: Re: WGLC comments for draft-ietf-tcpm-dctcp-04

I wonder if the following could be easily also resolved, see suggestion below.

On 16/03/2017, 02:52, Praveen Balasubramanian wrote:
> In section 6:
>
> This statement could be better written:
>
> "If the estimation gain is small relative to the packet loss rate, the estimate may not be too inaccurate."
>
> - First, I think the loss rate noted, may be the loss rate for the 
> return path (i.e., the opposite direction to the packets bing 
> CE-marked?)
> - Second, may not be too inacurrate sounds odd - do you think the accuracy is acceptable for normal use?
>
> If this relates to ACK loss, the following statement isn't necessarily true. And especially wculd be far from true for an internet with asymmetric routing:
>
> "o  If packet loss mostly occurs under heavy congestion, most drops
>         will occur during an unbroken string of CE packets, and the
>         estimate will be unaffected.
> "
>
>>> >>  Yes these considerations are for the case where ACKs are lost reducing the accuracy of Alpha. The further sentence says that the impact of such loss has not been measured so its hard for me to say whether it will be "acceptable for normal use". Also, none of this applies to the internet and AFAIK routing is symmetric in the datacenter. I propose that we leave this text as is.
- Is it worth inserting "ACK" in the following, to disambiguate packet loss from ACK loss.

    "o  If ACK packet loss mostly occurs under heavy congestion, most drops
        will occur during an unbroken string of CE packets, and the
        estimate will be unaffected.

Gorry