Re: [Teas] Genart last call review of draft-ietf-teas-sr-rsvp-coexistence-rec-02

"Joel M. Halpern" <jmh@joelhalpern.com> Fri, 20 April 2018 18:25 UTC

Return-Path: <jmh@joelhalpern.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7808812D86A; Fri, 20 Apr 2018 11:25:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=joelhalpern.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 22MppfJLzT70; Fri, 20 Apr 2018 11:25:06 -0700 (PDT)
Received: from mailb2.tigertech.net (mailb2.tigertech.net [208.80.4.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 99D38127863; Fri, 20 Apr 2018 11:25:06 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mailb2.tigertech.net (Postfix) with ESMTP id 7DBB76403A3; Fri, 20 Apr 2018 11:25:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelhalpern.com; s=2.tigertech; t=1524248706; bh=lrzaD7/BJHMVd3AiF1wDEBIFSyOWBAFuav+eV+s0+xA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=RpvbS1Bc4v5saTA/jpwj9EJVJEPA4YgXawuBTYckVtNvLnZqFl8utuGDW8B5PGE3J ARVKsC2fOFjTcZfb4RGAki2YXn14odcIRpvgYmjwJ9AMNBmWegb+m54eYuuILROYUf zUsSUOx0Xe/1VQ+2/ij8RQj1bxMwDq8MIUAktE+U=
X-Virus-Scanned: Debian amavisd-new at b2.tigertech.net
Received: from Joels-MacBook-Pro.local (static-212-247-252-138.cust.tele2.se [212.247.252.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailb2.tigertech.net (Postfix) with ESMTPSA id 0DCA41C0C2B; Fri, 20 Apr 2018 11:25:04 -0700 (PDT)
To: Harish Sitaraman <hsitaraman@juniper.net>, "gen-art@ietf.org" <gen-art@ietf.org>
Cc: "ietf@ietf.org" <ietf@ietf.org>, "teas@ietf.org" <teas@ietf.org>, "draft-ietf-teas-sr-rsvp-coexistence-rec.all@ietf.org" <draft-ietf-teas-sr-rsvp-coexistence-rec.all@ietf.org>
References: <152413294572.28724.1279477772622511232@ietfa.amsl.com> <AD259E57-5FE2-4307-B19E-F8F2D48EB8D2@juniper.net>
From: "Joel M. Halpern" <jmh@joelhalpern.com>
Message-ID: <dcd5d930-82f0-9458-139d-6c1bc882ae6b@joelhalpern.com>
Date: Fri, 20 Apr 2018 14:25:02 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <AD259E57-5FE2-4307-B19E-F8F2D48EB8D2@juniper.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/4nlIeA_GCuU4eRrDZtAHlXPv0n0>
Subject: Re: [Teas] Genart last call review of draft-ietf-teas-sr-rsvp-coexistence-rec-02
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Apr 2018 18:25:08 -0000

Thank you for your replies.  Further in line, marked <jmh></jmh>
Yours,
Joel

On 4/20/18 1:36 PM, Harish Sitaraman wrote:
> 
> Hi Joel,
> 
> Thanks for the review comments. Comments are inline with [HS].
> 
> ´╗┐On 4/19/18, 3:15 AM, "Joel Halpern" <jmh@joelhalpern.com>; wrote:
>     
>      Summary:
>      
>      Major issues:
>          The focus of the draft seems to be the recommendation in section 3.5 that
>          the maximum reservable bandwidth on a link be adjusted to reflect the SR
>          traffic consumption.  There appear to be two issues that need to be
>          discussed, both related to the difference between what the SR controller
>          wants to reserve and what the router observes. First, an SR controller may
>          be performing calculations without requiring that bandwidth be committed to
>          the traffic.  The recommendation here assumes that all traffic using SR is
>          high priority.  It may suffice to note that QoS markings in the labels
>          (corresponding to diffserv markings in the underlying packet may hel with
>          this.  Given the range of allowed behaviors in when RSVP-TE and SR are
>          separate, it may also be necessary to restrict what the SR controllers do
>          in these interworking cases.
> 
> [HS] In the first paragraph of section 3.5, there is text referring to SR having highest preemption priority but the SR traffic could have different QoS markings i.e. within SR there could be different classes of traffic which is accordingly handled by the forwarding plane (e.g. defined operator policy).

<jmh>I think the document would be helped if this were described more 
explicitly.  </jmh>

> 
>          Second, and more importantly, this solution
>          assumes that short term traffic measurements are a good proxy for intended
>          reservation.  Even assuming edge policing so that usage is less than or
>          equal to the reservation, this will frequently underestimate the traffic
>          reservation.  Such underestimates would seem to be able to cause
>          significant problems.
> 
> [HS] Even with RSVP-TE LSPs where explicit admission-control is done to reserve bandwidth, the bandwidth that is reserved on the RSVP-TE LSP may differ from how much traffic actually arrives on the LSP (assuming no edge policing). As the traffic changes, auto-bandwidth implementation procedures might be there to adjust the LSP reservation at periodic intervals. This relies on short term LSP traffic measurement to achieve change in reservation.

<jmh>A reference or two to other work on auto-reservation of bandwidth 
based on measurement, particularly for RSVP-TE, would help the reader 
understand the assumptions that lead to this being seen as workable.  It 
would likely also help the reader know about any relevant limitations.</jmh>

> 
> [HS] SR traffic can preempt RSVP LSPs to make room for itself based on short term SR traffic measurement. The frequency at which SR statistics is collected for a TE interface and how often the Maximum-Reservable-Bandwidth is adjusted so that path computation engines for RSVP-TE LSPs get the updated TED information is implementation and deployment dependent (it could be aggressive to reflect SR traffic utilization in the TED often or done less frequently due to other deployment parameters). In the penultimate paragraph of section 3.5, there is text referring to the implementation choice.

<jmh>The point of reservations is to try to anticipate future 
conditions.  The fact that SR can preempt RSVP-TE is useful, but does 
not really address the question.  If it could, then a simpler 
recommendation would be to observe how much RSVP-TE trafic had to be 
dropped, and redirect that much traffic elsewhere. </jmh>

>      
>      Minor issues:
>          Section 3.5 assumes that the router can measure the traffic using SR.  This
>          seems to rely on the unstated premise that the measurement is conditioned
>          by the recognition of which labels are being used for SR.  This is
>          reasonable.  It should be stated.
> 
> [HS] Fair point. However, the measured traffic is not just from SR labels (transit traffic) but also any traffic entering the SR domain over that outgoing interface. An implementation should be capable of measuring all the SR traffic going out of an interface. The text generically refers to needing ability to measure SR traffic statistics across the TE interface.

<jmh>My point is that it would help the reader if the text were explicit 
about what traffic needs to be recognized and how it is recognized. </jmh>

>      
>      Nits/editorial comments:
>          The second paragraph of the introduction seems to have the opening text
>          repeated twice.
> 
> [HS] Thanks - noted also as part of OPsDir review comments. The 2nd repeated sentence will be removed.
>      
>          The third paragraph of section 3.1 seems to be a repetition of the end of
>          the second paragraph using slightly different words.
> 
> [HS] Ok, the aim was to offer a summary of the behavior separately so that its clear. If its ok, we can retain it.

<jmh>If the duplication is intentional, then it is up to you as to 
whether it is doing what you want. </jmh>

> 
> --
> Harish
>      
>