Re: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03

"Tarek Saad (tsaad)" <tsaad@cisco.com> Thu, 31 January 2019 14:10 UTC

Return-Path: <tsaad@cisco.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E2836128CB7; Thu, 31 Jan 2019 06:10:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -19.054
X-Spam-Level:
X-Spam-Status: No, score=-19.054 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5Fsxjtr6K1UI; Thu, 31 Jan 2019 06:10:44 -0800 (PST)
Received: from alln-iport-8.cisco.com (alln-iport-8.cisco.com [173.37.142.95]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4B6EE1274D0; Thu, 31 Jan 2019 06:10:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4574; q=dns/txt; s=iport; t=1548943844; x=1550153444; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=zXuK3cnZfbS+zuKoOuwx8w/6hMwgPRK38EM8gO3WJ4A=; b=eudwV/MQVi07EoMxFQfldNq8rhU73nE7iSFcNXbPcJ4C+pO5WZv0Kq7L WW+OHGZS2lR32K5OwqUrntXdQkIv+VOZ48RAqPLZc/tUi6iztBdLAbekX z7cerjUOx0wkBPcC2b0ULnLUZXlSvroZm0Rz6ad7lDgl+muOjIYMWnKpO 0=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ADAACdAFNc/5ldJa1jGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUQQBAQEBAQsBggOBaicKg3mIGotzgg2YDhSBZwsBAYR?= =?us-ascii?q?sAheCdyI0CQ0BAwEBAgEBAm0ohUoBAQEBAyMRRQwEAgEIEQMBAQEDAiYCAgI?= =?us-ascii?q?wFQgIAgQBDQWDIoICrDmBL4oxgQuLNReBQD+BEScfgh4uhGkYF4JyMYIEIgK?= =?us-ascii?q?QJpFkVwkCiw2HJhmSPYogkS4CERSBJx84gVZwFTsqAYJBkFxBMY5tgR8BAQ?=
X-IronPort-AV: E=Sophos;i="5.56,544,1539648000"; d="scan'208";a="233452475"
Received: from rcdn-core-2.cisco.com ([173.37.93.153]) by alln-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2019 14:10:41 +0000
Received: from XCH-RTP-005.cisco.com (xch-rtp-005.cisco.com [64.101.220.145]) by rcdn-core-2.cisco.com (8.15.2/8.15.2) with ESMTPS id x0VEAfq7005397 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 31 Jan 2019 14:10:41 GMT
Received: from xch-rtp-001.cisco.com (64.101.220.141) by XCH-RTP-005.cisco.com (64.101.220.145) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 31 Jan 2019 09:10:40 -0500
Received: from xch-rtp-001.cisco.com ([64.101.220.141]) by XCH-RTP-001.cisco.com ([64.101.220.141]) with mapi id 15.00.1395.000; Thu, 31 Jan 2019 09:10:40 -0500
From: "Tarek Saad (tsaad)" <tsaad@cisco.com>
To: tom petch <ietfa@btconnect.com>, Jan Lindblad <janl@tail-f.com>
CC: "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "draft-ietf-teas-yang-te-types.all@ietf.org" <draft-ietf-teas-yang-te-types.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "teas@ietf.org" <teas@ietf.org>
Thread-Topic: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03
Thread-Index: AQHUsz7qhRxUpP0qbkyLe9M1xeeg7qXJdvsA
Date: Thu, 31 Jan 2019 14:10:40 +0000
Message-ID: <B9068E7A-9D15-4F77-A9BF-3B25092DC1CC@cisco.com>
References: <154090780735.15255.3911131220920609603@ietfa.amsl.com> <973699DE-882E-4531-A7D5-32AFEF4359E7@cisco.com> <6CC3CA10-0768-4C99-9237-30A78E1EC3DA@tail-f.com> <BB36593B-0A4E-4F88-A088-3C35BBCAB902@cisco.com> <39E705F8-EE93-4F16-AD3A-39B2E6FCC37E@tail-f.com> <00bc01d4b33e$c42e4d20$4001a8c0@gateway.2wire.net>
In-Reply-To: <00bc01d4b33e$c42e4d20$4001a8c0@gateway.2wire.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.14.0.181208
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.61.68.228]
Content-Type: text/plain; charset="utf-8"
Content-ID: <0B46FBEA208F3D429FAD5888B7477035@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Outbound-SMTP-Client: 64.101.220.145, xch-rtp-005.cisco.com
X-Outbound-Node: rcdn-core-2.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/d4-4Na_Y9Dad15vQGIiAJ4uyuSs>
Subject: Re: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Jan 2019 14:10:46 -0000

Hi Tom,

Thank again for your review comments below. We've uploaded version 04/-05 which attempts to address these comments. 
See inline [TS] for resolution.

-----Original Message-----
From: tom petch <ietfa@btconnect.com>;
Date: Wednesday, January 23, 2019 at 12:13 PM
To: Jan Lindblad <janl@tail-f.com>;, Tarek Saad <tsaad@cisco.com>;
Cc: "yang-doctors@ietf.org"; <yang-doctors@ietf.org>;, "draft-ietf-teas-yang-te-types.all@ietf.org"; <draft-ietf-teas-yang-te-types.all@ietf.org>;, "ietf@ietf.org"; <ietf@ietf.org>;, "teas@ietf.org"; <teas@ietf.org>;
Subject: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03

    Tarek
    
    The YANG modules have lots of references - good - but they are not in
    the I-D references - not good.
    
    My list is
    
    3272
    4202
    4328
    4657
    5817
    6004
    6205
    6511
    7139
    7308
    7551
    7571
    7579
    7951
    G.808
    G.8031
    G.8131
    G.873.1

[TS]: thanks. I've added the missing references and they should show in the I-D references now.
    
    s.3.1 I would find more usable if the types were in an order I could
    recognise, such as alphabetical

[TS]: OK, I tried an attempt to sort the typedefs alphabetically.
    
      import ietf-routing-types { prefix "rt-types";
    reference "RFC6991: Common YANG Data Types";
    perhaps RFC8294 is intended

[TS]: corrected to RFC8294

    "   defined in ietf-network.yang, to help user to understand ""
    might benefit from a reference - is this
    draft-ietf-i2rs-yang-network-topo?

[TS]: added reference RFC8345.
    
    /"Then index of the label/ "The index of the label /

[TS]: fixed typo.    

              container tiebreakers {
                description
                  "The list of tiebreaker criterion to apply
                   on an equally favored set of paths to pick best";
                list tiebreaker {
                  description
                  "The list of tiebreaker criterion to apply
                     on an equally favored set of paths to pick best";
    One description is perhaps enough

[TS]: removed/updated redundant description.
    
    uses path-objective-function_config;
    using _ is not wrong but is discouraged, mixing _ with - in a label more
    so

[TS]: OK, we have moved away from using "_" in the naming.
    
    /This document registers a YANG module/
    This document registers two YANG modules/

[TS]: fixed typo.
    
       name: ietf-te-types namespace: urn:ietf:params:xml:ns:yang:ietf-te-
       types prefix: ietf-te-types reference: RFC3209
       name: ietf-te-packet-types namespace:
       urn:ietf:params:xml:ns:yang:ietf-te-packet-types prefix: ietf-te-
       packet-types reference: RFC3209
    
    Perhaps /3209/XXXX/

[TS]: fixed.
    
Regards,
Tarek

    Tom Petch
    
    ----- Original Message -----
    From: "Jan Lindblad" <janl@tail-f.com>;
    To: "Tarek Saad (tsaad)" <tsaad@cisco.com>;
    Cc: <yang-doctors@ietf.org>;;
    <draft-ietf-teas-yang-te-types.all@ietf.org>;; <ietf@ietf.org>;;
    <teas@ietf.org>;
    Sent: Monday, January 21, 2019 10:10 AM
    Subject: Re: [Teas] Yangdoctors early review of
    draft-ietf-teas-yang-te-types-03 (was -01)
    
    
    >