[Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03

tom petch <ietfa@btconnect.com> Wed, 23 January 2019 17:13 UTC

Return-Path: <ietfa@btconnect.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F1CDC130EBF; Wed, 23 Jan 2019 09:13:11 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.105
X-Spam-Level:
X-Spam-Status: No, score=0.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.142, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RATWARE_MS_HASH=2.148, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2_HNIU8b3eYU; Wed, 23 Jan 2019 09:13:05 -0800 (PST)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50137.outbound.protection.outlook.com [40.107.5.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C1878130ED4; Wed, 23 Jan 2019 09:13:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector1-btconnect-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x/Mq5gHpFXbpt7/qjAUCRnkWzdEACGErDLrT0k2Wm+I=; b=TVa526/Nl7dwVdwQWbJoRQKuwxbnOPHa0axhl0h3iqNNe58c1KRd8FfbYO9tJB38AROkYrurQnmoYrNlqCYnv/EihJk+nldvh4cT6o8J2z9qntcWvGHoq/wRFS/YxzR1RXTQTojcOy7CzN+7q/aLYjvqyuvDyhwECB3ZJ+VKOeI=
Received: from AM0PR07MB5203.eurprd07.prod.outlook.com (20.178.19.156) by AM0PR07MB5460.eurprd07.prod.outlook.com (20.178.22.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.12; Wed, 23 Jan 2019 17:13:02 +0000
Received: from AM0PR07MB5203.eurprd07.prod.outlook.com ([fe80::70d9:5570:355a:d62f]) by AM0PR07MB5203.eurprd07.prod.outlook.com ([fe80::70d9:5570:355a:d62f%4]) with mapi id 15.20.1558.016; Wed, 23 Jan 2019 17:13:02 +0000
From: tom petch <ietfa@btconnect.com>
To: Jan Lindblad <janl@tail-f.com>, "Tarek Saad (tsaad)" <tsaad@cisco.com>
CC: "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "draft-ietf-teas-yang-te-types.all@ietf.org" <draft-ietf-teas-yang-te-types.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "teas@ietf.org" <teas@ietf.org>
Thread-Topic: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03
Thread-Index: AQHUsz7lJhclQK6K6kmMA6C0eS0JwA==
Date: Wed, 23 Jan 2019 17:13:02 +0000
Message-ID: <00bc01d4b33e$c42e4d20$4001a8c0@gateway.2wire.net>
References: <154090780735.15255.3911131220920609603@ietfa.amsl.com> <973699DE-882E-4531-A7D5-32AFEF4359E7@cisco.com> <6CC3CA10-0768-4C99-9237-30A78E1EC3DA@tail-f.com> <BB36593B-0A4E-4F88-A088-3C35BBCAB902@cisco.com> <39E705F8-EE93-4F16-AD3A-39B2E6FCC37E@tail-f.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-clientproxiedby: LO2P265CA0020.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::32) To AM0PR07MB5203.eurprd07.prod.outlook.com (2603:10a6:208:f5::28)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ietfa@btconnect.com;
x-ms-exchange-messagesentrepresentingtype: 1
x-mailer: Microsoft Outlook Express 6.00.2800.1106
x-originating-ip: [86.139.215.184]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; AM0PR07MB5460; 6:0ZY6SScB7X1B8I3G1MpT+vjwj7k77rWQSDTZ+LlrkVdu1wRp3a3MIFm5vN/8CTexS5uySzqD3Tmqz3k5tEHkoupDFrgTGoTLvvwwO5zHXo84HG1tvRnNGQPJBXkmyStbpLiDX8mND6I5nAxp0iLrNTM7884fYor7w2kEkn7bs4tRhhzqgtJXESVp5/TyGYm+EMpsPOXiBzyltsfZ3AZPvlpopokG62jFQFER3nChAK6eCBHk03bgeHHN82AL9d2L0MeWK5lMTTyVkufKPoydaCDxg799cb6zs+TaYfs/fzOXCS7XSx4LfS4/K74Rea1H0aEtObxxz5O9jADv2PE8KrUI6bvqC+7c2ZNyp3uKHU5AaY7YIV0Wx9ejTHGleWM2kIcCjW8I6DWi47nRrdQ8Zoia/uBu+zpUJP049TFLpJVU7m+UAX+iQxfiUGVQ+WXsFFIhH2mGd3YpdG1hpV/XaQ==; 5:naZbdmuC3B5mxxen/z2K4+s6hhQw8lAlfc+jS+h3eL7z5mNcma8i12zhHzYJpzCcNMxYuKfioHeDZp9G/AmicYSrbMMpr862bfWHkWNICKgWpLi//P3QOWg3S450VJHx/tfNj3pjQZX4lBo80nqoGiuxYfXqc73duvsjIg4UGuhFQXobhN1y2BA/qOSFM8rXWtplXWA5fPUtIdixV0GYEg==; 7:QQmDhFWTOPqWfZhbsk5UEX2HeAdZbVfL/PUYQ9AAY8GsiFhzzMvSZiyf4A7FLwlandXrFOD+XP2TReznjZyzU9PA6EDK0d063cdUi7FDt3rDnjCTSrb/pSlc49kC1IZvXjhRgKNXVJVbZkV1+STuhA==
x-ms-office365-filtering-correlation-id: b6eb7aef-1f06-46c3-03d3-08d681560802
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600110)(711020)(4605077)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM0PR07MB5460;
x-ms-traffictypediagnostic: AM0PR07MB5460:
x-microsoft-antispam-prvs: <AM0PR07MB5460192B0F3BDCA2A13AB4F1A2990@AM0PR07MB5460.eurprd07.prod.outlook.com>
x-forefront-prvs: 0926B0E013
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(396003)(376002)(366004)(39860400002)(346002)(199004)(189003)(13464003)(476003)(3846002)(52116002)(99286004)(8936002)(25786009)(305945005)(6506007)(446003)(386003)(6512007)(9686003)(486006)(71200400001)(81156014)(81166006)(71190400001)(4326008)(81816011)(7736002)(1556002)(44716002)(86362001)(2906002)(62236002)(186003)(53936002)(6116002)(316002)(102836004)(26005)(44736005)(6486002)(81686011)(84392002)(14454004)(478600001)(50226002)(6436002)(86152003)(93886005)(97736004)(256004)(14444005)(110136005)(54906003)(4720700003)(68736007)(106356001)(105586002)(61296003)(8676002)(33896004)(14496001)(66066001)(76176011)(74416001)(7726001); DIR:OUT; SFP:1102; SCL:1; SRVR:AM0PR07MB5460; H:AM0PR07MB5203.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:1;
received-spf: None (protection.outlook.com: btconnect.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 4oPeh2UTQcVsy0Xab+raGECdyHgjgskTf0tmd0o1SDFdWSu/fZsDzI8SmjnueOWeSa7b9H7bWq2Wth5dociSSgcQpqHIH7HgWlSBe/QX4e+R1NGsr0xn7AT9ha5yfJSlD1f0IQ1C3jh9XdN277WDD2tfiQdHIVfeQOYQPXM50oGpYMz27pmALkdZHkzHaI20we4l2SCNWfidbAzoTwe3fBCPeNGMGHuZZadbDgusJVU3IBVe7p0e6ipnVtejBLYSDG1vN40Hb7WZrP7F/MGrBNUdXTtydyxtP8kC4LYm7dldBKSO9V7IYPfC04r9ipiKDU4YpFcwPbbq2jpFQaUY7XCbh87QqFlJ7ip3vtNgWraYdPjTemV8G6lfvosl3/wkeuwom38RkLWAoz4HqXXBtIKSdeHBilq3oDfoctRmF/4=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-ID: <B33A7CE4C2CE2F48A415D976A032156E@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b6eb7aef-1f06-46c3-03d3-08d681560802
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2019 17:13:01.7111 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR07MB5460
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/wUiqW4-OdIg5x6qtbXBN80XaRsw>
Subject: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jan 2019 17:13:12 -0000

Tarek

The YANG modules have lots of references - good - but they are not in
the I-D references - not good.

My list is

3272
4202
4328
4657
5817
6004
6205
6511
7139
7308
7551
7571
7579
7951
G.808
G.8031
G.8131
G.873.1

s.3.1 I would find more usable if the types were in an order I could
recognise, such as alphabetical

  import ietf-routing-types { prefix "rt-types";
reference "RFC6991: Common YANG Data Types";
perhaps RFC8294 is intended

"   defined in ietf-network.yang, to help user to understand ""
might benefit from a reference - is this
draft-ietf-i2rs-yang-network-topo?

/"Then index of the label/ "The index of the label /

          container tiebreakers {
            description
              "The list of tiebreaker criterion to apply
               on an equally favored set of paths to pick best";
            list tiebreaker {
              description
              "The list of tiebreaker criterion to apply
                 on an equally favored set of paths to pick best";
One description is perhaps enough

uses path-objective-function_config;
using _ is not wrong but is discouraged, mixing _ with - in a label more
so

/This document registers a YANG module/
This document registers two YANG modules/

   name: ietf-te-types namespace: urn:ietf:params:xml:ns:yang:ietf-te-
   types prefix: ietf-te-types reference: RFC3209
   name: ietf-te-packet-types namespace:
   urn:ietf:params:xml:ns:yang:ietf-te-packet-types prefix: ietf-te-
   packet-types reference: RFC3209

Perhaps /3209/XXXX/

Tom Petch

----- Original Message -----
From: "Jan Lindblad" <janl@tail-f.com>;
To: "Tarek Saad (tsaad)" <tsaad@cisco.com>;
Cc: <yang-doctors@ietf.org>;;
<draft-ietf-teas-yang-te-types.all@ietf.org>;; <ietf@ietf.org>;;
<teas@ietf.org>;
Sent: Monday, January 21, 2019 10:10 AM
Subject: Re: [Teas] Yangdoctors early review of
draft-ietf-teas-yang-te-types-03 (was -01)


>