Re: [Tsv-art] [Acme] TSV-ART review of draft-ietf-acme-acme-08

Richard Barnes <rlb@ipv.sx> Tue, 28 November 2017 18:44 UTC

Return-Path: <rlb@ipv.sx>
X-Original-To: tsv-art@ietfa.amsl.com
Delivered-To: tsv-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E87BB128D44 for <tsv-art@ietfa.amsl.com>; Tue, 28 Nov 2017 10:44:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.598
X-Spam-Level:
X-Spam-Status: No, score=-2.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=ipv-sx.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G-Jl8L2bKUGH for <tsv-art@ietfa.amsl.com>; Tue, 28 Nov 2017 10:44:08 -0800 (PST)
Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 39713128D16 for <tsv-art@ietf.org>; Tue, 28 Nov 2017 10:44:08 -0800 (PST)
Received: by mail-wm0-x229.google.com with SMTP id y82so32983321wmg.1 for <tsv-art@ietf.org>; Tue, 28 Nov 2017 10:44:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipv-sx.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=N2ElsQRuD+MkN7SRpSAAUCPEMR+fbMrTigyNw3keDcg=; b=yz/mk/Hef0UOGBfyqpqNdwoDgS0jKmUZZhBK5IAcwMtL/WlS/pBKmYqOvumZyIiSAy Srcpm3eEwgMH7X0LnOezPWYm3Ij7953Gx4h41mZiHJNhb/xosm+pN+Y1TfqIXg56XB1g aAqMlhGI2qpIBYq2mGI76qWfLEBYkSFNWnNXJyrl2oKCJbbPpJ0qAV1LYkc0dUtKBqw9 h8QWTDyq+zapqghr/NkF6Dak8odFZcuF42zsYqRUsIfWWINJ0sgoMl82E6Moc0fP3bAx vJX+BQQDdDfQHeLxFjZJXiY4Q2qTvdUPpdbAiKreQPNIgA4KGtcJmQSV69sma+0F2wZP io+A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=N2ElsQRuD+MkN7SRpSAAUCPEMR+fbMrTigyNw3keDcg=; b=e25YATUX7uAxNBm+fYoZons/l1x5CV4yDgwz2BmF+hTFVLyE9ERYX2ep11mw43kEAm 1yyRl6lVbN/6IxfB0I1P+WriFGkIIAJUFYUM2p0V0D8drsL4XBChLE4oC31PhAhKBUQH UlXtwLlBFR4fdJIeF0lDY8LyiJbDZnhMkVIuG3CITKHXtuoqjvEJDb+v8D+QprjvtZYL gn46V4U29bs8VmQaW1oRVp3uEcmsDbhxCym77rMBMTubyufBtZD0lQ89oDCc2HglZ49D 8ozd6sY0JIq++5Tks4bVCPA1MiN/3YWi6RPOZv614JSf/sievp1i5OU9OCSyhKLv/JOI Q9ag==
X-Gm-Message-State: AJaThX5gsSc64A+D0JnAF1k2d6grZGLxx2Ch6M2hDwwGqvnG8jcKoOYN HSUSI++RmYYYvV7NqoSr2ZwdK6pgJU6Gey1Uo4bLPA==
X-Google-Smtp-Source: AGs4zMZ2B6H7lM73KuF9RU3SPUF47dSckdF7ttnDn3RL4QUWqtAk9wcG92+RhHJxaTbm9l7ZvvvyKWNk0Xwi2wMbaCQ=
X-Received: by 10.28.113.71 with SMTP id m68mr531765wmc.1.1511894646631; Tue, 28 Nov 2017 10:44:06 -0800 (PST)
MIME-Version: 1.0
Received: by 10.28.167.74 with HTTP; Tue, 28 Nov 2017 10:44:05 -0800 (PST)
In-Reply-To: <d73e832a-c7b3-7ae7-5dba-5cdfa75e8619@gmail.com>
References: <d73e832a-c7b3-7ae7-5dba-5cdfa75e8619@gmail.com>
From: Richard Barnes <rlb@ipv.sx>
Date: Tue, 28 Nov 2017 13:44:05 -0500
Message-ID: <CAL02cgSsF3yytoW6iEVEPCjRyQYkyHuxuWw7fjZFrnsvmPg+gg@mail.gmail.com>
To: Martin Stiemerling <mls.ietf@gmail.com>
Cc: "acme@ietf.org" <acme@ietf.org>, tsv-art@ietf.org
Content-Type: multipart/alternative; boundary="001a11478b0c59e94a055f0f670c"
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/EpRl5HhxBJ91ygYvlNVahQJ3a7g>
Subject: Re: [Tsv-art] [Acme] TSV-ART review of draft-ietf-acme-acme-08
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Nov 2017 18:44:10 -0000

Thanks for the review, Martin.  I've posted responses in a PR, along with a
couple of other minor fixes:

https://github.com/ietf-wg-acme/acme/pull/357

On Tue, Nov 28, 2017 at 5:38 AM, Martin Stiemerling <mls.ietf@gmail.com>
wrote:

> Hi all,
>
> I've reviewed this document as part of the transport area review team's
> ongoing effort to review key IETF documents. These comments were written
> primarily for the transport area directors, but are copied to the
> document's authors for their information and to allow them to address any
> issues raised. When done at the time of IETF Last Call, the authors should
> consider this review together with any other last-call comments they
> receive. Please always CC tsv-art@… if you reply to or forward this
> review.
>
> Summary:
> This draft is basically ready for publication, but has nits that should be
> fixed before publication.
>
> Editorials:
> - Abstract says "DISCLAIMER:...":
> This should be removed before publication or there is an issue with the
> intended status of Standards Track.
>
> - A nit, but: section 7.3.4 uses http instead of https in the example:
> "instance": "http://example.com/agreement/?token=W8Ih3PswD-8"
> All other instances use https.
>
>
> Technicals:
>
> - Section 8.2. Retrying challenges
> Any guidance on what "some times" means? At least in terms of a time
> scale, e.g., seconds, minutes, hours?
>
>
> Thanks for the clearly written document!
>
> Regards,
>
>   Martin Stiemerling
>
> _______________________________________________
> Acme mailing list
> Acme@ietf.org
> https://www.ietf.org/mailman/listinfo/acme
>