[tsvwg] Genart last call review of draft-ietf-tsvwg-tinymt32-01

Stewart Bryant via Datatracker <noreply@ietf.org> Wed, 08 May 2019 12:52 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: tsvwg@ietf.org
Delivered-To: tsvwg@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 42C94120116; Wed, 8 May 2019 05:52:04 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Stewart Bryant via Datatracker <noreply@ietf.org>
To: <gen-art@ietf.org>
Cc: ietf@ietf.org, draft-ietf-tsvwg-tinymt32.all@ietf.org, tsvwg@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.96.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Stewart Bryant <stewart.bryant@gmail.com>
Message-ID: <155731992421.22706.18402243276597862967@ietfa.amsl.com>
Date: Wed, 08 May 2019 05:52:04 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsvwg/-FCvLHe3vbILjyHEmDnEk9VaUFw>
Subject: [tsvwg] Genart last call review of draft-ietf-tsvwg-tinymt32-01
X-BeenThere: tsvwg@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Transport Area Working Group <tsvwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsvwg/>
List-Post: <mailto:tsvwg@ietf.org>
List-Help: <mailto:tsvwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 May 2019 12:52:05 -0000

Reviewer: Stewart Bryant
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>;.

Document: draft-ietf-tsvwg-tinymt32-01
Reviewer: Stewart Bryant
Review Date: 2019-05-08
IETF LC End Date: 2019-05-13
IESG Telechat date: Not scheduled for a telechat

Summary: A well written document. There are a few review comments below that
the authors should consider.

Major issues: None

Minor issues:

According to statistical tests (BigCrush in TestU01
<http://simul.iro.umontreal.ca/testu01/tu01.html> and AdaptiveCrush
<http://www.math.sci.hiroshima-u.ac.jp/~m-mat/MT/ADAPTIVE/>) the
 quality of the outputs of TinyMT seems pretty good,

SB> It would be useful to the reader to specify  "pretty good"

=========

   The TinyMT32 PRNG initialization depends, among other things, on a
   parameter set -- namely (mat1, mat2, tmat) --

SB> These probably need a few words  of explanation on introduction.

========

   static void tinymt32_next_state (tinymt32_t * s);
SB> I assume that this notation is good C, but
SB> type space star space name does not seem common.
SB> This may confuse some readers. One more often
SB> sees one of the spaces omitted.

=========

Nits/editorial comments:

   This specialisation aims at having a simple-to-use and deterministic
   PRNG, as explained below.

SB> I assume that "deterministic PRNG" is a term of the art, but the
SB> it sounds like an oxymoron to the uninitiated. Perhaps a word
SB> or two would clarify.

=======