Re: [Webpush] Kathleen Moriarty's No Objection on draft-ietf-webpush-vapid-03: (with COMMENT)

Kathleen Moriarty <kathleen.moriarty.ietf@gmail.com> Wed, 16 August 2017 15:35 UTC

Return-Path: <kathleen.moriarty.ietf@gmail.com>
X-Original-To: webpush@ietfa.amsl.com
Delivered-To: webpush@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ABFDA132394; Wed, 16 Aug 2017 08:35:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s93scSBLvbxx; Wed, 16 Aug 2017 08:35:07 -0700 (PDT)
Received: from mail-pg0-x235.google.com (mail-pg0-x235.google.com [IPv6:2607:f8b0:400e:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B7C871321C9; Wed, 16 Aug 2017 08:35:07 -0700 (PDT)
Received: by mail-pg0-x235.google.com with SMTP id u5so24495091pgn.0; Wed, 16 Aug 2017 08:35:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=jXB/Cvq9NGErFMovmnnxBaVPvdGjksA/2cis7ACF5kI=; b=Ay2hhJSq+bafEYI2W7XhubastqHlBhHlhE7sphSGPHg3TblH0BNbOCYmmRyJAXXGSi jWwrCTaUFbPRSjVpntpkZFDl12rj/Fvb0V1wl1NKz85JNEgUZi7ADn7LvNkIoVcx6kxh Ed56Xr07Gr0pGTR+6Mul43JSA+RMfdj6zVInZ8zxy4TKMZTzKyullHcKrbOw3o1bV2C5 EZer+QQJ9jbez3dS4xvi/DJPD767tBJXDq47QSH/yy5Xe19ZHeYxx+0doKB8Xeh4Qi4J vS1G1Wa9oSUVg28GjI1jBhz0owW2reV/Iop97sMxC8MQOsyA0H0z0IZY/a994Cf/g+An GDIQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=jXB/Cvq9NGErFMovmnnxBaVPvdGjksA/2cis7ACF5kI=; b=ARZorOI1NKDuQ2N5TzrQRQeEyQd4Sz+2ayxOwiLbOZgwscJfOoBfXuuCkEAxB2s6RA m+kEjg9IVv/TMo8Ru9j4VhG0bY28p6TN/+onoUoeplKmd6srcNlMshWBBpRSrpa0GBo4 KeOW/xPEiji6eCoEdV0dZ+HNoiNEqEA57y787j2fz4yxD6c/EJaPbcO1io392jqq8etd xcuVfEXyn4kcye07TaQII00WEqTfLXQmmWR1jJ2mHJpuapDhAhv5VvarpB8Y6bRJxup/ dMSDzKg62/n9UScjEYZOf8eIGV/e2Ob+fs2jw1brZ8utsPV77jTpWtKtDtk9HVLruuYQ ylTg==
X-Gm-Message-State: AHYfb5ibuHL07VcfV/qzrf//LrMXJRl244FBKOEz+aT+CEhlAMy1nC/o qJXduuzaBvzouWK7Gj5HL5OBdU71Dg==
X-Received: by 10.98.200.152 with SMTP id i24mr2119399pfk.33.1502897707354; Wed, 16 Aug 2017 08:35:07 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.100.144.1 with HTTP; Wed, 16 Aug 2017 08:34:26 -0700 (PDT)
In-Reply-To: <CABkgnnXotYcLeJyPcF97Den=-bEzoOv6WWjT3uQ=ELGA94DkNA@mail.gmail.com>
References: <150282302424.20984.16954614287039839165.idtracker@ietfa.amsl.com> <CABkgnnXotYcLeJyPcF97Den=-bEzoOv6WWjT3uQ=ELGA94DkNA@mail.gmail.com>
From: Kathleen Moriarty <kathleen.moriarty.ietf@gmail.com>
Date: Wed, 16 Aug 2017 11:34:26 -0400
Message-ID: <CAHbuEH7cB=ST=zz8r-G-q6eREy66cRoQCkgS=qq50pX6=pPTyg@mail.gmail.com>
To: Martin Thomson <martin.thomson@gmail.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-webpush-vapid <draft-ietf-webpush-vapid@ietf.org>, Phil Sorber <sorber@apache.org>, webpush-chairs@ietf.org, "webpush@ietf.org" <webpush@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/webpush/yINFfwbBP8ZpKDY_SkBFEAnsrvo>
Subject: Re: [Webpush] Kathleen Moriarty's No Objection on draft-ietf-webpush-vapid-03: (with COMMENT)
X-BeenThere: webpush@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Discussion of potential IETF work on a web push protocol <webpush.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/webpush>, <mailto:webpush-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/webpush/>
List-Post: <mailto:webpush@ietf.org>
List-Help: <mailto:webpush-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/webpush>, <mailto:webpush-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Aug 2017 15:35:10 -0000

Hi Martin,

On Tue, Aug 15, 2017 at 9:11 PM, Martin Thomson
<martin.thomson@gmail.com>; wrote:
> On 16 August 2017 at 04:50, Kathleen Moriarty
> <Kathleen.Moriarty.ietf@gmail.com>; wrote:
>> In section 3, it seems that you are just signing the JWK and that seems fine
>> from the text and the purpose listed - origin server authentication.
>>
>> Then in section 3.2, there's a reference to I-D.ietf-webpush-encryption saying,
>> "An application server MUST select a different
>>    private key for the key exchange".  This makes me think that encryption is
>>    used as well, but I think it would be helpful to see the point made more
>>    clear here or in the security considerations section.  Is confidentiality
>>    provided/required or just integrity for this draft?
>
> There are two separate mechanisms.  -encryption sends a message to the
> user agent.  That message has confidentiality and integrity protection
> - the push service can't see or modify that message.  In the envelope
> of that message, we have this JWT.  The confidentiality/integrity
> protection for that is HTTPS.  Confidentiality is required to prevent
> theft of the token, as stated in the security considerations.  What I
> now realize is that I didn't actually reiterate the requirement for
> HTTPS from 8030.
>
>   https://github.com/webpush-wg/webpush-vapid/pull/41

Thanks for adding text, there wasn't mention of confidentiality being
required  or HTTPS in the version I read, so that is a helpful
addition.
>
> The text you cite is included specifically to maybe prevent someone
> from incorrectly using the same key for signing (in -vapid) and
> encryption (in -encryption).  Unfortunately, this specific type of
> misuse is possible in a lot of codebases and does happen.

OK, if it's possible to edit the cited text to make it more clear, I
think that would be helpful to any implementer that comes along later.



-- 

Best regards,
Kathleen