Re: [xml2rfc-dev] <contact> element in <t>

Henrik Levkowetz <henrik@levkowetz.com> Wed, 11 December 2019 07:18 UTC

Return-Path: <henrik@levkowetz.com>
X-Original-To: xml2rfc-dev@ietfa.amsl.com
Delivered-To: xml2rfc-dev@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E2C7A120AED for <xml2rfc-dev@ietfa.amsl.com>; Tue, 10 Dec 2019 23:18:11 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.899
X-Spam-Level:
X-Spam-Status: No, score=-6.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v4NoNCjt_IGH for <xml2rfc-dev@ietfa.amsl.com>; Tue, 10 Dec 2019 23:18:09 -0800 (PST)
Received: from zinfandel.tools.ietf.org (zinfandel.tools.ietf.org [64.170.98.42]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ED7AB1208E5 for <xml2rfc-dev@ietf.org>; Tue, 10 Dec 2019 23:18:08 -0800 (PST)
Received: from h-202-242.a357.priv.bahnhof.se ([158.174.202.242]:52945 helo=tannat.localdomain) by zinfandel.tools.ietf.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from <henrik@levkowetz.com>) id 1iewG5-0004UX-Sa; Tue, 10 Dec 2019 23:18:07 -0800
To: Martin Thomson <mt@lowentropy.net>, xml2rfc-dev@ietf.org
References: <041d01b9-8364-4d84-a7af-28ac58dd14d7@www.fastmail.com> <d9a9ad58-d80b-eee5-97ff-c2734f3be96a@levkowetz.com> <af8ad8d5-3097-498b-8768-0d569e67bb26@www.fastmail.com>
From: Henrik Levkowetz <henrik@levkowetz.com>
Message-ID: <8e3b4156-7598-ab68-8010-5f0017325337@levkowetz.com>
Date: Wed, 11 Dec 2019 08:17:57 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <af8ad8d5-3097-498b-8768-0d569e67bb26@www.fastmail.com>
Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="ck5AMwI6IXHHS40fuhRnr3tdwuRiS9R5R"
X-SA-Exim-Connect-IP: 158.174.202.242
X-SA-Exim-Rcpt-To: xml2rfc-dev@ietf.org, mt@lowentropy.net
X-SA-Exim-Mail-From: henrik@levkowetz.com
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on zinfandel.tools.ietf.org)
X-Clacks-Overhead: GNU Terry Pratchett
Archived-At: <https://mailarchive.ietf.org/arch/msg/xml2rfc-dev/2WFakPyj-l3tuzzh_To4cFitr4U>
Subject: Re: [xml2rfc-dev] <contact> element in <t>
X-BeenThere: xml2rfc-dev@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Discussion about particulars of xml2rfc V3 design, development and code." <xml2rfc-dev.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/xml2rfc-dev>, <mailto:xml2rfc-dev-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/xml2rfc-dev/>
List-Post: <mailto:xml2rfc-dev@ietf.org>
List-Help: <mailto:xml2rfc-dev-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/xml2rfc-dev>, <mailto:xml2rfc-dev-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Dec 2019 07:18:14 -0000

Hi Martin,

On 2019-12-11 03:16, Martin Thomson wrote:
> The XML in question is produced from kramdown, but you can see the input here:
> 
> https://github.com/quicwg/base-drafts/compare/contributors?expand=1
> 
> This expands into pretty much what you see below.

I'm afraid that's not too helpful -- it really would make a difference
if you could pull out the XML file which exhibits the problem and send
it to me.

	Henrik

> 
> On Wed, Dec 11, 2019, at 12:39, Henrik Levkowetz wrote:
>> Hi Martin,
>> 
>> On 2019-12-11 02:13, Martin Thomson wrote:
>> > Hi Henrik,
>> > 
>> > I just tested this new element out in xml2rfc 2.37.0.  I think that there are some bugs to work out.
>> > 
>> > I have the following input (in reduced form):
>> > 
>> > <t>The following people helped:
>> > ... (ascii names) ...,
>> > <contact fullname="Mirja Kühlewind"/>,
>> > ...
>> > <contact asciiFullname="Kazuho Oku" fullname="?"/>,
>> > ...
>> > </t>
>> > 
>> > I don't have Kazuho's real name just yet, so I just added "?" for the moment.
>> > 
>> > What I have observed is that the output includes many additional line
>> > breaks. If I get this right, this is producing a new paragraph break
>> > for the name included in <contact>. That's not expected.
>> 
>> No, and I haven't seen this here in my tests.  Could you send your XML?
>> 
>> > It also appears to remove the "?" I'm using as a placeholder in this
>> > example. I can put some Unicode in fullname (for instance, "øøø"
>> > works fine), but the Japanese text I copied from somewhere failed.
>> > 
>> > fullname="投稿者" causes xml2rfc to choke:
>> > 
>> >   File "/home/martin/bin/xml2rfc", line 11, in <module>
>> >     load_entry_point('xml2rfc==2.37.0', 'console_scripts', 'xml2rfc')()
>> >   File "/home/martin/.local/lib/python3.8/site-packages/xml2rfc/run.py", line 590, in main
>> >     writer.write(filename)
>> >   File "/home/martin/.local/lib/python3.8/site-packages/xml2rfc/writers/text.py", line 274, in write
>> >     lines = self.paginate(lines)
>> >   File "/home/martin/.local/lib/python3.8/site-packages/xml2rfc/writers/text.py", line 412, in paginate
>> >     paginated[i].elem.page = page
>> > AttributeError: 'lxml.etree._Element' object has no attribute 'page'
>> > 
>> > I thought that that specific error might be due to placement, but
>> > moving the text around didn't help.
>> 
>> Interesting.  I haven't seen this in my tests either.  I used Georgian
>> Mkhedruli though, not Japanese Kanji.  I'll try that tomorrow, fix, and do a
>> bugfix release.  I see this is related to pagination, so again your XML file
>> might help debug this.
>> 
>> 
>> 	Henrik
>> 
>> 
>> Attachments:
>> * signature.asc
>