[xml2rfc-dev] empty workgroup leads to crash
Miek Gieben <miek@miek.nl> Tue, 14 May 2019 06:54 UTC
Return-Path: <miek@miek.nl>
X-Original-To: xml2rfc-dev@ietfa.amsl.com
Delivered-To: xml2rfc-dev@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 042FB120157 for <xml2rfc-dev@ietfa.amsl.com>; Mon, 13 May 2019 23:54:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=miek-nl.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Kbv3vbVdBmfK for <xml2rfc-dev@ietfa.amsl.com>; Mon, 13 May 2019 23:54:37 -0700 (PDT)
Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8A162120187 for <xml2rfc-dev@ietf.org>; Mon, 13 May 2019 23:54:37 -0700 (PDT)
Received: by mail-wr1-x433.google.com with SMTP id d9so9439928wrx.0 for <xml2rfc-dev@ietf.org>; Mon, 13 May 2019 23:54:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=miek-nl.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:mime-version:content-disposition; bh=1267KEtuTG6EjHqp9xw+pVF8ZMEHRO6Uyae4zDaBxos=; b=sWhBa1eUrSAnFlVGN+eFrrijbjoNuQghMXTR/NiVLDXgiOZpbsRQ4by8G7g+hjtcjF mfzcH1RUaYPfnichSN10/d1wL/6dSvbctey09u0zCkAlTCeD9fuXEfkdt+Y4mcC9i9lO qh9yLo6dPVTTfZ/tNjXCftIdNXo+VEFCbeodqWVNKfAQJ1ev/W2oFwkh2WZl/8fhQp25 7yRq3k2SstQ6Zdj/toy2ac1rAALz2zNP7XuwtNCWnf3bzmsbcsJL7YVL7IVu1VPOBdY9 fBjQUEL+2/bMY4P5Q1FUNopy7dk9J4jEUC7OQb1XmxoCFGEAwE2KHeYd04HCVKrR4iSH vzVA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition; bh=1267KEtuTG6EjHqp9xw+pVF8ZMEHRO6Uyae4zDaBxos=; b=RKEnKoZf8iD0zP7nd3R62QIZfS2/z6uEub6Fv328wSY5CPByDbsDfiYDpwPJyBkOdD gl/pxHmEtboOJZZvmMNcA68M1NS5aKrESrnIK/F8xpxEOv7ZhffkFg0DRvx/0zSgIzeK y+lfElZBleLAQMh1+joN3RpGK/61h947iG9+p1yG4haM7aV1cj3xJQ0ssQ3KM4Bqt0w2 jAo5FmjwrNEqpAoAI46g4NonJ1F8t5AHDQ0CR6f3yvdsbarSp6L0UGRwsk4lFvv+pb0V m3oyjsezuL4twvb30oMrS8DUcaysJWtShIFT8vhAeURqIyqCBOSZhsFIj5YAsn9AASPu vmag==
X-Gm-Message-State: APjAAAWrIb0uvDLGAKcuQck+nGDv/Dava3/iJcHFwSh5qam7IEQTUqi0 tZznl8ZOZwYiCtRJxWmSeNX1mVsbckw=
X-Google-Smtp-Source: APXvYqwRhu1GkfQOU8a0EtQ4aAYBzOTDJdXOy4TA+PZJKcbzXPy0/bq/+InGoTbRpR6JgK/OzWupZA==
X-Received: by 2002:adf:eb84:: with SMTP id t4mr2135147wrn.43.1557816875471; Mon, 13 May 2019 23:54:35 -0700 (PDT)
Received: from miek.nl (router.mikrotime.com. [81.187.237.61]) by smtp.gmail.com with ESMTPSA id a6sm13346069wrp.49.2019.05.13.23.54.33 for <xml2rfc-dev@ietf.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 May 2019 23:54:34 -0700 (PDT)
Date: Tue, 14 May 2019 07:54:32 +0100
From: Miek Gieben <miek@miek.nl>
To: IETF xml2rfc-dev <xml2rfc-dev@ietf.org>
Message-ID: <20190514065432.djwufenbgwrvbktt@miek.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format="flowed"
Content-Disposition: inline
Archived-At: <https://mailarchive.ietf.org/arch/msg/xml2rfc-dev/z7N6M6KI8Qc5d764c349TmuETRw>
Subject: [xml2rfc-dev] empty workgroup leads to crash
X-BeenThere: xml2rfc-dev@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Discussion about particulars of xml2rfc V3 design, development and code." <xml2rfc-dev.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/xml2rfc-dev>, <mailto:xml2rfc-dev-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/xml2rfc-dev/>
List-Post: <mailto:xml2rfc-dev@ietf.org>
List-Help: <mailto:xml2rfc-dev-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/xml2rfc-dev>, <mailto:xml2rfc-dev-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 May 2019 06:54:40 -0000
Hi all,
If the workgroup is empty xml2rfc 2.22.3 crashes with the following stack trace:
xml2rfc --text --v3 draft-gieben-mmark-00.xml && rm draft-gieben-mmark-00.xml
Parsing file draft-gieben-mmark-00.xml
Traceback (most recent call last):
File "/usr/bin/xml2rfc", line 11, in <module>
load_entry_point('xml2rfc==2.22.3', 'console_scripts', 'xml2rfc')()
File "/usr/lib/python2.7/dist-packages/xml2rfc/run.py", line 549, in main
writer.write(filename)
File "/usr/lib/python2.7/dist-packages/xml2rfc/writers/text.py", line 228, in write
lines = self.render(self.root, width=72, joiners=joiners)
File "/usr/lib/python2.7/dist-packages/xml2rfc/writers/text.py", line 271, in render
res = func(e, width, **kwargs)
File "/usr/lib/python2.7/dist-packages/xml2rfc/writers/text.py", line 2834, in render_rfc
lines = self.ljoin(lines, c, width, **kwargs)
File "/usr/lib/python2.7/dist-packages/xml2rfc/writers/text.py", line 446, in ljoin
res = mklines(self.render(e, width, **kwargs), e)
File "/usr/lib/python2.7/dist-packages/xml2rfc/writers/text.py", line 271, in render
res = func(e, width, **kwargs)
File "/usr/lib/python2.7/dist-packages/xml2rfc/writers/text.py", line 1604, in render_front
text = '\n\n\n\n' + self.render_first_page_top(e, width, **kwargs) + '\n'
File "/usr/lib/python2.7/dist-packages/xml2rfc/writers/text.py", line 1796, in render_first_page_top
left = get_left(e)
File "/usr/lib/python2.7/dist-packages/xml2rfc/writers/text.py", line 1723, in get_left
left.append(group.text.strip())
AttributeError: 'NoneType' object has no attribute 'strip'
Makefile:8: recipe for target 'draft-gieben-mmark-00.txt' failed
make: *** [draft-gieben-mmark-00.txt] Error 1
/Miek
--
Miek Gieben
- [xml2rfc-dev] empty workgroup leads to crash Miek Gieben
- Re: [xml2rfc-dev] empty workgroup leads to crash Henrik Levkowetz