Re: [yang-doctors] [Softwires] Yangdoctors early review of draft-ietf-softwire-iftunnel-03

<mohamed.boucadair@orange.com> Thu, 04 April 2019 05:42 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 162A5120446; Wed, 3 Apr 2019 22:42:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u1YIHwL0ix4c; Wed, 3 Apr 2019 22:42:35 -0700 (PDT)
Received: from orange.com (mta135.mail.business.static.orange.com [80.12.70.35]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1543D1202DD; Wed, 3 Apr 2019 22:42:35 -0700 (PDT)
Received: from opfednr06.francetelecom.fr (unknown [xx.xx.xx.70]) by opfednr22.francetelecom.fr (ESMTP service) with ESMTP id 44ZX092Fkhz10TV; Thu, 4 Apr 2019 07:42:33 +0200 (CEST)
Received: from Exchangemail-eme6.itn.ftgroup (unknown [xx.xx.13.107]) by opfednr06.francetelecom.fr (ESMTP service) with ESMTP id 44ZX091Z7kzDq7C; Thu, 4 Apr 2019 07:42:33 +0200 (CEST)
Received: from OPEXCAUBMA2.corporate.adroot.infra.ftgroup ([fe80::e878:bd0:c89e:5b42]) by OPEXCAUBM8F.corporate.adroot.infra.ftgroup ([::1]) with mapi id 14.03.0439.000; Thu, 4 Apr 2019 07:42:32 +0200
From: <mohamed.boucadair@orange.com>
To: Andy Bierman <andy@yumaworks.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "softwires@ietf.org" <softwires@ietf.org>, "draft-ietf-softwire-iftunnel.all@ietf.org" <draft-ietf-softwire-iftunnel.all@ietf.org>
Thread-Topic: [Softwires] Yangdoctors early review of draft-ietf-softwire-iftunnel-03
Thread-Index: AQHU6k6Mu5tQYFn5TkS9Oy/Z3E71QqYrfSvg
Date: Thu, 4 Apr 2019 05:42:33 +0000
Message-ID: <787AE7BB302AE849A7480A190F8B93302EA59FDC@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
References: <155431760907.22784.16246569281973305806@ietfa.amsl.com>
In-Reply-To: <155431760907.22784.16246569281973305806@ietfa.amsl.com>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.114.13.245]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/LErPwX_13VeC2mkang1KqJ41IIE>
Subject: Re: [yang-doctors] [Softwires] Yangdoctors early review of draft-ietf-softwire-iftunnel-03
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Apr 2019 05:42:37 -0000

Hi Andy,

Good catch.

I updated the draft to take into account your review: https://tools.ietf.org/html/draft-ietf-softwire-iftunnel-04 

Thank you. 

Cheers,
Med

> -----Message d'origine-----
> De : Softwires [mailto:softwires-bounces@ietf.org] De la part de Andy Bierman
> via Datatracker
> Envoyé : mercredi 3 avril 2019 20:53
> À : yang-doctors@ietf.org
> Cc : softwires@ietf.org; draft-ietf-softwire-iftunnel.all@ietf.org
> Objet : [Softwires] Yangdoctors early review of draft-ietf-softwire-iftunnel-
> 03
> 
> Reviewer: Andy Bierman
> Review result: Ready with Nits
> 
> The iana-tunnel-type module has no errors or nits of any kind.
> The ietf-extension-example module has no errors of any kind, and 1 nit.
> The document appears to follow all YANG usage guidelines (but 1) correctly.
> 
> I have a minor comment about the example module. I guess it has to use <CODE
> BEGINS>. (The <EXAMPLE BEGINS> discussion did not go anywhere).
> 
> This module looks a little too real to average users, especially after tools
> extract it from the RFC and put it in the YangModels repo under the
> standard/ietf/RFC directory.
> 
> You should rename the ietf-extension-example module to
> example-iftunnel-extension (or anything starting with "example-"). The module
> should not begin with "ietf-" unless it is a real module.
> 
> 
> _______________________________________________
> Softwires mailing list
> Softwires@ietf.org
> https://www.ietf.org/mailman/listinfo/softwires