Re: [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-notification-capabilities-05

Ladislav Lhotka <lhotka@nic.cz> Tue, 05 November 2019 16:43 UTC

Return-Path: <lhotka@nic.cz>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6ACD7120871; Tue, 5 Nov 2019 08:43:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.998
X-Spam-Level:
X-Spam-Status: No, score=-6.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nic.cz
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OIEgPmnDwIGd; Tue, 5 Nov 2019 08:43:45 -0800 (PST)
Received: from mail.nic.cz (mail.nic.cz [IPv6:2001:1488:800:400::400]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A43C412085B; Tue, 5 Nov 2019 08:43:45 -0800 (PST)
Received: from birdie (unknown [IPv6:2a01:5e0:29:ffff:a77:4b4a:dc25:79cc]) by mail.nic.cz (Postfix) with ESMTPSA id 74622140FCE; Tue, 5 Nov 2019 17:43:43 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1572972223; bh=FupaaR+uVFUkjPBtpTMD0myWfPW7y6LT9rpMqHfs60o=; h=From:To:Date; b=YS95h73xpv5Jw7BZJ6PdFHwDWjYuD6toGPGNo2b8u7M4nHieGItB8tTyWwgp5pvrk BmmQ0rUOu9+kMxngLmowUrPUboRF06SVWE0iSJkd5D/3af/EoyaCSI6uvPWZnBxrun tgiP1at/IqY7scgougddgsB+D+9haBKmZRHAE8Ns=
Message-ID: <352449f5e1398ccfca7591e0e4555b710c766802.camel@nic.cz>
From: Ladislav Lhotka <lhotka@nic.cz>
To: =?ISO-8859-1?Q?Bal=E1zs?= Lengyel <balazs.lengyel@ericsson.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
Cc: "last-call@ietf.org" <last-call@ietf.org>, "netconf@ietf.org" <netconf@ietf.org>, "draft-ietf-netconf-notification-capabilities.all@ietf.org" <draft-ietf-netconf-notification-capabilities.all@ietf.org>
Date: Tue, 05 Nov 2019 17:43:43 +0100
In-Reply-To: <AM7PR07MB621460C59113526390C62A5FF07E0@AM7PR07MB6214.eurprd07.prod.outlook.com>
References: <157233302184.6593.3869700028694968875@ietfa.amsl.com> <AM7PR07MB621460C59113526390C62A5FF07E0@AM7PR07MB6214.eurprd07.prod.outlook.com>
Organization: CZ.NIC
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Virus-Scanned: clamav-milter 0.100.3 at mail.nic.cz
X-Virus-Status: Clean
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/ebYqitE67lfBgJBWurXJ8zjd8zQ>
Subject: Re: [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-notification-capabilities-05
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Nov 2019 16:43:50 -0000

On Tue, 2019-11-05 at 14:38 +0000, Balázs Lengyel wrote:

...
> 
***** Appendix A. Instance data examples
>       - Example in Fig. 2: the <datastore> element has an incorrect
>         XML namespace (of the ietf-datastores module).
> BALAZS: I don't understand the comment; I don't see the error. Could you
> please advise me what you think should be there? Exactly where?

This element:

        <datastore xmlns="urn:ietf:params:xml:ns:yang:ietf-datastores">
          ds:operational
        </datastore>

The re-declaration of the default XML namespace is wrong and should be removed
(as in Fig. 1).
>  
>       - Many enum values are invalid because they contain
>         leading/trailing whitespace. It would be better to encode the
>         examples in JSON.
> BALAZS: I would like to keep the examples as they are.
> In many previous RFCs lines in XML examples were broken into multiple lines.
> E.g. 
> RFC7950 7.16.3
> rfc8341 A.4
> rfc8641 4.4.1
> rfc6022 4.1
> rfc8525 B
> rfc8072 A.1.1
> rfc6243  A.3.1
> IMHO it is readable. It is better to use longer descriptive names in YANG,
> then to use short names just to avoid long lines in XML examples.

The problem with this approach is that it may mislead casual readers into
thinking that the whitespace can be freely added to such values.

Lada

> 
-- 
Ladislav Lhotka
Head, CZ.NIC Labs
PGP Key ID: 0xB8F92B08A9F76C67