Re: [yang-doctors] Yangdoctors early review of draft-ietf-bfd-unsolicited-01

Jeffrey Haas <jhaas@pfrc.org> Wed, 21 August 2019 20:11 UTC

Return-Path: <jhaas@slice.pfrc.org>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 930981209B1; Wed, 21 Aug 2019 13:11:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8IKgie5j2kAQ; Wed, 21 Aug 2019 13:11:09 -0700 (PDT)
Received: from slice.pfrc.org (slice.pfrc.org [67.207.130.108]) by ietfa.amsl.com (Postfix) with ESMTP id 3D2CE1209A4; Wed, 21 Aug 2019 13:11:09 -0700 (PDT)
Received: by slice.pfrc.org (Postfix, from userid 1001) id 67BB71E2F6; Wed, 21 Aug 2019 16:13:28 -0400 (EDT)
Date: Wed, 21 Aug 2019 16:13:28 -0400
From: Jeffrey Haas <jhaas@pfrc.org>
To: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
Cc: Martin Bjorklund <mbj@tail-f.com>, "mjethanandani@gmail.com" <mjethanandani@gmail.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "rtg-bfd@ietf.org" <rtg-bfd@ietf.org>, "draft-ietf-bfd-unsolicited.all@ietf.org" <draft-ietf-bfd-unsolicited.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-bfd-yang@ietf.org" <draft-ietf-bfd-yang@ietf.org>
Message-ID: <20190821201328.GC367@pfrc.org>
References: <156621414936.19813.853283734958376284@ietfa.amsl.com> <0CD4CB48-9382-4724-A5A6-A7B0DE7D7D57@gmail.com> <22279DB9-A0F3-4D5E-BFDC-38B2AD5B109F@cisco.com> <20190819.211837.1184862907842631386.mbj@tail-f.com> <496A5CD5-23C9-4865-BC52-EFC5409475A8@cisco.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <496A5CD5-23C9-4865-BC52-EFC5409475A8@cisco.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/xEgPH4QhKmChzZy2e8Qdr8BhSjQ>
Subject: Re: [yang-doctors] Yangdoctors early review of draft-ietf-bfd-unsolicited-01
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Aug 2019 20:11:13 -0000

Reshad,

If procedures permit it (I'm unclear on the detail), does it make sense to
pull the BFD yang module for a fix from the editor queue?

-- Jeff

On Mon, Aug 19, 2019 at 07:31:27PM +0000, Reshad Rahman (rrahman) wrote:
> I was looking at an old copy of the doc which didn't have default. So yes, mandatory doesn't make sense with the default statements.
> 
> Your assumption below wrt the intention is correct. I don't know how feasible it is to add this while it's in the editor q.
> 
> Regards,
> Reshad.
> 
> On 2019-08-19, 3:18 PM, "Martin Bjorklund" <mbj@tail-f.com>; wrote:
> 
>     "Reshad Rahman (rrahman)" <rrahman@cisco.com>; wrote:
>     > Thanks Martin and Mahesh.
>     > 
>     > I believe we should add a mandatory statement to the choic (speaking
>     > as BFD YANG co-author,)
>     
>     But then it is not clear why all leafs in the cases have default
>     statements.
>     
>     Since the 'single-interval' case is optional with a if-feature (which
>     BTW is weird since it is trivial to implement), and the only other
>     case has default values on both its leafs, I would have assumed that
>     the intention was that if nothing is configured, the server should use
>     1000000 microseconds for the intervals.  If this is the intention,
>     perhaps a statement:  "default tx-rx-intervals;" can be added to the
>     module, even though the doc is in the RFC ed q.
>     
>     
>     /martin
>     
>     
>     
>     > 
>     > Just created https://github.com/bfd-wg
>     > 
>     > Regards,
>     > Reshad.
>     > 
>     > 
>     > On 2019-08-19, 2:45 PM, "Mahesh Jethanandani" <mjethanandani@gmail.com>; wrote:
>     > 
>     >     [Adding the authors of BFD YANG module]
>     >     
>     >     Martin brings up a good point. But since the document that contains ietf-bfd-types is sitting in RFC Ed Queue, this will have to go into a bis document.
>     >     
>     >     Chairs, could you create a bfd-wg in GitHub for us to track this as an issue to be fixed as part of a bis document?
>     >     
>     >     > On Aug 19, 2019, at 4:29 AM, Martin Björklund via Datatracker <noreply@ietf.org>; wrote:
>     >     > 
>     >     > Reviewer: Martin Björklund
>     >     > Review result: Ready with Nits
>     >     > 
>     >     > I have reviewed this document from a YANG model perspective only.
>     >     > 
>     >     > My only comment is actually for a grouping defined in ietf-bfd-type, but used
>     >     > in this module.  There is a choice "interval-config-type":
>     >     > 
>     >     >  +--rw unsolicited {bfd-unsol:unsolicited-params-global}?
>     >     >       +--rw enable?                           boolean
>     >     >       +--rw local-multiplier?                 multiplier
>     >     >       +--rw (interval-config-type)?
>     >     >          +--:(tx-rx-intervals)
>     >     >          |  +--rw desired-min-tx-interval?    uint32
>     >     >          |  +--rw required-min-rx-interval?   uint32
>     >     >          +--:(single-interval) {single-minimum-interval}?
>     >     >             +--rw min-interval?               uint32
>     >     > 
>     >     > This choice is not mandatory and doesn't have a default case, so the question
>     >     > is what happens if no nodes from the choice has been configured?   I would
>     >     > expect the choice to have a default case (but this then would apply to
>     >     > ietf-bfd-types, not this document.)
>     >     > 
>     >     > 
>     >     
>     >     Mahesh Jethanandani
>     >     mjethanandani@gmail.com
>     >     
>     >     
>     >     
>     >     
>     > 
>     
>