Re: [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-notification-capabilities-05

Ladislav Lhotka <lhotka@nic.cz> Mon, 18 November 2019 10:53 UTC

Return-Path: <lhotka@nic.cz>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8743412094D for <yang-doctors@ietfa.amsl.com>; Mon, 18 Nov 2019 02:53:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lmR7PgDI2iR6 for <yang-doctors@ietfa.amsl.com>; Mon, 18 Nov 2019 02:53:14 -0800 (PST)
Received: from trail.lhotka.name (trail.lhotka.name [77.48.224.143]) by ietfa.amsl.com (Postfix) with ESMTP id 06828120944 for <yang-doctors@ietf.org>; Mon, 18 Nov 2019 02:53:14 -0800 (PST)
Received: by trail.lhotka.name (Postfix, from userid 109) id B433B1820463; Mon, 18 Nov 2019 11:56:14 +0100 (CET)
Received: from localhost (dhcp-9c3a.meeting.ietf.org [31.133.156.58]) by trail.lhotka.name (Postfix) with ESMTPSA id BDBA1182045D; Mon, 18 Nov 2019 11:56:12 +0100 (CET)
From: Ladislav Lhotka <lhotka@nic.cz>
To: Balázs Lengyel <balazs.lengyel@ericsson.com>
Cc: YANG Doctors <yang-doctors@ietf.org>
In-Reply-To: <AM7PR07MB62146B266490087A4C9ACC4AF0720@AM7PR07MB6214.eurprd07.prod.outlook.com>
References: <157233302184.6593.3869700028694968875@ietfa.amsl.com> <AM7PR07MB621460C59113526390C62A5FF07E0@AM7PR07MB6214.eurprd07.prod.outlook.com> <352449f5e1398ccfca7591e0e4555b710c766802.camel@nic.cz> <AM7PR07MB62146B266490087A4C9ACC4AF0720@AM7PR07MB6214.eurprd07.prod.outlook.com>
Date: Mon, 18 Nov 2019 18:53:05 +0800
Message-ID: <87sgml4fse.fsf@nic.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/zha5Osm1VeMEqLJaWf9tl6M1fN0>
Subject: Re: [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-notification-capabilities-05
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Nov 2019 10:53:22 -0000

[also CCing YANG Doctors]

Balázs Lengyel <balazs.lengyel@ericsson.com> writes:

> Hello Lada,
> See below. See if you can accept my answer.
> Regards Balazs
>

...

>>       - Many enum values are invalid because they contain
>>         leading/trailing whitespace. It would be better to encode the
>>         examples in JSON.
>> BALAZS: I would like to keep the examples as they are.
>> In many previous RFCs lines in XML examples were broken into multiple lines.
>> E.g. 
>> RFC7950 7.16.3
>> rfc8341 A.4
>> rfc8641 4.4.1
>> rfc6022 4.1
>> rfc8525 B
>> rfc8072 A.1.1
>> rfc6243  A.3.1
>> IMHO it is readable. It is better to use longer descriptive names in 
>> YANG, then to use short names just to avoid long lines in XML examples.
>
> The problem with this approach is that it may mislead casual readers into thinking that the whitespace can be freely added to such values.
>
> Lada
>
> BALAZS2:
> IMHO as this is accepted practice (in not one but about every second RFC), and RFC7950 is explicit about the matter, the risk is not that big.

How is RFC 7950 explicit about it? BTW section 7.16.3 doesn't do this - in XPath expressions, extra whitespace is permitted in many places.

Also, it was more tolerable when XML was the only possible representation.

>
> On the other hand my alternatives would be:
> - use shorter, less meaningful schema names - results in less meaningful names

Agreed, not good.

> - use the still draft artwork folding - would like to avoid more dependencies on drafts. If this would be a full RFC the issue would be different.

Understood.

> - add textual remarks about the issue - unusual solution, needs quite a bit of explanation
> - use only JSON examples - IMHO I like XML, and only JSON my surprise some people

I think JSON examples are considerably more human-readable then XML, and I don't know why they should surprise anybody. This data isn't limited to NETCONF, so there is really no reason for not using JSON.

>
> So as a conclusion I would really like to keep the example as is. Can you accept it? If not please advise on what is acceptable for you.

I can live with it.

Lada

> Regards Balazs

-- 
Ladislav Lhotka 
Head, CZ.NIC Labs
PGP Key ID: 0xB8F92B08A9F76C67