[6tisch] A review of https://tools.ietf.org/html/draft-kivinen-802-15-ie-02 for INT-DIR

"Pascal Thubert (pthubert)" <pthubert@cisco.com> Mon, 24 October 2016 15:23 UTC

Return-Path: <pthubert@cisco.com>
X-Original-To: 6tisch@ietfa.amsl.com
Delivered-To: 6tisch@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B5D4212988A; Mon, 24 Oct 2016 08:23:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.951
X-Spam-Level:
X-Spam-Status: No, score=-14.951 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.431, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i8jfU-unTsQ1; Mon, 24 Oct 2016 08:23:09 -0700 (PDT)
Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5EF8B12988D; Mon, 24 Oct 2016 08:23:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=12534; q=dns/txt; s=iport; t=1477322588; x=1478532188; h=from:to:cc:subject:date:message-id:mime-version; bh=IeJDi6D7Vl1bBvlfoqSMnXMglk3aHM3ejytTUSFNTM4=; b=KVeuIcCLrziRBdadhgn50AT0aCRbkf6HUfvpb3xalxHaRshimUW8b/LY ba2j/m7PMV+6mqBht6Qxumr2136C6JVR9204Yc5M+GSToDFU6ZFKPAHW3 GqqMmo4oRAIQeVkoknlfxR4uQOBlTJZwsM0VbbhhvajHPOXdEUBdETwX/ Q=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0ADAgDLJg5Y/5BdJa1cGwEBAQMBAQEJAQEBgnQ2AQEBAQEdWH0HjS2mJYUWggcnhXqBZT8UAQIBAQEBAQEBYiiEaS0+DhIBHGQmAQQBDQ0BEog3DsFDAQEBAQEBAQEBAQEBAQEBAQEBAQEBHIY9iTyFPwWaFAGGKYligXWOFIcXhW+EAAEeNl6DVoEscgGHQIEAAQEB
X-IronPort-AV: E=Sophos;i="5.31,542,1473120000"; d="scan'208,217";a="338754008"
Received: from rcdn-core-8.cisco.com ([173.37.93.144]) by alln-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2016 15:23:07 +0000
Received: from XCH-RCD-002.cisco.com (xch-rcd-002.cisco.com [173.37.102.12]) by rcdn-core-8.cisco.com (8.14.5/8.14.5) with ESMTP id u9OFN7Qn014602 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 24 Oct 2016 15:23:07 GMT
Received: from xch-rcd-001.cisco.com (173.37.102.11) by XCH-RCD-002.cisco.com (173.37.102.12) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 24 Oct 2016 10:23:06 -0500
Received: from xch-rcd-001.cisco.com ([173.37.102.11]) by XCH-RCD-001.cisco.com ([173.37.102.11]) with mapi id 15.00.1210.000; Mon, 24 Oct 2016 10:23:06 -0500
From: "Pascal Thubert (pthubert)" <pthubert@cisco.com>
To: "draft-kivinen-802-15-ie@tools.ietf.org" <draft-kivinen-802-15-ie@tools.ietf.org>, "int-dir@ietf.org" <int-dir@ietf.org>
Thread-Topic: A review of https://tools.ietf.org/html/draft-kivinen-802-15-ie-02 for INT-DIR
Thread-Index: AdIuCgOtktmeAoQpRrysGX/nX1IU6w==
Date: Mon, 24 Oct 2016 15:22:41 +0000
Deferred-Delivery: Mon, 24 Oct 2016 15:22:27 +0000
Message-ID: <0c8d9a37da1648879577c72ce5b46ff1@XCH-RCD-001.cisco.com>
Accept-Language: fr-FR, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.55.22.4]
Content-Type: multipart/alternative; boundary="_000_0c8d9a37da1648879577c72ce5b46ff1XCHRCD001ciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/6tisch/HH5ZG8JiYJnELPu8Slq7CVM6xAY>
Cc: "6tisch@ietf.org" <6tisch@ietf.org>, "6lo@ietf.org" <6lo@ietf.org>
Subject: [6tisch] A review of https://tools.ietf.org/html/draft-kivinen-802-15-ie-02 for INT-DIR
X-BeenThere: 6tisch@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "Discuss link layer model for Deterministic IPv6 over the TSCH mode of IEEE 802.15.4e, and impacts on RPL and 6LoWPAN such as resource allocation" <6tisch.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/6tisch>, <mailto:6tisch-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/6tisch/>
List-Post: <mailto:6tisch@ietf.org>
List-Help: <mailto:6tisch-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/6tisch>, <mailto:6tisch-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Oct 2016 15:23:12 -0000

Dear all :

I am an assigned INT directorate reviewer for https://tools.ietf.org/html/draft-kivinen-802-15-ie-02. These comments were written primarily for the benefit of the Internet Area Directors. Document editors and shepherd(s) should treat these comments just like they would treat comments from any other IETF contributors and resolve them along with any other Last Call comments that have been received. For more details on the INT Directorate, see http://www.ietf.org/iesg/directorate.html.

Document: draft-kivinen-802-15-ie
IEEE 802.15.4 Information Element for IETF
Reviewer: Pascal Thubert
Review Date: October 13, 2016
IETF Last Call Date: TBD

Summary:

Tero's draft was developed outside of the working group but is an enabler for solutions developed at 6lo and 6TiSCH. This review comes after the ones by Pat and then Charlie, who provided the adequate comments regarding IEEE802.15.4 and ANA. This review abstains to comment on that. Also, this review is made in the light of the Charlie's proposed update.

Major issues:

I am not sure that "expert review" is the right policy for section 8 on IANA considerations. This registry is for IETF use only. Suggestion is to use "RFC required":
"
   Future assignments in this registry are to be coordinated via IANA under the policy of "RFC Required" (see RFC 5226).
"

Intended Status for this document: Seems to me that  informational should be the right level; see for instance https://tools.ietf.org/html/draft-ietf-6lo-ethertype-request-01
Related: In the -04 that Charlie attached, I saw that uppercase imperatives were added. I do not think that's a good idea:

-         Imperative "MUST" in section 7 refers to the writing of other documents and is probably not appropriate.

-         Imperative "SHOULD" in section 7 does not refer to the behavior of the implementation of this document and is probably not appropriate either.

-         If those go away, ref to RFC 2119 is not needed and the specification can take the informational path, much easier


Minor issues:

 The need for section 5 does not appear until the IANA section. The way it is done works, but leaves the reader puzzled. Swapping 5 and 6 and then one last sentence saying that there is no need to block subtype IDs in the IETF IE for Vendor Specific work would have made the reading a bit smoother.

Do we need 20% of the subtypes for experimentations? 240 to 255 seems enough to me...


Many thanks, Tero, for this much needed work!

Pascal