Re: [Acme] Proposed fix to signature reuse vulnerability

Andrew Ayer <agwa@andrewayer.name> Thu, 24 September 2015 04:18 UTC

Return-Path: <agwa@andrewayer.name>
X-Original-To: acme@ietfa.amsl.com
Delivered-To: acme@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 22E1C1B301E for <acme@ietfa.amsl.com>; Wed, 23 Sep 2015 21:18:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.602
X-Spam-Level:
X-Spam-Status: No, score=-0.602 tagged_above=-999 required=5 tests=[BAYES_05=-0.5, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rL1yt4XxbgWv for <acme@ietfa.amsl.com>; Wed, 23 Sep 2015 21:18:36 -0700 (PDT)
Received: from alcazar.beanwood.com (alcazar.beanwood.com [IPv6:2600:3c00:e000:6c::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1DA791B301C for <acme@ietf.org>; Wed, 23 Sep 2015 21:18:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=andrewayer.name; s=alcazar2; t=1443068314; bh=6pq5P9Lsid4AHFz0FuqBAk4SxHD7yLj99THbnX1TfIo=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=UIGZzV8tZHDxEubaaehQ5S4eH1Wf+1ndWTPL+MLjIQxS+9ZmLX9NbHaF8Gd4+50qA sfv9HnPYXXEYQU20LcgPw8NSOphUaGbUsbJB6jyxeJFKmOEvo4+1SupXOyD67uvH/l Bd2CgCDitlEQz9V08gQve53hwK3ZuFi9JNDZQ3k1TNahTA3Ai5C9fsxYz7Cneyrk1L l+LU+8uKVSzCbLKhs6yj1QXCWLKi3muFFMqiKyl6cvnl/7EJeFUlaLFQKFM8UcezVp tJwVXonUgjaJ5bW4zREyy9beOfKXVALci8Vjlxsfbq0Zr9iW+MzI6ptrjPDaeDNZoA WACVFyRbw8qZg==
Date: Wed, 23 Sep 2015 20:18:07 -0700
From: Andrew Ayer <agwa@andrewayer.name>
To: Richard Barnes <rlb@ipv.sx>
Message-Id: <20150923201807.fa3b401ce56f5325d8758c21@andrewayer.name>
In-Reply-To: <CAL02cgR+a_5osWDQ=Ly9EFWzrdw+WH7zWvyzgmhs3bDBztL1Pw@mail.gmail.com>
References: <CAL02cgR+a_5osWDQ=Ly9EFWzrdw+WH7zWvyzgmhs3bDBztL1Pw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/acme/oxG2lpgQD8ltCJWYNZB3t0VD6eo>
Cc: "acme@ietf.org" <acme@ietf.org>
Subject: Re: [Acme] Proposed fix to signature reuse vulnerability
X-BeenThere: acme@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Automated Certificate Management Environment <acme.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/acme>, <mailto:acme-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/acme/>
List-Post: <mailto:acme@ietf.org>
List-Help: <mailto:acme-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/acme>, <mailto:acme-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Sep 2015 04:18:37 -0000

On Thu, 17 Sep 2015 11:20:02 -0400
Richard Barnes <rlb@ipv.sx> wrote:

> I realize there are some engineering ways this update could be made
> better, but before we start optimizing, I would like to get feedback
> on whether this change fixes the security issues that have been
> raised.

This change looks good to me, security-wise.  I'm pretty confident it
fully fixes the vulnerability and doesn't introduce any new flaws
(unlike the mitigation, which made me rather uneasy).

I do think there are some simplifications/optimizations that could be
made, but I'll raise those later.

-- Andrew