Re: [Add] WGLC for draft-ietf-add-dnr

Ben Schwartz <bemasc@google.com> Wed, 09 March 2022 18:40 UTC

Return-Path: <bemasc@google.com>
X-Original-To: add@ietfa.amsl.com
Delivered-To: add@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 24B5E3A02BB for <add@ietfa.amsl.com>; Wed, 9 Mar 2022 10:40:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -17.61
X-Spam-Level:
X-Spam-Status: No, score=-17.61 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9fw64jGNhwey for <add@ietfa.amsl.com>; Wed, 9 Mar 2022 10:40:11 -0800 (PST)
Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7B96C3A0120 for <add@ietf.org>; Wed, 9 Mar 2022 10:40:11 -0800 (PST)
Received: by mail-io1-xd30.google.com with SMTP id z7so3832090iom.1 for <add@ietf.org>; Wed, 09 Mar 2022 10:40:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CbgxK/WqjHM+r0OLSzUQrQMkApq8WaqiRHdroaDmoTk=; b=IWlkZeNychPFvXDlGcpPA+11TlUnoYkbAq6KYqwmchBnVIOi4HzQf+EHAFI5qR/9iW irNwn6p6Z/xkxdCmMcmnaAobemRQCJh/o8htS1EtrgYxYVkIAkXRPb0fjN2JdDoBEmr1 iQdNkoxu6EGFsNyenTu0B2+Sa6I8whuTdE3kJ0R1t2ZR9ZzKWlAU6w8tR0HJ0DDA0ktY 11RV6RqYS8uUlcs9bT0ugVNGIZgbFH217Fj+xQBiv7/ad2aaLC21KRPw8YIkc75XkIDX DoE2QcABMrYOYlA4Eu4dw18dkqHEKPaIm76rYnKBFaVatiS5IrpPt/6wMbRGuwb4P+UN PFUg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CbgxK/WqjHM+r0OLSzUQrQMkApq8WaqiRHdroaDmoTk=; b=nyX9pIXrneWUb1NZWUPGM1OkmePn3ljqzWLocesS6aCmR5umHbQzLPBpt/ajoL1F2D +O7lt2oFaLGjHj0XPgAUYBdZGIax6NHDuZs9UACtxsjdaff3McoIwiflLbQ/ATnf7kRm QfIVyUrMY8kLoP+kvJz+1ZSC2OllJO7VsFFPhl2tpY6n74Yu94coXbP2xdB96qft4XxN fV1c5zf2pneX/VThKPBYLUhHnFeI+wkZ+onLT2HHoTeh6vdP5X1rXhJErJlaH7S9y9T5 //DM3iPOx0uDu3XszI/SoodHMJ1Hl20zqad4CkOwye34jL0psHrdIoxyMHUtp5fKKP6R rzpA==
X-Gm-Message-State: AOAM530Y64hNn749rx9ofgzdsbhDb3pUfyAxPj30TIkGjvzxBWMb6KGK XpUt1aqFFk+Bn5LLc3YgYkY9OX5cLQI3fA2RWppvng==
X-Google-Smtp-Source: ABdhPJzvA9Ao5hIT4JY+Ul20WVaTOihftK0xC5JPQJJ87nFPDk73HVJSnrWG3Zwt0/HdJKYUMuBHzl+SMuFuIept3UY=
X-Received: by 2002:a5d:89d8:0:b0:645:d853:66f0 with SMTP id a24-20020a5d89d8000000b00645d85366f0mr768149iot.30.1646851210323; Wed, 09 Mar 2022 10:40:10 -0800 (PST)
MIME-Version: 1.0
References: <16DE320C-B15A-4674-9359-B35B5C263D00@comcast.com> <CAHbrMsBYOwsenfx3gVRtDtZahVQtoL0PO26MUeaKKsLPNm0SEA@mail.gmail.com> <17414_1646380597_6221C635_17414_54_1_787AE7BB302AE849A7480A190F8B93303549EB0D@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
In-Reply-To: <17414_1646380597_6221C635_17414_54_1_787AE7BB302AE849A7480A190F8B93303549EB0D@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
From: Ben Schwartz <bemasc@google.com>
Date: Wed, 09 Mar 2022 13:39:59 -0500
Message-ID: <CAHbrMsDc6B6k-p5GWOaKPy8zPr0XuLB332vdhwNxF8add2spVg@mail.gmail.com>
To: mohamed.boucadair@orange.com
Cc: "Deen, Glenn" <Glenn_Deen@comcast.com>, "add@ietf.org" <add@ietf.org>
Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg="sha-256"; boundary="0000000000006a62ed05d9cd6d79"
Archived-At: <https://mailarchive.ietf.org/arch/msg/add/A_VtDJ95nNSVJQ3573PskotLwTs>
Subject: Re: [Add] WGLC for draft-ietf-add-dnr
X-BeenThere: add@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Applications Doing DNS <add.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/add>, <mailto:add-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/add/>
List-Post: <mailto:add@ietf.org>
List-Help: <mailto:add-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/add>, <mailto:add-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Mar 2022 18:40:16 -0000

On Fri, Mar 4, 2022 at 2:56 AM <mohamed.boucadair@orange.com> wrote:

> Hi Ben,
>
>
>
> That was considered in the past, but we need also to listen to the
> guidelines that are specific to each of these protocols. For example, a
> reco from DHC is to start with fixed length fields, this is why we have
> SvcPriority first not the order you propose.
>

I don't think we should attempt to apply these guidelines on our own.  If
they are indeed applicable in this case, I'd like to get that confirmed
from some relevant subject matter experts.

Likewise, SvcPriority is not present in RA because this can be inferred
> from the order appearance while this is not possible for DHCP as already
> recorded in the doc:
>
>
>
>    The DHCP options defined in Sections 4
> <https://datatracker.ietf.org/doc/html/draft-ietf-add-dnr#section-4> and 5
> <https://datatracker.ietf.org/doc/html/draft-ietf-add-dnr#section-5>
> follow the option
>
>    ordering guidelines in Section 17 of [RFC7227]
> <https://datatracker.ietf.org/doc/html/rfc7227#section-17>.
>
>
>
>    “Option order, either the order among many DHCPv6 options or the order
>
>    of multiple instances of the same option, SHOULD NOT be significant.
>
>    New documents MUST NOT assume any specific option processing order.”
>
>
Thanks for noting this.  A similar rule applies to to IPv6 RA (
https://www.rfc-editor.org/rfc/rfc4861#section-9):

   Options in Neighbor Discovery packets can appear in any order;
   receivers MUST be prepared to process them independently of their
   order.

Evidently we'll need to change that format in the draft.

Likewise, we don’t want to create a precedent for self-delimiting variable
> length fields but followed the guidelines from these groups to have an
> explicit length field for each variable length.
>

Where is that guidance written?

Here are some examples of concatenated self-delimiting variable-length
fields being used:
* IPv6 NDP Options
  - DNSSL domains (https://www.rfc-editor.org/rfc/rfc8106.html#section-5.2)
  - PvD domains (
https://www.rfc-editor.org/rfc/rfc8801.html#name-pvd-option-for-router-adver
)
  - CARD Sub-Options (https://www.rfc-editor.org/rfc/rfc4066#section-5.1.2.2
)
* DHCP
  - DNS Search List (https://www.rfc-editor.org/rfc/rfc3397.html#section-2)
  - SIP Domain List (https://www.rfc-editor.org/rfc/rfc6011.html#section-4.1
)
  - RDNSS (https://www.rfc-editor.org/rfc/rfc6731.html#section-4.2)
  - Mobility Service (https://www.rfc-editor.org/rfc/rfc5678.html#section-3)


> We need to be careful here because we are in an area where we need to take
> into account what the owners of these protocols maintain the protocol, not
> only what would be perfect for a specific application.
>

I agree.  If we're in doubt about their expectations, let's get more input
from them.