Re: [alto] Review of draft-ietf-alto-performance-metrics-02

Qin Wu <bill.wu@huawei.com> Thu, 30 November 2017 06:48 UTC

Return-Path: <bill.wu@huawei.com>
X-Original-To: alto@ietfa.amsl.com
Delivered-To: alto@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 113791200F1 for <alto@ietfa.amsl.com>; Wed, 29 Nov 2017 22:48:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.22
X-Spam-Level:
X-Spam-Status: No, score=-4.22 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XdTljeHFDFnu for <alto@ietfa.amsl.com>; Wed, 29 Nov 2017 22:48:31 -0800 (PST)
Received: from huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5FD6212025C for <alto@ietf.org>; Wed, 29 Nov 2017 22:48:31 -0800 (PST)
Received: from LHREML711-CAH.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id D8A3ADE4261C2 for <alto@ietf.org>; Thu, 30 Nov 2017 06:48:27 +0000 (GMT)
Received: from NKGEML413-HUB.china.huawei.com (10.98.56.74) by LHREML711-CAH.china.huawei.com (10.201.108.34) with Microsoft SMTP Server (TLS) id 14.3.361.1; Thu, 30 Nov 2017 06:48:29 +0000
Received: from NKGEML513-MBX.china.huawei.com ([169.254.1.219]) by NKGEML413-HUB.china.huawei.com ([10.98.56.74]) with mapi id 14.03.0361.001; Thu, 30 Nov 2017 14:48:24 +0800
From: Qin Wu <bill.wu@huawei.com>
To: Kai Gao <gaok12@mails.tsinghua.edu.cn>, IETF ALTO <alto@ietf.org>
Thread-Topic: [alto] Review of draft-ietf-alto-performance-metrics-02
Thread-Index: AQHTZ/HbU/oLV/kJxU+xiyro5xDTnKMsfBSw
Date: Thu, 30 Nov 2017 06:48:24 +0000
Message-ID: <B8F9A780D330094D99AF023C5877DABA9ACDAC75@nkgeml513-mbx.china.huawei.com>
References: <234e15ae-8d38-489e-1293-41070e756466@mails.tsinghua.edu.cn>
In-Reply-To: <234e15ae-8d38-489e-1293-41070e756466@mails.tsinghua.edu.cn>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.136.79.67]
Content-Type: text/plain; charset="gb2312"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/alto/VWjFcFP8IP09kuDTyQmvXVSyBTA>
Subject: Re: [alto] Review of draft-ietf-alto-performance-metrics-02
X-BeenThere: alto@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Application-Layer Traffic Optimization \(alto\) WG mailing list" <alto.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/alto>, <mailto:alto-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/alto/>
List-Post: <mailto:alto@ietf.org>
List-Help: <mailto:alto-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/alto>, <mailto:alto-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Nov 2017 06:48:33 -0000

Thanks Kai for valuable review, please see my reply inline below.

-----邮件原件-----
发件人: alto [mailto:alto-bounces@ietf.org] 代表 Kai Gao
发送时间: 2017年11月28日 10:37
收件人: IETF ALTO
主题: [alto] Review of draft-ietf-alto-performance-metrics-02

Dear ALTO working group,

Below is a review of draft-ietf-alto-performance-metrics-02. Most of them are minor edits and I think section 2 could be better organized. 
Your feedback and comments are highly appreciated.

Thanks!

Regards,

Kai


============================================================


p3, table 1, last row:
missing a "]"

[Qin]: Fixed.

p3, introduction, last paragraph

"explicitly specified" -> "standard" or "ISP independent"

[Qin]: I prefer to change it into "standard".
p4, 2nd para

"If some are subject to ... them to the client"

Could be

"For example, those that are subject to privacy concerns should not be provided to unauthorized ALTO clients."

[Qin]:Good, accepted.
p4, figure 1

"retrieve and aggregation" -> "retrieval and aggregation"

[Qin]:It is typo, fixed.
p4, 3rd para

SHOULD -> MUST since if a metric is not announced to clients in IRD, it's strange to say it's "supported".

[Qin]: Agree to change RFC2119 language into MUST.

p4, 4th para

further versions -> maybe "future extensions" is better? Can we add new types if this document becomes standard?

[Qin]: Good suggested change, I think new types should be added in the future extension rather than in this document.
I don't think we should enumerate all possible metrics in this base drafts. But definitely we should allow future extension for this base model draft.

as for example, ... metrics. -> such as many metrics related to end-to-end path bandwidth.

[Qin]: Accepted, thanks.

ALTO may convey ... capacity related measurements. -> I don't quite understand this part. Is it saying ALTO should provide some unified aggregation mechanism since these metrics cannot be provided by a single party?

[Qin]: Good catch, as I said earlier, this draft is not aimed to include all the metrics. To avoid confusion, I suggest just remove the last two sentences.
p4, 5th para

will rapidly give up... -> SHOULD/CAN rapidly give up

[Qin]: I prefer to change to SHOULD, thanks.

sec2

I wonder if we could use "Data sources and computation of ALTO performance cost metrics". Many metric specifications point back to this section so I think it should also give guidelines or suggestions while talking about challenges.

[Qin]: I think the guidelines or suggestions has already been provided following the challenge that is described in each paragraph. Let me know if you believe we miss anything.

The specifications are generally good but is it possible to split the examples a bit? There are many large blank blocks.

[Qin]: Good catch, we can remove these blank blocks by splitting examples.
_______________________________________________
alto mailing list
alto@ietf.org
https://www.ietf.org/mailman/listinfo/alto