IETF Logo Mail Archive

Re: [Anima] Review comments on draft-ietf-anima-grasp-api

Brian E Carpenter <brian.e.carpenter@gmail.com> Wed, 18 September 2019 20:38 UTC

Return-Path: <brian.e.carpenter@gmail.com>
X-Original-To: anima@ietfa.amsl.com
Delivered-To: anima@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A9477120112 for <anima@ietfa.amsl.com>; Wed, 18 Sep 2019 13:38:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hdb629L1GNlg for <anima@ietfa.amsl.com>; Wed, 18 Sep 2019 13:38:38 -0700 (PDT)
Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 40E06120086 for <anima@ietf.org>; Wed, 18 Sep 2019 13:38:38 -0700 (PDT)
Received: by mail-pl1-x629.google.com with SMTP id t10so497376plr.8 for <anima@ietf.org>; Wed, 18 Sep 2019 13:38:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=NgJrND3P/zwc17R5i7NN7ByN4O8d+yaQVaeC1GmtaUg=; b=g+c6fZA+8yhHGN4WrbBZvg96gn0uZVJ0A9Uaqzv2b95jCzi1GJWt4wVDUufUumqSOt HnxCRseqdaLw6TJGke8AetigmQTw+MQvT3dkS3052YglUQpVa3k++y4V9q8uKyq8nUlA 3X3R2IZ+QYIJe64OK1wcIP7j9DeCzY4O2Minhl96M1WO/wcFXHgp+tyKTliAehu6S0/k guBuejJZGhWZO0QX1izWT2vrj3rOb7NxZcB0E5vCXIXmjElrLS5WGf8uZsI9X8VgbNlT IRaK08waUffw0obQdJoP/2+D6enX5Eh7N17PNMJEq2g2VFYNZ3AuMhVXPpsq9X0FaA0q eHjw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NgJrND3P/zwc17R5i7NN7ByN4O8d+yaQVaeC1GmtaUg=; b=BzDIlFht0HBnyhWADAD2d+Wcaul3ZDfmf+7Lu1wzfa0zTz7tK94WoWhBXMXqfD/GzE 3xPVlm2fAQxThKXiiEHi+myv6CeCu9oET8A+eLHFHD25rV17Xx5X+YgbDtKuMyfM0zyS mvESNWZdjqbnJ5z0h/oWVzmOYxEUOcWxqsxjw9uZZHIq1EZXXta0hkA25iGuDldFsKeG vreukirrf1wEZh7ionz11lkGxG+baDlMAM476Esl9xH28e2cahFMcLDaAoEstpfpW387 y5x58sdJMnRaF0OGjrUmHxYsGoClEm0aCs4RS4TvDhIuiLTyGCU392p5F33FDqZZrsWw ZBvw==
X-Gm-Message-State: APjAAAXzbrKfeVwD2cvpXljtmTvPMI7FAUmS71rZ/HXYFfB3rTj7MsHG FOyMW1f0EjaAQ4Cxgfuax9+A2ovt
X-Google-Smtp-Source: APXvYqx6EL3AGo5kT2TCNTqKfoo2g0OeIvOswnfJNlkWjl3Jn+ankBWBSNX9LlQ1xHumxOOFN2sjug==
X-Received: by 2002:a17:902:7d8b:: with SMTP id a11mr6178158plm.149.1568839117495; Wed, 18 Sep 2019 13:38:37 -0700 (PDT)
Received: from [192.168.178.30] (82.206.69.111.dynamic.snap.net.nz. [111.69.206.82]) by smtp.gmail.com with ESMTPSA id k4sm3133846pjl.9.2019.09.18.13.38.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Sep 2019 13:38:36 -0700 (PDT)
To: "Liguangpeng (Roc, Network Technology Laboratory)" <liguangpeng@huawei.com>, "anima@ietf.org" <anima@ietf.org>
References: <6F4E6B0C717D4641A2B79BC1740D8CF4A7E22578@DGGEMM533-MBX.china.huawei.com>
From: Brian E Carpenter <brian.e.carpenter@gmail.com>
Message-ID: <59be9ae2-9ccf-a5aa-1b70-5075574a05d3@gmail.com>
Date: Thu, 19 Sep 2019 08:38:34 +1200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <6F4E6B0C717D4641A2B79BC1740D8CF4A7E22578@DGGEMM533-MBX.china.huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/anima/17I0AuYiR5slD_fN1Cdt9Wyrb-U>
Subject: Re: [Anima] Review comments on draft-ietf-anima-grasp-api
X-BeenThere: anima@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Autonomic Networking Integrated Model and Approach <anima.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/anima>, <mailto:anima-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/anima/>
List-Post: <mailto:anima@ietf.org>
List-Help: <mailto:anima-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/anima>, <mailto:anima-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Sep 2019 20:38:40 -0000

On 18-Sep-19 18:22, Liguangpeng (Roc, Network Technology Laboratory) wrote:
> Hi authors,  
> 
> I read the draft. I think the API list for grasp is complete and good. But I have some comments on section 2.2.
> 
> 2.2. Asynchronous Operations
> 
> '... there are two main techniques for such parallel operations: multi-threading, or a polling or 'event loop' structure.'  
> 
> According to my knowledge, 'multi-threading' is a different thing with asynchronous programming mechanism. So I prefer to 'asynchronous programming mechanisms with multi-threading' here.

OK, will rephrase.

> The main techniques for asynchronous programming discussed in draft should be 'polling', however, polling is not so efficient. The more efficient one is 'call back' mechanism.

Yes, we certainly need to discuss callbacks. I'm not sure it is always more efficient, because that depends on the underlying implementation.

> 'session_nonce' parameter may be useful for polling, but 'call back function pointer( or reference in some programming language)' is normally used as parameter of invoked functions. All logics should be executed in call back functions which will be called when some events occur, for example receiving response message for the request, or message timeout.

Yes. However, if you have two simultaneous negotiations, you will still need the session_nonce in the callback, I believe.

Thanks very much,

    Brian

>  
> Best regards,
> 
> Guangpeng Li

v2.23.0 | Report a Bug | By Email