Re: [Anima] Iotdir telechat review of draft-ietf-anima-bootstrapping-keyinfra-17

Russ Housley <housley@vigilsec.com> Thu, 13 December 2018 17:16 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: anima@ietfa.amsl.com
Delivered-To: anima@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2E3E4130E35 for <anima@ietfa.amsl.com>; Thu, 13 Dec 2018 09:16:26 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vmsia-nnq-r8 for <anima@ietfa.amsl.com>; Thu, 13 Dec 2018 09:16:23 -0800 (PST)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 725CF130E3A for <anima@ietf.org>; Thu, 13 Dec 2018 09:16:23 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id 194A0300A4B for <anima@ietf.org>; Thu, 13 Dec 2018 12:16:21 -0500 (EST)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VN9lBySyW96P for <anima@ietf.org>; Thu, 13 Dec 2018 12:16:19 -0500 (EST)
Received: from [192.168.1.161] (pool-108-45-137-105.washdc.fios.verizon.net [108.45.137.105]) by mail.smeinc.net (Postfix) with ESMTPSA id 0C46F300A20; Thu, 13 Dec 2018 12:16:19 -0500 (EST)
From: Russ Housley <housley@vigilsec.com>
Message-Id: <0AB99A18-C0D0-4F99-9416-FBD8350E4502@vigilsec.com>
Content-Type: multipart/signed; boundary="Apple-Mail=_F0965590-7B89-4467-BA9C-CE57D50B6124"; protocol="application/pgp-signature"; micalg="pgp-sha1"
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Date: Thu, 13 Dec 2018 12:16:20 -0500
In-Reply-To: <20444.1544718427@localhost>
Cc: "iot-dir@ietf.org" <Iot-dir@ietf.org>, draft-ietf-anima-bootstrapping-keyinfra.all@ietf.org, IETF <ietf@ietf.org>, anima@ietf.org
To: Michael Richardson <mcr+ietf@sandelman.ca>
References: <154388094719.4951.644465000786184923@ietfa.amsl.com> <20444.1544718427@localhost>
X-Mailer: Apple Mail (2.3445.102.3)
Archived-At: <https://mailarchive.ietf.org/arch/msg/anima/81EWtUgwSel19zL79cM2D4JkGIQ>
Subject: Re: [Anima] Iotdir telechat review of draft-ietf-anima-bootstrapping-keyinfra-17
X-BeenThere: anima@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Autonomic Networking Integrated Model and Approach <anima.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/anima>, <mailto:anima-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/anima/>
List-Post: <mailto:anima@ietf.org>
List-Help: <mailto:anima-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/anima>, <mailto:anima-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Dec 2018 17:16:34 -0000

>> Section 3.1 shows the YANG tree model of the Voucher-Request.  I am far
>> from a YANG expert, but I expected a subsequent section to describe the
>> semantics of each field.  The examples in Section 3.2 are useful, but
>> they are not a replacement.  Some fields (like voucher/expires-on) are
>> not described in Section 3.3.  I assume that this is building on another
>> module because this one contains "import ietf-voucher", but this does
>> not say what RFC contains the imported module to learn the rest of the
>> semantics.
> 
> I think that the sentence:
>  The notation used in this diagram is described in [RFC8366].
> 
> should be changed to say:
>   The voucher-request builds upon
>   the voucher artifact described in <xref target="RFC8366" />.
>   The tree diagram is described in <xref target="RFC8340" />.
> 
> (we described tree-diagrams in 8366 at one point, because we didn't know if
> 8340 would get published in time)

Okay.  That works for me.

> 
>> I think that the CDDL in Sections 4.1.1 and 4.3 are supposed to be
>> structures.  If that is correct, the structure should look something
>> like the following, which includes type information:
>> 
>>   basic-header = [
>>     field1: int,
>>     field2: text,
>>   ]
>> 
>>   advanced-header = [
>>     ~basic-header,
>>     field3: bytes,
>>     field4: ~time,
>>   ]
> 
> We are filling in the gaps for the definition in GRASP M_FLOOD
> mechanism.  We aren't defining a new structure.
> I'm not sure if we can do this any other way.

Something needs to be done to set the context.  Clearly, I misunderstood the intent.

>> I have no idea what the boxes in Figure 10 represent.
> 
> Hmm. I guess we chopped the boxes off of the flow from section 2.4.
> Would a reference back to section 2.4 help?
> Maybe we should not repeat the boxes.

I reference to Section 2.4 with no boxes would be more helpful than the current figure.

>> Section 7.2 does not contain enough information to make the needed
>> object identifier assignments.
> 
> Right we had a note to fix that. It's: SMI Security for PKIX Certificate Extension
>  https://www.iana.org/assignments/smi-numbers/smi-numbers.xml#smi-numbers-1.3.6.1.5.5.7.1

I guessed that, but no guessing should be needed for IANA registry assignment.

Russ