[apps-discuss] Review of: draft-ietf-appsawg-file-scheme-11

Dave Crocker <dhc2@dcrocker.net> Sun, 14 August 2016 00:05 UTC

Return-Path: <dhc2@dcrocker.net>
X-Original-To: apps-discuss@ietfa.amsl.com
Delivered-To: apps-discuss@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ABAE112B006; Sat, 13 Aug 2016 17:05:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.999
X-Spam-Level:
X-Spam-Status: No, score=-0.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, RDNS_NONE=0.793, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_DKIM_INVALID=0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=dcrocker.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u6iXbZ7MJUPA; Sat, 13 Aug 2016 17:05:41 -0700 (PDT)
Received: from simon.songbird.com (unknown [72.52.113.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1963612D17A; Sat, 13 Aug 2016 17:05:41 -0700 (PDT)
Received: from [192.168.1.168] (76-218-8-128.lightspeed.sntcca.sbcglobal.net [76.218.8.128]) (authenticated bits=0) by simon.songbird.com (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id u7E05jPg028038 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NOT); Sat, 13 Aug 2016 17:05:45 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dcrocker.net; s=default; t=1471133146; bh=Uu1TBme8v0Inzsc1z39SjOvShspyk/QYSkogU+BP9ew=; h=From:Subject:To:Reply-To:Date:From; b=T2wwAicf4WZU+ogQVy9CICcus8nITC9oCcLSGufio+OWoKX7NEXuH3NFtLLwCb05U N3PeJL7xenhqZzf6WKwLrRmYpbal0IMynFVche8GE4UHuU5dZbxIaX/oHfvgFyZ7v4 fTpyijMmOCp64Pn2R0cBY7L/XiggdklKXgN/+Rwg=
From: Dave Crocker <dhc2@dcrocker.net>
Organization: Brandenburg InternetWorking
To: draft-ietf-appsawg-file-scheme@ietf.org, art-ads@ietf.org, apps-discuss@ietf.org
Message-ID: <80ffb57e-8af1-e3a0-c35c-80666a5143e7@dcrocker.net>
Date: Sat, 13 Aug 2016 17:05:07 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/apps-discuss/2iRzzeiSIUDFhcJMxWXvEQS-QC4>
Subject: [apps-discuss] Review of: draft-ietf-appsawg-file-scheme-11
X-BeenThere: apps-discuss@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: dcrocker@bbiw.net
List-Id: General discussion of application-layer protocols <apps-discuss.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/apps-discuss/>
List-Post: <mailto:apps-discuss@ietf.org>
List-Help: <mailto:apps-discuss-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Aug 2016 00:05:41 -0000

Review:   The file URI Scheme
ID:       draft-ietf-appsawg-file-scheme-11
Review Date:  13 Aug 2016
Reviewer:     D. Crocker <dcrocker@bbiw.net>


Summary
-------

This is a followup to my Document Shepherd review of the -05 version on 
12 April 2016.

The document changes are effective.  I found only a few places to make a 
few suggestions, mostly minor.[*]

There is one significant concern, in Section 3, which continues from the 
previous review and I've suggested replacement text and this is the 
presence of normative language.

After resolution of this one concern, the document will be ready for 
publication.

Nice job!

d/




> 1.1.  Notational Conventions
>
>    The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT",
>    "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this
>    document are to be interpreted as described in [RFC2119].
>
>    Throughout this document the term "local file" is used to describe
>    files that can be accessed through the local file system API using
>    only the information included in the file path, not relying on other
>    information such as network addresses.  It is important to note that
>    a local file may not be physically located on the local machine, for
>    example if a networked file system is transparently mounted into the
>    local file system.
>
>    The term "local file URI" is used to describe file URIs which have no
>    authority component, or where the authority is the special string

probably should be: "authority" component, given the surrounding 
conventions used in this paragraph.


>    "localhost" or a fully qualified domain name that resolves to the
>    machine from which the URI is being interpreted (Section 2).
>
> 2.  Syntax
...
>       file-URI       = file-scheme ":" file-hier-part
>       file-scheme    = "file"
>
>       file-hier-part = ( "//" auth-path )
>                      / local-path
>
>       auth-path      = [ file-auth ] path-absolute

Hmmm.  I wondered how file-auth and path-absolute were separated, but 
see from Section 3.3 of RFC 3986 that path-absolute beings with a "/".

I think this means that if there is no file-auth, the beginning will be 
"file:///" etc.  Is that intended?

>
>       local-path     = path-absolute
>
>       file-auth      = "localhost"
>                      / host
>
>    The "host" is the fully qualified domain name of the system on which
>    the file is accessible.  This allows a client on another system to
>    know that it cannot access the file system, or perhaps to use some

   perhaps to use -> or perhaps that they need to use


>    other local mecahnism to access the file.
...
>
>    Some file systems have case-sensitive file naming and some do not.
>    As such the file URI scheme supports case sensitivity, in order to
>    retain the case as given.  Any transport-related handling of the file
>    URI scheme MUST retain the case as given.  Any mapping to or from a
>    case-insensitive form is soley the responsibility of the

  soley -> solely


>    implementation processing the file URI on behalf of the referenced
>    file system.
>
>    Some file systems allow directory objects to be treated as files in
>    some cases.  This can be reflected in a file URI by omitting the
>    trailing slash "/" from the path.  Be aware that merging a relative

oh?  I would have thought it would have required retaining a trailing 
"/" if the URI is for a folder, and dropping it if it refers to a file...


>    URI reference to such a base URI as per Section 5.2 of [RFC3986]
>    could remove the directory name from the resulting target URI.
...

> 3.  Operations Involving file URIs

I am going to again raise a concern about this.  The document isn't 
providing enough detail about the processing of URIs to be meaningful, 
nevermind normative.  (I can even argue that the normative directive 
here is wrong in various write-only cases.  One might respond that 
that's why it's a SHOULD rather than MUST, but my view of SHOULDs is 
that violating them needs to be exceptional, and activities like 
write-only sensor networks don't strike me as that special.

In other words, I encourage remove all normative language here.  I 
believe the easiest and most reasonable action is to remove the first 
two sentences, below, and start with "See the".


...

> 4.  File System Name Encoding
>
>    File systems use various encoding schemes to store file and directory
>    names.  Many modern file systems store file and directory names as
>    arbitrary sequences of octets, in which case the representation as an
>    encoded string often depends on the user's localization settings, or
>    defaults to UTF-8 [STD63].
>
>    When a file URI is produced, characters not allowed by the syntax in
>    Section 2 SHOULD be percent-encoded as characters using UTF-8
>    encoding, as per [RFC3986], Section 2.5.
>
>    However, encoding information for file and/or directory names might
>    not be available.  In these cases, implementations MAY use heuristics
>    to determine the encoding.  If that fails, they SHOULD percent-encode
>    the raw bytes of the label directly.

An IETF protocol that has normative language allowing heuristics is 
asking for all sorts of problems.  And here I believe it isn't 
necessary, though I think I understand the difficulty you are trying to 
deal with.

Consider this as a replacement for the above paragraph:

      A decision not to use percent-encoding is outside the scope of 
this specification.  It will typically require use of heuristics or 
explicit knowledge about the way the string will be processed.



d/

[*] I'll mention that I've just come off of reviewing 3 other documents 
that I found highly problematic and was probably in an unusually 
cantankerous mood when reviewing the file scheme revision here.  So I 
actually put some effort into looking for clarity and correctness 
problems, especially in the core part of the document, Section 2.  It 
was really quite pleasant to /fail/ in that effort.  Thanks!


-- 

   Dave Crocker
   Brandenburg InternetWorking
   bbiw.net