Re: [apps-discuss] draft-ietf-appsawg-json-merge-patch-04: now with a new processing model

+1

Pseudo code works well for describing the merge process.

The only remaining non-editorial change required is to remove the following sentence from section 1 "Introduction":

   A JSON merge patch document can only be a JSON array or a JSON
   object.

The pseudo code does not implement this restriction. Two of the test cases in appendix A violate this restriction.

Editorial suggestions:

* Change "marge" to "merge" [section 2, 2nd paragraph, page 3]

* The abstract and into both include the following phrase that is a bit awkward:

   modifications to a subset of target resource's content.

Might read better as:

   modifications to a target resource's content.

* It would be worth explicitly stating that the target resource and merge patch are JSON values. Add a sentence to the end of the 2nd paragraph of section 2 so it reads:

   MergePatch ... takes two arguments: the target resource document
   and the merge patch document. The Target argument can be any
   JSON value, or undefined. The Patch argument can be any JSON value.

* Is the contact in the media type registration (section 4 "IANA Considerations") usually an author as in the draft, or is it better to use, say, IESG <iesg@ietf.org>?

* In section 4 "IANA Considerations" change:
  "same encoding considerations specified in Section 6 [RFC7159]."
  To
  "same encoding considerations specified in Section 8 [RFC7159]."

--
James Manger

-----Original Message-----
From: apps-discuss [mailto:apps-discuss-bounces@ietf.org] On Behalf Of Paul Hoffman
Sent: Saturday, 5 July 2014 4:48 AM
To: IETF Apps Discuss
Subject: [apps-discuss] draft-ietf-appsawg-json-merge-patch-04: now with a new processing model

Greetings again. This draft incorporates the proposed changes from Carsten and James, as well as removing the charset option from the MIME type (based on input from Ned Freed). 

Please review my new pseudocode, and the new examples at the end.

--Paul Hoffman

On Jul 4, 2014, at 11:44 AM, internet-drafts@ietf.org wrote:

> 
> A New Internet-Draft is available from the on-line Internet-Drafts directories.
> This draft is a work item of the Applications Area Working Group Working Group of the IETF.
> 
>        Title           : JSON Merge Patch
>        Authors         : Paul Hoffman
>                          James M Snell
> 	Filename        : draft-ietf-appsawg-json-merge-patch-04.txt
> 	Pages           : 8
> 	Date            : 2014-07-04
> 
> Abstract:
>   This specification defines the JSON merge patch format and processing
>   rules.  The merge patch format is primarily intended for use with the
>   HTTP PATCH method as a means of describing a set of modifications to
>   a subset of target resource's content.
> 
> 
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-appsawg-json-merge-patch/
> 
> There's also a htmlized version available at:
> http://tools.ietf.org/html/draft-ietf-appsawg-json-merge-patch-04
> 
> A diff from the previous version is available at:
> http://www.ietf.org/rfcdiff?url2=draft-ietf-appsawg-json-merge-patch-04

_______________________________________________
apps-discuss mailing list
apps-discuss@ietf.org
https://www.ietf.org/mailman/listinfo/apps-discuss