IETF Logo Mail Archive

Re: [apps-discuss] APPSDIR review of draft-ietf-dime-realm-based-redirect-11

<lionel.morand@orange.com> Wed, 28 August 2013 10:32 UTC

Return-Path: <lionel.morand@orange.com>
X-Original-To: apps-discuss@ietfa.amsl.com
Delivered-To: apps-discuss@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B772C11E81B7; Wed, 28 Aug 2013 03:32:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.369
X-Spam-Level:
X-Spam-Status: No, score=-2.369 tagged_above=-999 required=5 tests=[AWL=0.229, BAYES_00=-2.599, UNPARSEABLE_RELAY=0.001]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HBlLvgnOo5F9; Wed, 28 Aug 2013 03:32:03 -0700 (PDT)
Received: from relais-inet.francetelecom.com (relais-ias91.francetelecom.com [193.251.215.91]) by ietfa.amsl.com (Postfix) with ESMTP id E25AD11E816F; Wed, 28 Aug 2013 03:32:02 -0700 (PDT)
Received: from omfedm08.si.francetelecom.fr (unknown [xx.xx.xx.4]) by omfedm12.si.francetelecom.fr (ESMTP service) with ESMTP id 90A7318C50F; Wed, 28 Aug 2013 12:32:01 +0200 (CEST)
Received: from Exchangemail-eme1.itn.ftgroup (unknown [10.114.1.186]) by omfedm08.si.francetelecom.fr (ESMTP service) with ESMTP id 7189C2380D3; Wed, 28 Aug 2013 12:32:01 +0200 (CEST)
Received: from PEXCVZYM13.corporate.adroot.infra.ftgroup ([fe80::cc7e:e40b:42ef:164e]) by PEXCVZYH01.corporate.adroot.infra.ftgroup ([::1]) with mapi id 14.02.0328.009; Wed, 28 Aug 2013 12:32:01 +0200
From: lionel.morand@orange.com
To: Enrico Marocco <enrico.marocco@telecomitalia.it>, "apps-discuss@ietf.org" <apps-discuss@ietf.org>, "draft-ietf-dime-realm-based-redirect.all@tools.ietf.org" <draft-ietf-dime-realm-based-redirect.all@tools.ietf.org>
Thread-Topic: APPSDIR review of draft-ietf-dime-realm-based-redirect-11
Thread-Index: AQHOo81nZ8bK8Unm4kq1V+hCC3XKapmqaCEQ
Date: Wed, 28 Aug 2013 10:32:00 +0000
Message-ID: <6B7134B31289DC4FAF731D844122B36E257025@PEXCVZYM13.corporate.adroot.infra.ftgroup>
References: <521DBCB9.7010406@telecomitalia.it>
In-Reply-To: <521DBCB9.7010406@telecomitalia.it>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [10.197.38.1]
Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg="SHA1"; boundary="----=_NextPart_000_0014_01CEA3E8.D5F42310"
MIME-Version: 1.0
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2013.8.28.100630
X-Mailman-Approved-At: Wed, 28 Aug 2013 09:31:26 -0700
Cc: IESG <iesg@ietf.org>
Subject: Re: [apps-discuss] APPSDIR review of draft-ietf-dime-realm-based-redirect-11
X-BeenThere: apps-discuss@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: General discussion of application-layer protocols <apps-discuss.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/apps-discuss>
List-Post: <mailto:apps-discuss@ietf.org>
List-Help: <mailto:apps-discuss-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Aug 2013 10:32:07 -0000

Hi Enrico,

Thank you for the review and the good catches.
This will be easily fixed in the new version that the authors will produce
soon.

Regards,

Lionel

-----Message d'origine-----
De : Enrico Marocco [mailto:enrico.marocco@telecomitalia.it] 
Envoyé : mercredi 28 août 2013 11:03
À : apps-discuss@ietf.org;
draft-ietf-dime-realm-based-redirect.all@tools.ietf.org
Cc : IESG
Objet : APPSDIR review of draft-ietf-dime-realm-based-redirect-11

I have been selected as the Applications Area Directorate reviewer for
this draft (for background on APPSDIR, please see
http://trac.tools.ietf.org/area/app/trac/wiki/ApplicationsAreaDirectorate ).

Please resolve these comments along with any other Last Call comments
you may receive. Please wait for direction from your document shepherd
or AD before posting a new version of the draft.

Document: draft-ietf-dime-realm-based-redirect-11
Title: Realm-Based Redirection In Diameter
Reviewer: Enrico Marocco
Review Date: August 28, 2013
IETF Last Call Date: August 27, 2013

Summary: This draft is almost ready for publication as a Proposed
Standard RFC but has one major (easy-to-fix) issue and a minor issue
that should be fixed before publication.

Major issues:

In S. 3.4, both in title and body (easy fix, but "Major" in that it's
about a crucial part of the specified mechanism):

  s/DIAMETER_REDIRECT_INDICATION/DIAMETER_REALM_REDIRECT_INDICATION/


Minor issues:

The document makes use of general terms such as "application", "domain",
"realm" and "identity" that have a specific meaning in the Diameter
context, but it does not provide explicit definitions. It would be
useful if the document provided a list of Diamaeter-specific terms, and
a pointer to where they are defined. I suggest adding to the Terminology
section something along the line of:

  This document uses the terms "application", "realm", "domain",
  "identity" [..] consistently with the definitions provided in RFC
  6733 (Section 1.2, Section 1.3.4, Section 2.6, [..]).


Nits:

This review does not include editorial nits.

v2.23.0 | Report a Bug | By Email