Re: [apps-discuss] APPSDIR review of draft-ietf-simple-chat-13

Ben Campbell <ben@nostrum.com> Mon, 06 February 2012 14:35 UTC

Return-Path: <ben@nostrum.com>
X-Original-To: apps-discuss@ietfa.amsl.com
Delivered-To: apps-discuss@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AD1B421F8643; Mon, 6 Feb 2012 06:35:18 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.6
X-Spam-Level:
X-Spam-Status: No, score=-102.6 tagged_above=-999 required=5 tests=[AWL=0.000, BAYES_00=-2.599, SPF_PASS=-0.001, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AJRjPQ2F3iXq; Mon, 6 Feb 2012 06:35:18 -0800 (PST)
Received: from nostrum.com (nostrum-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:267::2]) by ietfa.amsl.com (Postfix) with ESMTP id D8FC321F8508; Mon, 6 Feb 2012 06:35:17 -0800 (PST)
Received: from [10.0.1.2] (cpe-76-187-92-156.tx.res.rr.com [76.187.92.156]) (authenticated bits=0) by nostrum.com (8.14.3/8.14.3) with ESMTP id q16EZFuG038805 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Mon, 6 Feb 2012 08:35:16 -0600 (CST) (envelope-from ben@nostrum.com)
Mime-Version: 1.0 (Apple Message framework v1257)
Content-Type: text/plain; charset="iso-8859-1"
From: Ben Campbell <ben@nostrum.com>
In-Reply-To: <4F2FA266.8040406@telecomitalia.it>
Date: Mon, 06 Feb 2012 08:35:28 -0600
Content-Transfer-Encoding: 7bit
Message-Id: <2B8404CA-7602-4143-9D2D-959EAA08F2C3@nostrum.com>
References: <4F2FA266.8040406@telecomitalia.it>
To: Enrico Marocco <enrico.marocco@telecomitalia.it>
X-Mailer: Apple Mail (2.1257)
Received-SPF: pass (nostrum.com: 76.187.92.156 is authenticated by a trusted mechanism)
X-Mailman-Approved-At: Mon, 06 Feb 2012 08:02:46 -0800
Cc: draft-ietf-simple-chat.all@tools.ietf.org, IESG <iesg@ietf.org>, "apps-discuss@ietf.org" <apps-discuss@ietf.org>
Subject: Re: [apps-discuss] APPSDIR review of draft-ietf-simple-chat-13
X-BeenThere: apps-discuss@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: General discussion of application-layer protocols <apps-discuss.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/apps-discuss>
List-Post: <mailto:apps-discuss@ietf.org>
List-Help: <mailto:apps-discuss-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Feb 2012 14:35:19 -0000

Thanks for the thorough review Enrico and Alexey!

Miguel and Geir Arne: What are your thoughts?

Thanks!

Ben.

On Feb 6, 2012, at 3:50 AM, Enrico Marocco wrote:

> Document: draft-ietf-simple-chat-13
> Title: Multi-party Chat Using the Message Session Relay Protocol (MSRP)
> Reviewers: Alexey Melnicov and Enrico Marocco
> Review Date: 2012-02-06
> IETF Last Call Date: 2012-02-06
> 
> 
> Summary: This draft is almost ready for publication as a Proposed
> Standard, but has a major issue to be taken into consideration and a few
> minor issues to be fixed.
> 
> 
> Major Issue
> 
> The document doesn't describe allowed characters in Nicks and any
> normalization that needs to be applied.
> 
> 
> Minor Issues
> 
> The document strictly forbids multiple To: headers in the CPIM message,
> that could be used for example to send public personal messages (i.e.
> messages addressed to some particular individual, but shared with the
> entire conference, a-la Twitter). If there's a reason for that, some
> explanation would be useful.
> 
> Figure 1 seems to imply that MSRP relays are mandatory. Since they are
> not -- and the draft is pretty clear about it -- I'd suggest to have
> some of MSRP flows in the diagram flow straight from the client to the
> switch.
> 
> A reference to the SDP mechanism defined in S. 8.  would be useful in in
> S. 5.2., last paragraph, S. 6.2, last paragraph, and in any other part
> that deals with discovering of client capability.
> 
> In Section 5.2:
> 
>    The conference focus of a chat room MUST learn the chat room
> 
> How can this be achieved? A forward pointer might be missing here.
> 
>    capabilities of each participant that joins the chat room.  The
>    conference focus MUST inform the MSRP switch of such support in
>    order to prevent the MSRP switch from distributing private messages
>    to participants who do not support private messaging.  The recipient
>    would not be able to render the message as private, and any
>    potential reply would be sent to the whole chat room.
> 
> In Section 7.1:
> 
>    The reservation of a nickname can fail, e.g. if the NICKNAME request
>    contains a malformed or non-existent Use-Nickname header field, or
>    if the same nickname has already been reserved by another
>    participant (i.e., by another URI) in the chat room.  The
>    validation can also fail where the sender of the message is not
>    entitled to reserve the nickname.  In any of these cases the MSRP
>    switch MUST answer the NICKNAME request with a 423 response.  The
>    semantics of the 423 response are: "Nickname usage failed; the
>    nickname is not allocated to this user".
> 
> It would be better to use different response codes for different error
> conditions.
> 
> 
> Nits [Only the few that came out in non-nitpicking read]
> 
> S. 3, REQ-3: s/depend no/depend on/
> 
> S. 4, second paragraph after Figure 2: s/a text/text/
> 
> A few 2119 refuses can be also found in the text, e.g.:
> 
> S. 5.2, sixth paragraph: s/URI must not/URI MUST NOT/
> 
>